| Summary: | Remove GetItemsInfo from tags/list.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | lucas, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 31306 | ||
| Bug Blocks: | 27272 | ||
| Attachments: |
Bug 31319: Remove GetItemsInfo from tags/list.pl
Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 31319: (QA follow-up) Search items directly (biblio not used yet) Bug 31319: (QA follow-up) Search items directly (biblio not used yet) |
||
|
Description
Jonathan Druart
2022-08-08 14:23:09 UTC
Created attachment 138829 [details] [review] Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with tags/list Test plan: List items on the modified view and confirm that all the info is displayed correctly Created attachment 138902 [details] [review] Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with tags/list Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 138910 [details] [review] Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with tags/list Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 138911 [details] [review] Bug 31319: (QA follow-up) Search items directly (biblio not used yet) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> follow-up is debatable - more readable before, but we don't use the biblio data (yet) so intermediary object is not needed testing something I am getting a 500 with the second patch DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394 The biblio is linked to a subscription. Created attachment 138914 [details] [review] Bug 31319: (QA follow-up) Search items directly (biblio not used yet) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> JD amended patch: add 'me' prefix to prevent failure if biblio is linked with a subscription DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! |