Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with tags/list.pl
Created attachment 138829 [details] [review] Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with tags/list Test plan: List items on the modified view and confirm that all the info is displayed correctly
Created attachment 138902 [details] [review] Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with tags/list Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 138910 [details] [review] Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with tags/list Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 138911 [details] [review] Bug 31319: (QA follow-up) Search items directly (biblio not used yet) Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
follow-up is debatable - more readable before, but we don't use the biblio data (yet) so intermediary object is not needed
testing something
I am getting a 500 with the second patch DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394 The biblio is linked to a subscription.
Created attachment 138914 [details] [review] Bug 31319: (QA follow-up) Search items directly (biblio not used yet) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> JD amended patch: add 'me' prefix to prevent failure if biblio is linked with a subscription DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.11. Nice work everyone, thanks!