Summary: | Add emails to message queue by longoverdue script options | ||
---|---|---|---|
Product: | Koha | Reporter: | Thibaud Guillot (thibaud_g) <thibaud.guillot> |
Component: | Command-line Utilities | Assignee: | Bugs List <koha-bugs> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | andrew, catrina, eric, george, kebliss, kelly, lucas, rcoert, robin, trevor.diamond |
Version: | Main | Keywords: | no-sandbox |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 24857: No words
Bug 31487: Add an option to send by mail longoverdue items to borrowers Bug 31487: Add an option to send by mail longoverdue items to borrowers Bug 31487: Add an option to send by mail longoverdue items to borrowers |
Description
Thibaud Guillot (thibaud_g)
2022-08-30 08:29:14 UTC
Created attachment 139975 [details] Bug 24857: No words Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Comment on attachment 139975 [details] Bug 24857: No words >From 31ab4940449cec56bdb164e34c140b2f80c4c36a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 9 Aug 2022 14:00:40 -0300 >Subject: [PATCH] Bug 24857: No words > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >https://bugs.koha-community.org/show_bug.cgi?id=31487 >--- > api/v1/swagger/swagger.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/api/v1/swagger/swagger.yaml b/api/v1/swagger/swagger.yaml >index b152a6f7df..597af62166 100644 >--- a/api/v1/swagger/swagger.yaml >+++ b/api/v1/swagger/swagger.yaml >@@ -584,7 +584,7 @@ tags: > - description: "Manage import batches\n" > name: import_batches > x-display-name: Import batches >- - description: "Manate item groups\n" >+ - description: "Manage item groups\n" > name: item_groups > x-displayName: Item groups > - description: "Manage items\n" >-- >2.25.1 Created attachment 139976 [details] [review] Bug 31487: Add an option to send by mail longoverdue items to borrowers Test plan: 1) You must have longoverdue items to one or many borrowers 2) You must create a notice template (Notices & slips section) 3) You can run the script misc/cronjobs/longoverdue.pl manually without --mail option first (see -h or --help for more info about the script) 4) You must see an output with some longoverdues (step 1 required) 5) Now you can run the script with --mail option but like its specify in "help" option you must add option --code="" (relative to your code template) and --branchcode="". 6) Normally you will see after the classic output a new block with emails added to the message queue and it will be sent on the next misc/cronjobs/process_message_queue.pl script iteration Created attachment 139977 [details] [review] Bug 31487: Add an option to send by mail longoverdue items to borrowers Test plan: 1) You must have longoverdue items to one or many borrowers 2) You must create a notice template (Notices & slips section) 3) You can run the script misc/cronjobs/longoverdue.pl manually without --mail option first (see -h or --help for more info about the script) 4) You must see an output with some longoverdues (step 1 required) 5) Now you can run the script with --mail option but like its specify in "help" option you must add option --code="" (relative to your code template) and --branchcode="". 6) Normally you will see after the classic output a new block with emails added to the message queue and it will be sent on the next misc/cronjobs/process_message_queue.pl script iteration (In reply to Thibaud Guillot from comment #1) > Created attachment 139975 [details] > Bug 24857: No words > > Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Sorry for this mistake I missed my attachment No longer applies to current master. This would be a beneficial feature for many of our library partners that are not open 7 days a week. Since they use useDaysMode to push back the due dates of items this makes timing the notice of items becoming long overdue very difficult. Created attachment 176318 [details] [review] Bug 31487: Add an option to send by mail longoverdue items to borrowers Test plan: 1) You must have longoverdue items to one or many borrowers 2) You must create a notice template (Notices & slips section) 3) You can run the script misc/cronjobs/longoverdue.pl manually without --mail option first (see -h or --help for more info about the script) 4) You must see an output with some longoverdues (step 1 required) 5) Now you can run the script with --mail option but like its specify in "help" option you must add option --code="" (relative to your code template) and --branchcode="". 6) Normally you will see after the classic output a new block with emails added to the message queue and it will be sent on the next misc/cronjobs/process_message_queue.pl script iteration Sponsored by: BibLibre This needs to use GetPreparedLetter. It also needs to include a default notice. GetPreparedLetter would allow this to determine which branch to use, rather than asking for a branch in the cron. Specifying a branchcode in the cron really will not work for a variety of consortial setups. We need this to use something more like the overdue cron's --frombranch flag, which tells koha to use either the issuing library or the owning library. The "--mail" flag seems superfluous if adding "--mail" means "--code" and "--branch" are then required. Does this currently have any ability to pull in variables, like the patron name? It does not seem to, and that seems like a minimum functionality requirement. Ultimately, this wants: - to be a patron messaging preference - to generate a Print notice when the patron lacks an email address - to allow SMS message transport stuff - to allow digests I think some of that would be accomplished by using GetPreparedLetter. The rest could be follow-ups. (In reply to Thibaud Guillot (thibaud_g) from comment #8) > Created attachment 176318 [details] [review] [review] > Bug 31487: Add an option to send by mail longoverdue items to borrowers > > Test plan: > 1) You must have longoverdue items to one or many borrowers > 2) You must create a notice template (Notices & slips section) > 3) You can run the script misc/cronjobs/longoverdue.pl manually without > --mail option first (see -h or --help for more info about the script) > 4) You must see an output with some longoverdues (step 1 required) > 5) Now you can run the script with --mail option but like its specify in > "help" option you must add option --code="" (relative to your code > template) and --branchcode="". > 6) Normally you will see after the classic output a new block with > emails added to the message queue and it will be sent on the next > misc/cronjobs/process_message_queue.pl script iteration > > Sponsored by: BibLibre *** Bug 27441 has been marked as a duplicate of this bug. *** (In reply to Eric Swenson from comment #7) > This would be a beneficial feature for many of our library partners that are > not open 7 days a week. Since they use useDaysMode to push back the due > dates of items this makes timing the notice of items becoming long overdue > very difficult. Seconding this comment! |