Bug 24857 - Add ability to group items for records
Summary: Add ability to group items for records
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low new feature (vote)
Assignee: Kyle M Hall
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 26275 26276 31460 33639 34234 34520 35124 35754 24860 26931 31133 31140 32353 32803 33640 33672
  Show dependency treegraph
 
Reported: 2020-03-12 13:38 UTC by Kyle M Hall
Modified: 2024-02-13 02:48 UTC (History)
17 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/609
Text to go in the release notes:
This feature was sponsored by Arlington Public Library. This feature allows for libraries to group items within a record. A new system preference has been added for this feature, EnableItemGroups. This system preference, once enabled, will allow the library to group specific items on a record to each other. A library can name the group and add items from the same record to this group. From the record, a new tab will appear and display on that item if it is part of a group.
Version(s) released in:
22.11.00


Attachments
Bug 24857: Update Database (8.21 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Schema files (7.21 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.83 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.18 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.15 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.61 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.64 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (14.47 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.61 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.39 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.55 KB, patch)
2020-03-12 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.21 KB, patch)
2020-03-24 16:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.34 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (2.19 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.83 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.18 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.15 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.61 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.64 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (14.47 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.61 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.39 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.55 KB, patch)
2020-03-24 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.24 KB, patch)
2020-03-24 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.34 KB, patch)
2020-03-24 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.83 KB, patch)
2020-03-24 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.50 KB, patch)
2020-03-24 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.15 KB, patch)
2020-03-24 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.61 KB, patch)
2020-03-24 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.64 KB, patch)
2020-03-24 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (14.50 KB, patch)
2020-03-24 19:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.62 KB, patch)
2020-03-24 19:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.42 KB, patch)
2020-03-24 19:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.23 KB, patch)
2020-03-24 19:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.67 KB, patch)
2020-03-24 19:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.24 KB, patch)
2020-03-25 11:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.34 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.83 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.50 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.15 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.61 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.64 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (14.33 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.62 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.42 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.23 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.67 KB, patch)
2020-03-25 11:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.24 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.34 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.83 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.50 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.15 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.61 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.64 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.89 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.62 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.40 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.23 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.67 KB, patch)
2020-03-25 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.17 KB, patch)
2020-03-25 18:29 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.40 KB, patch)
2020-03-25 18:29 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.91 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.55 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: API spec (24.20 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.67 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.70 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.95 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.68 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.47 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.28 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.72 KB, patch)
2020-03-25 18:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24857: Update Database (8.30 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.40 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.89 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.56 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.21 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.67 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.71 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.94 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.70 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.76 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.34 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.67 KB, patch)
2020-05-15 17:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.45 KB, patch)
2020-05-15 18:40 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (8.95 KB, patch)
2020-05-15 19:13 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.22 KB, patch)
2020-07-09 16:13 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.96 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.60 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: API spec (24.26 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.72 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.76 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.99 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.76 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.82 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.37 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.71 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.50 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.02 KB, patch)
2020-07-09 16:14 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24857: Update Database (8.36 KB, patch)
2020-08-18 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2020-08-18 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.62 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.26 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.76 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.99 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.71 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.88 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.39 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.72 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.52 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.01 KB, patch)
2020-08-18 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.36 KB, patch)
2020-08-19 17:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.61 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.26 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.76 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.99 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.71 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.88 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.39 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.72 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.52 KB, patch)
2020-08-19 17:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.01 KB, patch)
2020-08-19 17:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.00 KB, patch)
2020-08-19 17:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.55 KB, patch)
2020-08-19 17:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.52 KB, patch)
2020-08-19 17:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.35 KB, patch)
2020-08-19 17:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (688 bytes, patch)
2020-08-19 17:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.04 KB, patch)
2020-08-19 17:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.21 KB, patch)
2020-08-19 17:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.36 KB, patch)
2020-08-25 14:35 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.61 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.26 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.76 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.99 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.70 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.88 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.39 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.72 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.60 KB, patch)
2020-08-25 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.01 KB, patch)
2020-08-25 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.00 KB, patch)
2020-08-25 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.55 KB, patch)
2020-08-25 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.52 KB, patch)
2020-08-25 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.35 KB, patch)
2020-08-25 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (688 bytes, patch)
2020-08-25 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.04 KB, patch)
2020-08-25 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.21 KB, patch)
2020-08-25 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.50 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.61 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.26 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (11.76 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.99 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.70 KB, patch)
2020-09-09 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.91 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.39 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.60 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.01 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.00 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.55 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.52 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.35 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (688 bytes, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.04 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.21 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.61 KB, patch)
2020-09-09 13:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.08 KB, patch)
2020-09-11 10:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.50 KB, patch)
2020-09-11 10:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2020-09-11 10:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2020-09-11 10:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.61 KB, patch)
2020-09-11 10:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.26 KB, patch)
2020-09-11 10:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2020-09-11 10:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.12 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.99 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.70 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.91 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.35 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.60 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.01 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.00 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.55 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.52 KB, patch)
2020-09-11 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.35 KB, patch)
2020-09-11 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (688 bytes, patch)
2020-09-11 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.04 KB, patch)
2020-09-11 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.21 KB, patch)
2020-09-11 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.61 KB, patch)
2020-09-11 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.08 KB, patch)
2020-09-11 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.16 KB, patch)
2020-09-11 10:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.54 KB, patch)
2020-11-05 19:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.54 KB, patch)
2020-11-05 19:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.44 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.26 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.12 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (15.98 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.73 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.86 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.35 KB, patch)
2020-11-05 19:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.60 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.04 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.00 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.55 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.52 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.35 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (688 bytes, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.09 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.21 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.08 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.16 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.61 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete (4.44 KB, patch)
2020-11-05 19:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.54 KB, patch)
2020-11-05 20:08 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.44 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (24.26 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.12 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (16.00 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.73 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.86 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.35 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.60 KB, patch)
2020-11-05 20:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.04 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.00 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.55 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.52 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.35 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (688 bytes, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.09 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.21 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.08 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.16 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.61 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete (4.44 KB, patch)
2020-11-05 20:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.64 KB, patch)
2021-05-05 13:23 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.44 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (23.96 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.12 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (16.13 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.84 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.99 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.35 KB, patch)
2021-05-05 13:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.59 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.04 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.00 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.55 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.52 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.35 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (688 bytes, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.13 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.21 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.15 KB, patch)
2021-05-05 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.16 KB, patch)
2021-05-05 13:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete (4.44 KB, patch)
2021-05-05 13:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.63 KB, patch)
2021-05-05 13:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.64 KB, patch)
2021-07-13 16:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.46 KB, patch)
2021-07-13 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.95 KB, patch)
2021-07-13 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.44 KB, patch)
2021-07-13 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (23.96 KB, patch)
2021-07-13 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.73 KB, patch)
2021-07-13 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.12 KB, patch)
2021-07-13 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (16.13 KB, patch)
2021-07-13 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.84 KB, patch)
2021-07-13 16:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.96 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.35 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.50 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.04 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.00 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.55 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.52 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.35 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (688 bytes, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.13 KB, patch)
2021-07-13 16:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.21 KB, patch)
2021-07-13 16:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.17 KB, patch)
2021-07-13 16:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.16 KB, patch)
2021-07-13 16:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete (4.44 KB, patch)
2021-07-13 16:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.63 KB, patch)
2021-07-13 16:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Update Database (8.68 KB, patch)
2021-08-17 20:03 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.49 KB, patch)
2021-08-17 20:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.98 KB, patch)
2021-08-17 20:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.45 KB, patch)
2021-08-17 20:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: API spec (24.00 KB, patch)
2021-08-17 20:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.77 KB, patch)
2021-08-17 20:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.16 KB, patch)
2021-08-17 20:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (16.17 KB, patch)
2021-08-17 20:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.21 KB, patch)
2021-08-17 20:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.22 KB, patch)
2021-08-17 20:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.38 KB, patch)
2021-08-17 20:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.54 KB, patch)
2021-08-17 20:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.08 KB, patch)
2021-08-17 20:06 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.04 KB, patch)
2021-08-17 20:06 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.59 KB, patch)
2021-08-17 20:06 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.56 KB, patch)
2021-08-17 20:06 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.38 KB, patch)
2021-08-17 20:06 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (727 bytes, patch)
2021-08-17 20:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.17 KB, patch)
2021-08-17 20:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.25 KB, patch)
2021-08-17 20:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.21 KB, patch)
2021-08-17 20:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.20 KB, patch)
2021-08-17 20:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete (4.47 KB, patch)
2021-08-17 20:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.67 KB, patch)
2021-08-17 20:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix QA script issues (2.59 KB, patch)
2021-08-17 20:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (follow-up) Use $c->unhandled_exception (6.48 KB, patch)
2021-08-17 20:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Use $c->objects->find (1.22 KB, patch)
2021-08-17 20:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix permissions in spec (2.59 KB, patch)
2021-08-17 20:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio (3.65 KB, patch)
2021-08-17 20:09 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Further spec fixes (3.61 KB, patch)
2021-08-17 20:09 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Update Database (8.68 KB, patch)
2021-08-23 15:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.49 KB, patch)
2021-08-23 15:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.98 KB, patch)
2021-08-23 15:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.45 KB, patch)
2021-08-23 15:08 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: API spec (24.00 KB, patch)
2021-08-23 15:09 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.77 KB, patch)
2021-08-23 15:09 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.16 KB, patch)
2021-08-23 15:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (16.17 KB, patch)
2021-08-23 15:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.21 KB, patch)
2021-08-23 15:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.22 KB, patch)
2021-08-23 15:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.38 KB, patch)
2021-08-23 15:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.54 KB, patch)
2021-08-23 15:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.08 KB, patch)
2021-08-23 15:12 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.04 KB, patch)
2021-08-23 15:12 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.59 KB, patch)
2021-08-23 15:12 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.56 KB, patch)
2021-08-23 15:13 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.38 KB, patch)
2021-08-23 15:13 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (727 bytes, patch)
2021-08-23 15:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.17 KB, patch)
2021-08-23 15:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.25 KB, patch)
2021-08-23 15:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.21 KB, patch)
2021-08-23 15:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.20 KB, patch)
2021-08-23 15:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete (4.47 KB, patch)
2021-08-23 15:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Update existing Schema files [DO NOT PUSH] (4.67 KB, patch)
2021-08-23 15:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix QA script issues (2.59 KB, patch)
2021-08-23 15:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (follow-up) Use $c->unhandled_exception (6.48 KB, patch)
2021-08-23 15:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Use $c->objects->find (1.22 KB, patch)
2021-08-23 15:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix permissions in spec (2.59 KB, patch)
2021-08-23 15:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio (3.65 KB, patch)
2021-08-23 15:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Further spec fixes (3.61 KB, patch)
2021-08-23 15:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Rename Volumes => Item groups (DB) (22.96 KB, patch)
2021-08-23 15:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Adapt code to the volumes => item_groups change (113.53 KB, patch)
2021-08-23 15:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: item_group_items.item_id must be unique (5.04 KB, patch)
2021-08-23 15:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Update Database (8.68 KB, patch)
2021-09-01 13:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.49 KB, patch)
2021-09-01 13:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (5.98 KB, patch)
2021-09-01 13:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.48 KB, patch)
2021-09-01 13:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: API spec (24.00 KB, patch)
2021-09-01 13:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.77 KB, patch)
2021-09-01 13:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.16 KB, patch)
2021-09-01 13:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (16.17 KB, patch)
2021-09-01 13:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.21 KB, patch)
2021-09-01 13:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.22 KB, patch)
2021-09-01 13:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.38 KB, patch)
2021-09-01 13:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.54 KB, patch)
2021-09-01 13:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.08 KB, patch)
2021-09-01 13:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.04 KB, patch)
2021-09-01 13:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.59 KB, patch)
2021-09-01 13:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.56 KB, patch)
2021-09-01 13:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.38 KB, patch)
2021-09-01 13:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (727 bytes, patch)
2021-09-01 13:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.17 KB, patch)
2021-09-01 13:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.25 KB, patch)
2021-09-01 13:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.21 KB, patch)
2021-09-01 13:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.20 KB, patch)
2021-09-01 13:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete (4.47 KB, patch)
2021-09-01 13:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix QA script issues (2.59 KB, patch)
2021-09-01 13:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (follow-up) Use $c->unhandled_exception (6.48 KB, patch)
2021-09-01 13:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Use $c->objects->find (1.22 KB, patch)
2021-09-01 13:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix permissions in spec (2.59 KB, patch)
2021-09-01 13:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio (3.65 KB, patch)
2021-09-01 13:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Further spec fixes (3.61 KB, patch)
2021-09-01 13:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Rename Volumes => Item groups (DB) (25.02 KB, patch)
2021-09-01 13:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Adapt code to the volumes => item_groups change (114.55 KB, patch)
2021-09-01 13:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: item_group_items.item_id must be unique (5.60 KB, patch)
2021-09-01 13:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix for missing Scalar context (2.03 KB, patch)
2021-09-02 09:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Do not depend on bug 28883 (1.52 KB, patch)
2021-09-03 13:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Update Database (8.74 KB, patch)
2021-09-07 14:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (5.56 KB, patch)
2021-09-07 14:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Add Koha Object(s) (6.05 KB, patch)
2021-09-07 14:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (2.54 KB, patch)
2021-09-07 14:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: API spec (24.07 KB, patch)
2021-09-07 14:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Koha::Biblio::Volume methods (2.83 KB, patch)
2021-09-07 14:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Implement volume related controllers (12.22 KB, patch)
2021-09-07 14:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Add volume management to detail.pl (16.23 KB, patch)
2021-09-07 14:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Add ability to attach newly cataloged items to a volume (7.27 KB, patch)
2021-09-07 14:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Add ability to manage item's volumes from detail.pl (11.28 KB, patch)
2021-09-07 14:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Delete a volume when the last item on that volume is deleted (1.45 KB, patch)
2021-09-07 14:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Copy the volume to the item's enumchron (8.61 KB, patch)
2021-09-07 14:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Add user permission for volumes management (9.15 KB, patch)
2021-09-07 14:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Fix license statements (10.10 KB, patch)
2021-09-07 14:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Fix POD (2.65 KB, patch)
2021-09-07 14:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Add missing filter and move js to footer on additem.tt (1.62 KB, patch)
2021-09-07 14:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Fix simple-quote string (1.45 KB, patch)
2021-09-07 14:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' (792 bytes, patch)
2021-09-07 14:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Fix sorting of new syspref (2.24 KB, patch)
2021-09-07 14:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Change button text from "Create new" to "New volume" (1.32 KB, patch)
2021-09-07 14:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add volume to table settings (3.27 KB, patch)
2021-09-07 14:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Unit tests (15.26 KB, patch)
2021-09-07 14:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete (4.54 KB, patch)
2021-09-07 14:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Fix QA script issues (2.66 KB, patch)
2021-09-07 14:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: (follow-up) Use $c->unhandled_exception (6.55 KB, patch)
2021-09-07 14:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Use $c->objects->find (1.28 KB, patch)
2021-09-07 14:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Fix permissions in spec (2.65 KB, patch)
2021-09-07 14:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio (3.71 KB, patch)
2021-09-07 14:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Further spec fixes (3.68 KB, patch)
2021-09-07 14:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Rename Volumes => Item groups (DB) (25.08 KB, patch)
2021-09-07 14:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Adapt code to the volumes => item_groups change (114.62 KB, patch)
2021-09-07 14:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: item_group_items.item_id must be unique (5.67 KB, patch)
2021-09-07 14:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Do not depend on bug 28883 (1.58 KB, patch)
2021-09-07 14:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24857: Database updates (10.07 KB, patch)
2022-03-08 12:41 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add Koha Objects (9.93 KB, patch)
2022-03-08 12:41 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: DO NOT PUSH: Schema changes (8.25 KB, patch)
2022-03-08 12:41 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: API spec (35.27 KB, patch)
2022-03-08 12:41 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (5.22 KB, patch)
2022-03-08 12:42 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add item group management to detail.pl (34.40 KB, patch)
2022-03-08 12:42 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add ability to set item group when adding a new item (8.25 KB, patch)
2022-03-08 12:42 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Delete item group when last item is deleted (2.38 KB, patch)
2022-03-08 12:42 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Database updates (10.07 KB, patch)
2022-04-28 18:27 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add Koha Objects (9.93 KB, patch)
2022-04-28 18:27 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: API spec (35.29 KB, patch)
2022-04-28 18:27 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (5.20 KB, patch)
2022-04-28 18:27 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add item group management to detail.pl (35.04 KB, patch)
2022-04-28 18:27 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add ability to set item group when adding a new item (8.25 KB, patch)
2022-04-28 18:28 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Delete item group when last item is deleted (2.38 KB, patch)
2022-04-28 18:28 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: DO NOT PUSH: Schema changes (8.20 KB, patch)
2022-04-28 18:28 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Add object classes to Schema (1.59 KB, patch)
2022-04-28 18:28 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24857: Database updates (10.07 KB, patch)
2022-06-02 16:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Database updates (10.07 KB, patch)
2022-06-02 16:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Objects (9.93 KB, patch)
2022-06-02 16:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (35.29 KB, patch)
2022-06-02 16:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (5.72 KB, patch)
2022-06-02 16:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add item group management to detail.pl (35.04 KB, patch)
2022-06-02 16:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to set item group when adding a new item (8.25 KB, patch)
2022-06-02 16:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete item group when last item is deleted (2.38 KB, patch)
2022-06-02 16:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (6.09 KB, patch)
2022-06-02 16:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add object classes to Schema (1.59 KB, patch)
2022-06-02 16:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: DO NOT PUSH: Schema changes (2.37 KB, patch)
2022-06-02 16:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Database updates (10.12 KB, patch)
2022-06-02 16:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Objects (9.93 KB, patch)
2022-06-02 16:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (35.29 KB, patch)
2022-06-02 16:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (5.72 KB, patch)
2022-06-02 16:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add item group management to detail.pl (35.04 KB, patch)
2022-06-02 16:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to set item group when adding a new item (8.32 KB, patch)
2022-06-02 16:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete item group when last item is deleted (2.38 KB, patch)
2022-06-02 16:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (6.09 KB, patch)
2022-06-02 16:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add object classes to Schema (1.59 KB, patch)
2022-06-02 16:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: DO NOT PUSH: Schema changes (2.37 KB, patch)
2022-06-02 16:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Database updates (10.12 KB, patch)
2022-06-02 18:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Objects (9.93 KB, patch)
2022-06-02 18:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (35.29 KB, patch)
2022-06-02 18:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (5.72 KB, patch)
2022-06-02 18:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add item group management to detail.pl (34.87 KB, patch)
2022-06-02 18:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to set item group when adding a new item (8.32 KB, patch)
2022-06-02 18:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete item group when last item is deleted (2.38 KB, patch)
2022-06-02 18:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (6.09 KB, patch)
2022-06-02 18:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add object classes to Schema (1.59 KB, patch)
2022-06-02 18:23 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: DO NOT PUSH: Schema changes (2.37 KB, patch)
2022-06-02 18:23 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add item group management to detail.pl (35.02 KB, patch)
2022-06-02 18:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to set item group when adding a new item (8.32 KB, patch)
2022-06-02 18:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete item group when last item is deleted (2.38 KB, patch)
2022-06-02 18:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (6.09 KB, patch)
2022-06-02 18:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add object classes to Schema (1.59 KB, patch)
2022-06-02 18:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: DO NOT PUSH: Schema changes (2.37 KB, patch)
2022-06-02 18:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Database updates (10.13 KB, patch)
2022-07-07 11:04 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Objects (9.94 KB, patch)
2022-07-07 11:04 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (35.30 KB, patch)
2022-07-07 11:04 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (5.58 KB, patch)
2022-07-07 11:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add item group management to detail.pl (36.84 KB, patch)
2022-07-07 11:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to set item group when adding a new item (8.32 KB, patch)
2022-07-07 11:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete item group when last item is deleted (2.39 KB, patch)
2022-07-07 11:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (6.09 KB, patch)
2022-07-07 11:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add object classes to Schema (1.59 KB, patch)
2022-07-07 11:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: DO NOT PUSH: Schema changes (2.37 KB, patch)
2022-07-07 11:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Fix rebase problems (1.35 KB, patch)
2022-07-07 14:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Database updates (10.13 KB, patch)
2022-07-07 14:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Koha Objects (9.94 KB, patch)
2022-07-07 14:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: API spec (35.30 KB, patch)
2022-07-07 14:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add Object Methods (5.73 KB, patch)
2022-07-07 14:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add item group management to detail.pl (34.97 KB, patch)
2022-07-07 14:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add ability to set item group when adding a new item (8.32 KB, patch)
2022-07-07 14:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Delete item group when last item is deleted (2.39 KB, patch)
2022-07-07 14:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add new Schema files (6.09 KB, patch)
2022-07-07 14:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: Add object classes to Schema (1.59 KB, patch)
2022-07-07 14:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: DO NOT PUSH: Schema changes (2.37 KB, patch)
2022-07-07 14:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Make update idempotent (1.04 KB, patch)
2022-07-08 22:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Fix missing additionalProperties in spec (1.26 KB, patch)
2022-07-08 22:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Remove incorrect object_class method (686 bytes, patch)
2022-07-08 23:29 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 24857: Remove object_class from singular classes (1.31 KB, patch)
2022-07-12 07:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 24857: (QA follow-up) Add spec description (840 bytes, patch)
2022-08-09 16:57 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2020-03-12 13:38:07 UTC
We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record.

This but is to add just the volume management itself, which no functionality tied to volumes.
Comment 1 Kyle M Hall 2020-03-12 16:09:04 UTC
Created attachment 100652 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items
Comment 2 Kyle M Hall 2020-03-12 16:09:15 UTC
Created attachment 100653 [details] [review]
Bug 24857: Add Schema files
Comment 3 Kyle M Hall 2020-03-12 16:09:18 UTC
Created attachment 100654 [details] [review]
Bug 24857: Add Koha Object(s)
Comment 4 Kyle M Hall 2020-03-12 16:09:20 UTC
Created attachment 100655 [details] [review]
Bug 24857: Add Object Methods
Comment 5 Kyle M Hall 2020-03-12 16:09:23 UTC
Created attachment 100656 [details] [review]
Bug 24857: API spec
Comment 6 Kyle M Hall 2020-03-12 16:09:25 UTC
Created attachment 100657 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)
Comment 7 Kyle M Hall 2020-03-12 16:09:28 UTC
Created attachment 100658 [details] [review]
Bug 24857: Implement volume related controllers
Comment 8 Kyle M Hall 2020-03-12 16:09:30 UTC
Created attachment 100659 [details] [review]
Bug 24857: Add volume management to detail.pl
Comment 9 Kyle M Hall 2020-03-12 16:09:33 UTC
Created attachment 100660 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume
Comment 10 Kyle M Hall 2020-03-12 16:09:36 UTC
Created attachment 100661 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl
Comment 11 Kyle M Hall 2020-03-12 16:09:39 UTC
Created attachment 100662 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted
Comment 12 Kyle M Hall 2020-03-24 16:57:54 UTC
Created attachment 101637 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items
Comment 13 Kyle M Hall 2020-03-24 16:58:06 UTC
Created attachment 101638 [details] [review]
Bug 24857: Add new Schema files
Comment 14 Kyle M Hall 2020-03-24 16:58:09 UTC
Created attachment 101639 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 15 Kyle M Hall 2020-03-24 16:58:13 UTC
Created attachment 101640 [details] [review]
Bug 24857: Add Koha Object(s)
Comment 16 Kyle M Hall 2020-03-24 16:58:17 UTC
Created attachment 101641 [details] [review]
Bug 24857: Add Object Methods
Comment 17 Kyle M Hall 2020-03-24 16:58:21 UTC
Created attachment 101642 [details] [review]
Bug 24857: API spec
Comment 18 Kyle M Hall 2020-03-24 16:58:24 UTC
Created attachment 101643 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)
Comment 19 Kyle M Hall 2020-03-24 16:58:28 UTC
Created attachment 101644 [details] [review]
Bug 24857: Implement volume related controllers
Comment 20 Kyle M Hall 2020-03-24 16:58:33 UTC
Created attachment 101645 [details] [review]
Bug 24857: Add volume management to detail.pl
Comment 21 Kyle M Hall 2020-03-24 16:58:37 UTC
Created attachment 101646 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume
Comment 22 Kyle M Hall 2020-03-24 16:58:41 UTC
Created attachment 101647 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl
Comment 23 Kyle M Hall 2020-03-24 16:58:44 UTC
Created attachment 101648 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted
Comment 24 Kyle M Hall 2020-03-24 19:01:26 UTC
Created attachment 101650 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items
Comment 25 Kyle M Hall 2020-03-24 19:01:36 UTC
Created attachment 101651 [details] [review]
Bug 24857: Add new Schema files
Comment 26 Kyle M Hall 2020-03-24 19:01:40 UTC
Created attachment 101652 [details] [review]
Bug 24857: Add Koha Object(s)
Comment 27 Kyle M Hall 2020-03-24 19:01:43 UTC
Created attachment 101653 [details] [review]
Bug 24857: Add Object Methods
Comment 28 Kyle M Hall 2020-03-24 19:01:47 UTC
Created attachment 101654 [details] [review]
Bug 24857: API spec
Comment 29 Kyle M Hall 2020-03-24 19:01:50 UTC
Created attachment 101655 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)
Comment 30 Kyle M Hall 2020-03-24 19:01:54 UTC
Created attachment 101656 [details] [review]
Bug 24857: Implement volume related controllers
Comment 31 Kyle M Hall 2020-03-24 19:01:57 UTC
Created attachment 101657 [details] [review]
Bug 24857: Add volume management to detail.pl
Comment 32 Kyle M Hall 2020-03-24 19:02:00 UTC
Created attachment 101658 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume
Comment 33 Kyle M Hall 2020-03-24 19:02:03 UTC
Created attachment 101659 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl
Comment 34 Kyle M Hall 2020-03-24 19:02:06 UTC
Created attachment 101660 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted
Comment 35 Kyle M Hall 2020-03-24 19:02:10 UTC
Created attachment 101661 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 36 Kyle M Hall 2020-03-25 11:01:58 UTC
Created attachment 101670 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items
Comment 37 Kyle M Hall 2020-03-25 11:02:08 UTC
Created attachment 101671 [details] [review]
Bug 24857: Add new Schema files
Comment 38 Kyle M Hall 2020-03-25 11:02:11 UTC
Created attachment 101672 [details] [review]
Bug 24857: Add Koha Object(s)
Comment 39 Kyle M Hall 2020-03-25 11:02:15 UTC
Created attachment 101673 [details] [review]
Bug 24857: Add Object Methods
Comment 40 Kyle M Hall 2020-03-25 11:02:18 UTC
Created attachment 101674 [details] [review]
Bug 24857: API spec
Comment 41 Kyle M Hall 2020-03-25 11:02:21 UTC
Created attachment 101675 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)
Comment 42 Kyle M Hall 2020-03-25 11:02:25 UTC
Created attachment 101676 [details] [review]
Bug 24857: Implement volume related controllers
Comment 43 Kyle M Hall 2020-03-25 11:02:28 UTC
Created attachment 101677 [details] [review]
Bug 24857: Add volume management to detail.pl
Comment 44 Kyle M Hall 2020-03-25 11:02:31 UTC
Created attachment 101678 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume
Comment 45 Kyle M Hall 2020-03-25 11:02:34 UTC
Created attachment 101679 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl
Comment 46 Kyle M Hall 2020-03-25 11:02:37 UTC
Created attachment 101680 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted
Comment 47 Kyle M Hall 2020-03-25 11:02:40 UTC
Created attachment 101681 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 48 Andrew Fuerste-Henry 2020-03-25 13:21:03 UTC
Getting an ISE because volume info is not cleared from items when volume is deleted

-add items to volume
-delete volume
-see that items still show as in deleted volume
-select items, see you still have volume-related links even though there are no volumes
-click "add/modify volume" and receive ISE
Comment 49 Kyle M Hall 2020-03-25 16:50:03 UTC
Created attachment 101730 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items
Comment 50 Kyle M Hall 2020-03-25 16:50:15 UTC
Created attachment 101731 [details] [review]
Bug 24857: Add new Schema files
Comment 51 Kyle M Hall 2020-03-25 16:50:19 UTC
Created attachment 101732 [details] [review]
Bug 24857: Add Koha Object(s)
Comment 52 Kyle M Hall 2020-03-25 16:50:22 UTC
Created attachment 101733 [details] [review]
Bug 24857: Add Object Methods
Comment 53 Kyle M Hall 2020-03-25 16:50:26 UTC
Created attachment 101734 [details] [review]
Bug 24857: API spec
Comment 54 Kyle M Hall 2020-03-25 16:50:30 UTC
Created attachment 101735 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)
Comment 55 Kyle M Hall 2020-03-25 16:50:33 UTC
Created attachment 101736 [details] [review]
Bug 24857: Implement volume related controllers
Comment 56 Kyle M Hall 2020-03-25 16:50:37 UTC
Created attachment 101737 [details] [review]
Bug 24857: Add volume management to detail.pl
Comment 57 Kyle M Hall 2020-03-25 16:50:41 UTC
Created attachment 101738 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume
Comment 58 Kyle M Hall 2020-03-25 16:50:44 UTC
Created attachment 101739 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl
Comment 59 Kyle M Hall 2020-03-25 16:50:47 UTC
Created attachment 101740 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted
Comment 60 Kyle M Hall 2020-03-25 16:50:51 UTC
Created attachment 101741 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 61 Andrew Fuerste-Henry 2020-03-25 18:29:53 UTC
Created attachment 101752 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 62 Andrew Fuerste-Henry 2020-03-25 18:29:56 UTC
Created attachment 101753 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 63 Andrew Fuerste-Henry 2020-03-25 18:30:00 UTC
Created attachment 101754 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 64 Andrew Fuerste-Henry 2020-03-25 18:30:03 UTC
Created attachment 101755 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 65 Andrew Fuerste-Henry 2020-03-25 18:30:07 UTC
Created attachment 101756 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 66 Andrew Fuerste-Henry 2020-03-25 18:30:10 UTC
Created attachment 101757 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 67 Andrew Fuerste-Henry 2020-03-25 18:30:13 UTC
Created attachment 101758 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 68 Andrew Fuerste-Henry 2020-03-25 18:30:17 UTC
Created attachment 101759 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 69 Andrew Fuerste-Henry 2020-03-25 18:30:20 UTC
Created attachment 101760 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 70 Andrew Fuerste-Henry 2020-03-25 18:30:24 UTC
Created attachment 101761 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 71 Andrew Fuerste-Henry 2020-03-25 18:30:27 UTC
Created attachment 101762 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 72 Andrew Fuerste-Henry 2020-03-25 18:30:30 UTC
Created attachment 101763 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 73 David Cook 2020-03-26 00:22:06 UTC
This sounds odd. What's a volume mean in this context?
Comment 74 Andrew Fuerste-Henry 2020-03-26 12:27:59 UTC
A volume is a grouping of items within a bib. See bug 24860 for one implementation (patrons can place hold on a volume, get first available item within that volume). Imagine, say, a bib containing multiple copies of a multi-volume series. Patron wants whichever copy of Book 1 comes in first.
Comment 75 Laura Horgan 2020-03-26 17:42:42 UTC
When will this be added to the system and will ther be a way to identify and possibly migrate or create volumes for items in the system cuurently
Comment 76 Katrin Fischer 2020-03-26 21:01:32 UTC
Could this also be used in context of bound serials (all issues of a year bound into one volume)?
Comment 77 Andrew Fuerste-Henry 2020-03-26 21:09:55 UTC
Laura - It's hard to say when this will be in Koha, as it has not yet gone through QA. This patch doesn't include a mechanism to automatically assign items to volumes, but existing items can be added to volumes manually.

Katrin - Yes, absolutely! I can see ways in which defining volumes of periodicals would be useful. Though the only functionality beyond the creation of a volume that's currently being worked on is that in bug 24860.
Comment 78 David Cook 2020-03-26 22:11:58 UTC
(In reply to Andrew Fuerste-Henry from comment #74)
> A volume is a grouping of items within a bib. See bug 24860 for one
> implementation (patrons can place hold on a volume, get first available item
> within that volume). Imagine, say, a bib containing multiple copies of a
> multi-volume series. Patron wants whichever copy of Book 1 comes in first.

That's interesting. I wonder if we should use more generic terminology like "item_group" instead of "volume". Perhaps each group could have a translatable label assigned so you could choose "Volume", "Kit", etc. 

This might be useful for libraries that provide kits, toy bags, computers (with peripherals). Individual pieces could be barcoded and be items in their own right, but be grouped together.
Comment 79 Laura Horgan 2020-03-26 23:12:41 UTC
In our last system it was called parts and was used for books dvds kits, etc
Comment 80 Andrew Fuerste-Henry 2020-03-27 16:00:33 UTC
Y'all might have a look at bug 24023, which adds a way to group items to check out all together.
Comment 81 Kyle M Hall 2020-05-15 17:49:03 UTC
Created attachment 104952 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 82 Kyle M Hall 2020-05-15 17:49:15 UTC
Created attachment 104953 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 83 Kyle M Hall 2020-05-15 17:49:19 UTC
Created attachment 104954 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 84 Kyle M Hall 2020-05-15 17:49:23 UTC
Created attachment 104955 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 85 Kyle M Hall 2020-05-15 17:49:27 UTC
Created attachment 104956 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 86 Kyle M Hall 2020-05-15 17:49:31 UTC
Created attachment 104957 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 87 Kyle M Hall 2020-05-15 17:49:35 UTC
Created attachment 104958 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 88 Kyle M Hall 2020-05-15 17:49:39 UTC
Created attachment 104959 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 89 Kyle M Hall 2020-05-15 17:49:43 UTC
Created attachment 104960 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 90 Kyle M Hall 2020-05-15 17:49:48 UTC
Created attachment 104961 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 91 Kyle M Hall 2020-05-15 17:49:52 UTC
Created attachment 104962 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 92 Kyle M Hall 2020-05-15 17:49:56 UTC
Created attachment 104963 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 93 Laura Horgan 2020-05-15 17:57:34 UTC
I see this was signed off... What version of Koha will it be available?  Not sure if there is somewhere I need to look to see this information... If so please let me know so I won't have to ask this question again.  Thanks in advance
Comment 94 Kyle M Hall 2020-05-15 18:40:32 UTC
Created attachment 104964 [details] [review]
Bug 24857: Copy the volume to the item's enumchron
Comment 95 Kyle M Hall 2020-05-15 19:13:51 UTC
Created attachment 104966 [details] [review]
Bug 24857: Add user permission for volumes management
Comment 96 Katrin Fischer 2020-05-16 10:37:09 UTC
(In reply to Laura Horgan from comment #93)
> I see this was signed off... What version of Koha will it be available?  Not
> sure if there is somewhere I need to look to see this information... If so
> please let me know so I won't have to ask this question again.  Thanks in
> advance

Hi Laura, after sign off this still needs to go through QA. For 20.05 it's too late, as we have already entered 'feature freeze' (focusing on bug fixing and stabilizing) and 'string freeze' (no GUI changes for translations to catch up) for this release. The next one this could be released with is 22.11. Koha doesn't do road maps, but for every version we include what it's ready on time. So the bug and the status is the best way to see what's going on.
Comment 97 ByWater Sandboxes 2020-07-09 16:13:57 UTC
Created attachment 106728 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 98 ByWater Sandboxes 2020-07-09 16:14:00 UTC
Created attachment 106729 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 99 ByWater Sandboxes 2020-07-09 16:14:04 UTC
Created attachment 106730 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 100 ByWater Sandboxes 2020-07-09 16:14:07 UTC
Created attachment 106731 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 101 ByWater Sandboxes 2020-07-09 16:14:10 UTC
Created attachment 106732 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 102 ByWater Sandboxes 2020-07-09 16:14:13 UTC
Created attachment 106733 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 103 ByWater Sandboxes 2020-07-09 16:14:16 UTC
Created attachment 106734 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 104 ByWater Sandboxes 2020-07-09 16:14:19 UTC
Created attachment 106735 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 105 ByWater Sandboxes 2020-07-09 16:14:22 UTC
Created attachment 106736 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 106 ByWater Sandboxes 2020-07-09 16:14:25 UTC
Created attachment 106737 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 107 ByWater Sandboxes 2020-07-09 16:14:28 UTC
Created attachment 106738 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 108 ByWater Sandboxes 2020-07-09 16:14:32 UTC
Created attachment 106739 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 109 ByWater Sandboxes 2020-07-09 16:14:35 UTC
Created attachment 106740 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 110 ByWater Sandboxes 2020-07-09 16:14:38 UTC
Created attachment 106741 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 111 Katrin Fischer 2020-08-16 21:56:12 UTC
Patches don't apply cleanly right now, can you please rebase? 

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 24857: Update Database
Applying: Bug 24857: Add new Schema files
Applying: Bug 24857: Add Koha Object(s)
Applying: Bug 24857: Add Object Methods
Applying: Bug 24857: API spec
Applying: Bug 24857: Koha::Biblio::Volume methods
Applying: Bug 24857: Implement volume related controllers
Applying: Bug 24857: Add volume management to detail.pl
Applying: Bug 24857: Add ability to attach newly cataloged items to a volume
Applying: Bug 24857: Add ability to manage item's volumes from detail.pl
.git/rebase-apply/patch:121: trailing whitespace.
if($query->cookie("holdfor")){ 
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 24857: Add ability to manage item's volumes from detail.pl
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-24857-Add-ability-to-manage-items-volumes-from-GJYBG0.patch
Comment 112 Kyle M Hall 2020-08-18 10:55:44 UTC
Created attachment 108443 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 113 Kyle M Hall 2020-08-18 10:55:58 UTC
Created attachment 108444 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 114 Kyle M Hall 2020-08-18 10:56:02 UTC
Created attachment 108445 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 115 Kyle M Hall 2020-08-18 10:56:07 UTC
Created attachment 108446 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 116 Kyle M Hall 2020-08-18 10:56:12 UTC
Created attachment 108447 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 117 Kyle M Hall 2020-08-18 10:56:16 UTC
Created attachment 108448 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 118 Kyle M Hall 2020-08-18 10:56:22 UTC
Created attachment 108449 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 119 Kyle M Hall 2020-08-18 10:56:26 UTC
Created attachment 108450 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 120 Kyle M Hall 2020-08-18 10:56:30 UTC
Created attachment 108451 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 121 Kyle M Hall 2020-08-18 10:56:35 UTC
Created attachment 108452 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 122 Kyle M Hall 2020-08-18 10:56:40 UTC
Created attachment 108453 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 123 Kyle M Hall 2020-08-18 10:56:44 UTC
Created attachment 108454 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 124 Kyle M Hall 2020-08-18 10:56:49 UTC
Created attachment 108455 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 125 Kyle M Hall 2020-08-18 10:56:53 UTC
Created attachment 108456 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 126 Katrin Fischer 2020-08-18 23:25:20 UTC
This one is a little scary already, but going in for a first review :)

1) QA script

Several issues found, please fix:

 FAIL	Koha/Biblio/Volume.pm
   FAIL	  forbidden patterns
		forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16)

 FAIL	Koha/Biblio/Volume/Item.pm
   FAIL	  forbidden patterns
		forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16)
   FAIL	  pod
		*** WARNING: 
		empty section in previous paragraph
		 
		 in file Koha/Biblio/Volume/Item.pm

 FAIL	Koha/Biblio/Volume/Items.pm
   FAIL	  forbidden patterns
		forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16)
   FAIL	  pod
		*** WARNING: 
		empty section in previous paragraph
		 
		 in file Koha/Biblio/Volume/Items.pm

 FAIL	Koha/Biblio/Volumes.pm
   FAIL	  forbidden patterns
		forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16)
   FAIL	  pod
		*** WARNING: 
		empty section in previous paragraph
		 
		 in file Koha/Biblio/Volumes.pm

 FAIL	Koha/REST/V1/Biblios/Volumes.pm
   FAIL	  forbidden patterns
		forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16)

 FAIL	Koha/REST/V1/Biblios/Volumes/Items.pm
   FAIL	  forbidden patterns
		forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16)

 FAIL	Koha/Schema/Result/Volume.pm
   FAIL	  pod coverage
		POD is missing for koha_object_class
		POD is missing for koha_objects_class

 FAIL	Koha/Schema/Result/VolumeItem.pm
   FAIL	  pod coverage
		POD is missing for koha_object_class
		POD is missing for koha_objects_class

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
   FAIL	  forbidden patterns
		forbidden pattern: simple-quote string (line 1446)


 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
   FAIL	  filters
		missing_filter at line 20 (  var has_volumes = [% volumes.count %];)
   FAIL	  js_in_body


2) Doubled up use statement in Biblio.pm

+use Koha::Biblio::Volumes;
+use Koha::Biblio::Volumes;

3) REST API

I'd love to have Tomas take a look on the REST API bits here. 

4) sysprefs.sql

After all the use statements were so nicely alphabetically resorted, THIS?

+('EnableVolumes','0','','Enable volumes feature','YesNo'),
 ('viewISBD','1','','Allow display of ISBD view of bibiographic records','YesNo'),

;)

5) Pref (question)

Enable|Don't enable
volumes feature to allow collecting groups of items on a record into volumes.

Does it mean the items have to be from the same record or could they be from different ones?

6) Table configuration

The new volumn column on the holdings table needs to be added to the table configuration options.

7) GUI

"Create new" on the items table would work nicer as "Create new volume" or "New volume" to give context to translators and for better accessibility.

Future improvements:
It might be nice to offer a kind of grouped view for the items in volumes... but I am not sure yet how this would work best. 
It might be nice to show the volumes in the OPAC as well.

8) Use case and future plans?

Can you tell a bit about in what context or use case this partner is using this? Serials?
Comment 127 Katrin Fischer 2020-08-18 23:31:01 UTC
Hm, I've checked the test plan on the dependent bug now too and am still a little confused about the use case for this.

Reading "volume" made me think of something that would be used for serial issues bound together into one volume (serials, binding) But this doesn't seem to be the case with how the volume hold feature works.

Does this more work like a "Hold group" maybe? One item out of the group appears to satisfy the hold - so maybe "Group" would be a better word to describe the idea?
Comment 128 Kyle M Hall 2020-08-19 17:34:59 UTC
Created attachment 108666 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 129 Kyle M Hall 2020-08-19 17:35:12 UTC
Created attachment 108667 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 130 Kyle M Hall 2020-08-19 17:35:17 UTC
Created attachment 108668 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 131 Kyle M Hall 2020-08-19 17:35:21 UTC
Created attachment 108669 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 132 Kyle M Hall 2020-08-19 17:35:25 UTC
Created attachment 108670 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 133 Kyle M Hall 2020-08-19 17:35:29 UTC
Created attachment 108671 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 134 Kyle M Hall 2020-08-19 17:35:34 UTC
Created attachment 108672 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 135 Kyle M Hall 2020-08-19 17:35:38 UTC
Created attachment 108673 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 136 Kyle M Hall 2020-08-19 17:35:42 UTC
Created attachment 108674 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 137 Kyle M Hall 2020-08-19 17:35:47 UTC
Created attachment 108675 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 138 Kyle M Hall 2020-08-19 17:35:51 UTC
Created attachment 108676 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 139 Kyle M Hall 2020-08-19 17:35:55 UTC
Created attachment 108677 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 140 Kyle M Hall 2020-08-19 17:35:59 UTC
Created attachment 108678 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 141 Kyle M Hall 2020-08-19 17:36:03 UTC
Created attachment 108679 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 142 Kyle M Hall 2020-08-19 17:36:07 UTC
Created attachment 108680 [details] [review]
Bug 24857: Fix license statements
Comment 143 Kyle M Hall 2020-08-19 17:36:11 UTC
Created attachment 108681 [details] [review]
Bug 24857: Fix POD
Comment 144 Kyle M Hall 2020-08-19 17:36:16 UTC
Created attachment 108682 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt
Comment 145 Kyle M Hall 2020-08-19 17:36:21 UTC
Created attachment 108683 [details] [review]
Bug 24857: Fix simple-quote string
Comment 146 Kyle M Hall 2020-08-19 17:36:25 UTC
Created attachment 108684 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'
Comment 147 Kyle M Hall 2020-08-19 17:36:29 UTC
Created attachment 108685 [details] [review]
Bug 24857: Fix sorting of new syspref
Comment 148 Kyle M Hall 2020-08-19 17:36:34 UTC
Created attachment 108686 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"
Comment 149 Kyle M Hall 2020-08-19 17:43:44 UTC
(In reply to Katrin Fischer from comment #126)
> This one is a little scary already, but going in for a first review :)
> 
> 1) QA script
Fixed!

> 2) Doubled up use statement in Biblio.pm
 
Fixed!
 
> 3) REST API
> 
> I'd love to have Tomas take a look on the REST API bits here. 

I'll ask Tomas to take a look!

> 
> 4) sysprefs.sql

Fixed!

> 
> 5) Pref (question)
> 
> Enable|Don't enable
> volumes feature to allow collecting groups of items on a record into volumes.
> 
> Does it mean the items have to be from the same record or could they be from
> different ones?

We decided early on that volumes would have contain only items within the same record.

> 6) Table configuration
> 
> The new volumn column on the holdings table needs to be added to the table
> configuration options.

This table is not a datatable so that doesn't really apply.

> 7) GUI
> 
> "Create new" on the items table would work nicer as "Create new volume" or
> "New volume" to give context to translators and for better accessibility.

Fixed!
 
> Future improvements:
> It might be nice to offer a kind of grouped view for the items in volumes...
> but I am not sure yet how this would work best. 
> It might be nice to show the volumes in the OPAC as well.

Agreed. If volume management turns out to be popular, that would be an easy extension to this work.
 
> 8) Use case and future plans?
> 
> Can you tell a bit about in what context or use case this partner is using
> this? Serials?

Our current and only use case at this time is for volume level holds. Some libraries keep different volumes on the same record ( imagine different seasons of a TV series ). In these cases, a bib level hold won't work if you only want Season 1, but if there are 3 copies of season one, you wouldn't want an item level hold either. Volume level holds solve this problem.
Comment 150 Kyle M Hall 2020-08-19 17:45:38 UTC
(In reply to Katrin Fischer from comment #127)
> Hm, I've checked the test plan on the dependent bug now too and am still a
> little confused about the use case for this.
> 
> Reading "volume" made me think of something that would be used for serial
> issues bound together into one volume (serials, binding) But this doesn't
> seem to be the case with how the volume hold feature works.

That is correct. The term volume is used here because that is what most if not all other ILSs use.

> Does this more work like a "Hold group" maybe? One item out of the group
> appears to satisfy the hold - so maybe "Group" would be a better word to
> describe the idea?

You are correct! I described it in a bit more detail in my previous comment.
Comment 151 Katrin Fischer 2020-08-22 10:36:31 UTC
Hi Kyle,

>> 3) REST API
>> 
>> I'd love to have Tomas take a look on the REST API bits here. 

>I'll ask Tomas to take a look!

Waiting for Tomas to comment then :)


>> 6) Table configuration
>> 
>> The new volumn column on the holdings table needs to be added to the table
>> configuration options.

>This table is not a datatable so that doesn't really apply.

That one is a misunderstanding I think: The items table on the detail page is controlled by the table configuration settings and the volume column appears there as a new column.

Table configuration > catalog > holdings_table


9) Unit tests

I am a quite suspicious that there are no unit tests at all... We have new things in Biblio.pm, Items.pm and also new modules.
Comment 152 Kyle M Hall 2020-08-25 14:35:49 UTC
Created attachment 109074 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 153 Kyle M Hall 2020-08-25 14:36:03 UTC
Created attachment 109075 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 154 Kyle M Hall 2020-08-25 14:36:08 UTC
Created attachment 109076 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 155 Kyle M Hall 2020-08-25 14:36:13 UTC
Created attachment 109077 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 156 Kyle M Hall 2020-08-25 14:36:18 UTC
Created attachment 109078 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 157 Kyle M Hall 2020-08-25 14:36:23 UTC
Created attachment 109079 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 158 Kyle M Hall 2020-08-25 14:36:28 UTC
Created attachment 109080 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 159 Kyle M Hall 2020-08-25 14:36:33 UTC
Created attachment 109081 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 160 Kyle M Hall 2020-08-25 14:36:38 UTC
Created attachment 109082 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 161 Kyle M Hall 2020-08-25 14:36:43 UTC
Created attachment 109083 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 162 Kyle M Hall 2020-08-25 14:36:47 UTC
Created attachment 109084 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 163 Kyle M Hall 2020-08-25 14:36:52 UTC
Created attachment 109085 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 164 Kyle M Hall 2020-08-25 14:36:57 UTC
Created attachment 109086 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 165 Kyle M Hall 2020-08-25 14:37:01 UTC
Created attachment 109087 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 166 Kyle M Hall 2020-08-25 14:37:06 UTC
Created attachment 109088 [details] [review]
Bug 24857: Fix license statements
Comment 167 Kyle M Hall 2020-08-25 14:37:10 UTC
Created attachment 109089 [details] [review]
Bug 24857: Fix POD
Comment 168 Kyle M Hall 2020-08-25 14:37:15 UTC
Created attachment 109090 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt
Comment 169 Kyle M Hall 2020-08-25 14:37:18 UTC
Created attachment 109091 [details] [review]
Bug 24857: Fix simple-quote string
Comment 170 Kyle M Hall 2020-08-25 14:37:23 UTC
Created attachment 109092 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'
Comment 171 Kyle M Hall 2020-08-25 14:37:27 UTC
Created attachment 109093 [details] [review]
Bug 24857: Fix sorting of new syspref
Comment 172 Kyle M Hall 2020-08-25 14:37:31 UTC
Created attachment 109094 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"
Comment 173 Kyle M Hall 2020-08-25 14:41:15 UTC
(In reply to Katrin Fischer from comment #151)
> Hi Kyle,
> 
> >> 3) REST API
> >> 
> >> I'd love to have Tomas take a look on the REST API bits here. 
> 
> >I'll ask Tomas to take a look!
> 
> Waiting for Tomas to comment then :)
> 
> 
> >> 6) Table configuration
> >> 
> >> The new volumn column on the holdings table needs to be added to the table
> >> configuration options.
> 
> >This table is not a datatable so that doesn't really apply.
> 
> That one is a misunderstanding I think: The items table on the detail page
> is controlled by the table configuration settings and the volume column
> appears there as a new column.
> 
> Table configuration > catalog > holdings_table

I'll take a look!

> 
> 
> 9) Unit tests
> 
> I am a quite suspicious that there are no unit tests at all... We have new
> things in Biblio.pm, Items.pm and also new modules.

I'll add unit tests!
Comment 174 Kyle M Hall 2020-09-09 13:47:10 UTC
Created attachment 109795 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 175 Kyle M Hall 2020-09-09 13:47:24 UTC
Created attachment 109796 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 176 Kyle M Hall 2020-09-09 13:47:29 UTC
Created attachment 109797 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 177 Kyle M Hall 2020-09-09 13:47:34 UTC
Created attachment 109798 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 178 Kyle M Hall 2020-09-09 13:47:39 UTC
Created attachment 109799 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 179 Kyle M Hall 2020-09-09 13:47:44 UTC
Created attachment 109800 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 180 Kyle M Hall 2020-09-09 13:47:49 UTC
Created attachment 109801 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 181 Kyle M Hall 2020-09-09 13:47:53 UTC
Created attachment 109802 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 182 Kyle M Hall 2020-09-09 13:47:58 UTC
Created attachment 109803 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 183 Kyle M Hall 2020-09-09 13:48:03 UTC
Created attachment 109804 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 184 Kyle M Hall 2020-09-09 13:48:07 UTC
Created attachment 109805 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 185 Kyle M Hall 2020-09-09 13:48:12 UTC
Created attachment 109806 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 186 Kyle M Hall 2020-09-09 13:48:17 UTC
Created attachment 109807 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 187 Kyle M Hall 2020-09-09 13:48:23 UTC
Created attachment 109808 [details] [review]
Bug 24857: Fix license statements
Comment 188 Kyle M Hall 2020-09-09 13:48:28 UTC
Created attachment 109809 [details] [review]
Bug 24857: Fix POD
Comment 189 Kyle M Hall 2020-09-09 13:48:33 UTC
Created attachment 109810 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt
Comment 190 Kyle M Hall 2020-09-09 13:48:39 UTC
Created attachment 109811 [details] [review]
Bug 24857: Fix simple-quote string
Comment 191 Kyle M Hall 2020-09-09 13:48:43 UTC
Created attachment 109812 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'
Comment 192 Kyle M Hall 2020-09-09 13:48:48 UTC
Created attachment 109813 [details] [review]
Bug 24857: Fix sorting of new syspref
Comment 193 Kyle M Hall 2020-09-09 13:48:53 UTC
Created attachment 109814 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"
Comment 194 Kyle M Hall 2020-09-09 13:48:58 UTC
Created attachment 109815 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 195 Kyle M Hall 2020-09-11 10:27:38 UTC
Created attachment 109894 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings
Comment 196 Kyle M Hall 2020-09-11 10:53:00 UTC
Created attachment 109901 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 197 Kyle M Hall 2020-09-11 10:53:22 UTC
Created attachment 109902 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 198 Kyle M Hall 2020-09-11 10:53:31 UTC
Created attachment 109903 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 199 Kyle M Hall 2020-09-11 10:53:38 UTC
Created attachment 109904 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 200 Kyle M Hall 2020-09-11 10:53:45 UTC
Created attachment 109905 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 201 Kyle M Hall 2020-09-11 10:53:52 UTC
Created attachment 109906 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 202 Kyle M Hall 2020-09-11 10:54:00 UTC
Created attachment 109907 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 203 Kyle M Hall 2020-09-11 10:54:08 UTC
Created attachment 109908 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 204 Kyle M Hall 2020-09-11 10:54:15 UTC
Created attachment 109909 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 205 Kyle M Hall 2020-09-11 10:54:22 UTC
Created attachment 109910 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 206 Kyle M Hall 2020-09-11 10:54:27 UTC
Created attachment 109911 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 207 Kyle M Hall 2020-09-11 10:54:35 UTC
Created attachment 109912 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 208 Kyle M Hall 2020-09-11 10:54:40 UTC
Created attachment 109913 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 209 Kyle M Hall 2020-09-11 10:54:46 UTC
Created attachment 109914 [details] [review]
Bug 24857: Fix license statements
Comment 210 Kyle M Hall 2020-09-11 10:54:52 UTC
Created attachment 109915 [details] [review]
Bug 24857: Fix POD
Comment 211 Kyle M Hall 2020-09-11 10:54:58 UTC
Created attachment 109916 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt
Comment 212 Kyle M Hall 2020-09-11 10:55:11 UTC
Created attachment 109917 [details] [review]
Bug 24857: Fix simple-quote string
Comment 213 Kyle M Hall 2020-09-11 10:55:18 UTC
Created attachment 109918 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'
Comment 214 Kyle M Hall 2020-09-11 10:55:26 UTC
Created attachment 109919 [details] [review]
Bug 24857: Fix sorting of new syspref
Comment 215 Kyle M Hall 2020-09-11 10:55:31 UTC
Created attachment 109920 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"
Comment 216 Kyle M Hall 2020-09-11 10:55:37 UTC
Created attachment 109921 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 217 Kyle M Hall 2020-09-11 10:55:44 UTC
Created attachment 109922 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings
Comment 218 Kyle M Hall 2020-09-11 10:55:54 UTC
Created attachment 109923 [details] [review]
Bug 24857: (QA follow-up) Unit tests
Comment 219 Katrin Fischer 2020-09-12 21:07:45 UTC
Hi Kyle,

tests pass, but there is a db error when you run them:

[2020-09-12 21:06:37.69672] [26709] [debug] POST "/api/v1/biblios/XXX/volumes" (57471cdc)
[2020-09-12 21:06:37.69813] [26709] [debug] Routing to controller "Koha::REST::V1::Auth" and action "under"
[2020-09-12 21:06:37.72833] [26709] [debug] Routing to controller "Koha::REST::V1::Biblios::Volumes" and action "add"
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`volumes`, CONSTRAINT `volumes_ibfk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `volumes` ( `biblionumber`, `created_on`, `description`, `display_order`, `updated_on`) VALUES ( ?, NOW(), ?, ?, current_timestamp )" with ParamValues: 0=0, 1="Vol 1", 2=1] at /home/vagrant/kohaclone/Koha/Object.pm line 166
[2020-09-12 21:06:37.73397] [26709] [debug] 409 Conflict (0.037233s, 26.858/s)
    ok 5 - POST //jFfMRdUyfmSrbUO5TWioGEhp2HSDQXGSqy01hFdFW0DUU9utfXIyBXUNR:thePassword123@/api/v1/biblios/XXX/volumes
    ok 6 - SWAGGER3.2.1
ok 2 - volumes add() tests

Can you please check?
Comment 220 Kyle M Hall 2020-11-05 19:52:11 UTC
Created attachment 113136 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 221 Kyle M Hall 2020-11-05 19:54:58 UTC
Created attachment 113137 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 222 Kyle M Hall 2020-11-05 19:55:11 UTC
Created attachment 113138 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 223 Kyle M Hall 2020-11-05 19:55:16 UTC
Created attachment 113139 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 224 Kyle M Hall 2020-11-05 19:55:21 UTC
Created attachment 113140 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 225 Kyle M Hall 2020-11-05 19:55:26 UTC
Created attachment 113141 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 226 Kyle M Hall 2020-11-05 19:55:31 UTC
Created attachment 113142 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 227 Kyle M Hall 2020-11-05 19:55:36 UTC
Created attachment 113143 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 228 Kyle M Hall 2020-11-05 19:55:41 UTC
Created attachment 113144 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 229 Kyle M Hall 2020-11-05 19:55:45 UTC
Created attachment 113145 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 230 Kyle M Hall 2020-11-05 19:55:51 UTC
Created attachment 113146 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 231 Kyle M Hall 2020-11-05 19:55:55 UTC
Created attachment 113147 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 232 Kyle M Hall 2020-11-05 19:56:00 UTC
Created attachment 113148 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 233 Kyle M Hall 2020-11-05 19:56:05 UTC
Created attachment 113149 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 234 Kyle M Hall 2020-11-05 19:56:09 UTC
Created attachment 113150 [details] [review]
Bug 24857: Fix license statements
Comment 235 Kyle M Hall 2020-11-05 19:56:14 UTC
Created attachment 113151 [details] [review]
Bug 24857: Fix POD
Comment 236 Kyle M Hall 2020-11-05 19:56:18 UTC
Created attachment 113152 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt
Comment 237 Kyle M Hall 2020-11-05 19:56:23 UTC
Created attachment 113153 [details] [review]
Bug 24857: Fix simple-quote string
Comment 238 Kyle M Hall 2020-11-05 19:56:27 UTC
Created attachment 113154 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'
Comment 239 Kyle M Hall 2020-11-05 19:56:32 UTC
Created attachment 113155 [details] [review]
Bug 24857: Fix sorting of new syspref
Comment 240 Kyle M Hall 2020-11-05 19:56:36 UTC
Created attachment 113156 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"
Comment 241 Kyle M Hall 2020-11-05 19:56:41 UTC
Created attachment 113157 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings
Comment 242 Kyle M Hall 2020-11-05 19:56:45 UTC
Created attachment 113158 [details] [review]
Bug 24857: (QA follow-up) Unit tests
Comment 243 Kyle M Hall 2020-11-05 19:56:51 UTC
Created attachment 113159 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 244 Kyle M Hall 2020-11-05 19:56:55 UTC
Created attachment 113160 [details] [review]
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete
Comment 245 Kyle M Hall 2020-11-05 20:08:55 UTC
Created attachment 113168 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 246 Kyle M Hall 2020-11-05 20:09:10 UTC
Created attachment 113169 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 247 Kyle M Hall 2020-11-05 20:09:15 UTC
Created attachment 113170 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 248 Kyle M Hall 2020-11-05 20:09:21 UTC
Created attachment 113171 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 249 Kyle M Hall 2020-11-05 20:09:26 UTC
Created attachment 113172 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 250 Kyle M Hall 2020-11-05 20:09:30 UTC
Created attachment 113173 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 251 Kyle M Hall 2020-11-05 20:09:35 UTC
Created attachment 113174 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 252 Kyle M Hall 2020-11-05 20:09:40 UTC
Created attachment 113175 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 253 Kyle M Hall 2020-11-05 20:09:45 UTC
Created attachment 113176 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 254 Kyle M Hall 2020-11-05 20:09:50 UTC
Created attachment 113177 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 255 Kyle M Hall 2020-11-05 20:09:54 UTC
Created attachment 113178 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 256 Kyle M Hall 2020-11-05 20:09:59 UTC
Created attachment 113179 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 257 Kyle M Hall 2020-11-05 20:10:03 UTC
Created attachment 113180 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 258 Kyle M Hall 2020-11-05 20:10:08 UTC
Created attachment 113181 [details] [review]
Bug 24857: Fix license statements
Comment 259 Kyle M Hall 2020-11-05 20:10:13 UTC
Created attachment 113182 [details] [review]
Bug 24857: Fix POD
Comment 260 Kyle M Hall 2020-11-05 20:10:17 UTC
Created attachment 113183 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt
Comment 261 Kyle M Hall 2020-11-05 20:10:22 UTC
Created attachment 113184 [details] [review]
Bug 24857: Fix simple-quote string
Comment 262 Kyle M Hall 2020-11-05 20:10:27 UTC
Created attachment 113185 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'
Comment 263 Kyle M Hall 2020-11-05 20:10:31 UTC
Created attachment 113186 [details] [review]
Bug 24857: Fix sorting of new syspref
Comment 264 Kyle M Hall 2020-11-05 20:10:36 UTC
Created attachment 113187 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"
Comment 265 Kyle M Hall 2020-11-05 20:10:41 UTC
Created attachment 113188 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings
Comment 266 Kyle M Hall 2020-11-05 20:10:46 UTC
Created attachment 113189 [details] [review]
Bug 24857: (QA follow-up) Unit tests
Comment 267 Kyle M Hall 2020-11-05 20:10:50 UTC
Created attachment 113190 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 268 Kyle M Hall 2020-11-05 20:10:55 UTC
Created attachment 113191 [details] [review]
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete
Comment 269 Kyle M Hall 2020-11-05 20:11:10 UTC
(In reply to Katrin Fischer from comment #219)
> Hi Kyle,
> 
> tests pass, but there is a db error when you run them:
> 
> [2020-09-12 21:06:37.69672] [26709] [debug] POST
> "/api/v1/biblios/XXX/volumes" (57471cdc)
> [2020-09-12 21:06:37.69813] [26709] [debug] Routing to controller
> "Koha::REST::V1::Auth" and action "under"
> [2020-09-12 21:06:37.72833] [26709] [debug] Routing to controller
> "Koha::REST::V1::Biblios::Volumes" and action "add"
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> execute failed: Cannot add or update a child row: a foreign key constraint
> fails (`koha_kohadev`.`volumes`, CONSTRAINT `volumes_ibfk_1` FOREIGN KEY
> (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON
> UPDATE CASCADE) [for Statement "INSERT INTO `volumes` ( `biblionumber`,
> `created_on`, `description`, `display_order`, `updated_on`) VALUES ( ?,
> NOW(), ?, ?, current_timestamp )" with ParamValues: 0=0, 1="Vol 1", 2=1] at
> /home/vagrant/kohaclone/Koha/Object.pm line 166
> [2020-09-12 21:06:37.73397] [26709] [debug] 409 Conflict (0.037233s,
> 26.858/s)
>     ok 5 - POST
> //jFfMRdUyfmSrbUO5TWioGEhp2HSDQXGSqy01hFdFW0DUU9utfXIyBXUNR:thePassword123@/
> api/v1/biblios/XXX/volumes
>     ok 6 - SWAGGER3.2.1
> ok 2 - volumes add() tests
> 
> Can you please check?

That error is expected, as we are testing adding a volume for an invalid biblionumber.
Comment 270 Katrin Fischer 2021-05-02 14:01:23 UTC
As this had been waiting so long I've tried to fix the conflict in kohastructure.sql myself, but then ran into the next one in paths.json...

Can you please rebase?
Comment 271 Kyle M Hall 2021-05-05 13:23:21 UTC
Created attachment 120495 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 272 Kyle M Hall 2021-05-05 13:24:00 UTC
Created attachment 120496 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 273 Kyle M Hall 2021-05-05 13:24:07 UTC
Created attachment 120497 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 274 Kyle M Hall 2021-05-05 13:24:13 UTC
Created attachment 120498 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 275 Kyle M Hall 2021-05-05 13:24:19 UTC
Created attachment 120499 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 276 Kyle M Hall 2021-05-05 13:24:25 UTC
Created attachment 120500 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 277 Kyle M Hall 2021-05-05 13:24:31 UTC
Created attachment 120501 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 278 Kyle M Hall 2021-05-05 13:24:38 UTC
Created attachment 120502 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 279 Kyle M Hall 2021-05-05 13:24:44 UTC
Created attachment 120503 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 280 Kyle M Hall 2021-05-05 13:24:50 UTC
Created attachment 120504 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 281 Kyle M Hall 2021-05-05 13:24:56 UTC
Created attachment 120505 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 282 Kyle M Hall 2021-05-05 13:25:01 UTC
Created attachment 120506 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 283 Kyle M Hall 2021-05-05 13:25:08 UTC
Created attachment 120507 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 284 Kyle M Hall 2021-05-05 13:25:14 UTC
Created attachment 120508 [details] [review]
Bug 24857: Fix license statements
Comment 285 Kyle M Hall 2021-05-05 13:25:20 UTC
Created attachment 120509 [details] [review]
Bug 24857: Fix POD
Comment 286 Kyle M Hall 2021-05-05 13:25:26 UTC
Created attachment 120510 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt
Comment 287 Kyle M Hall 2021-05-05 13:25:31 UTC
Created attachment 120511 [details] [review]
Bug 24857: Fix simple-quote string
Comment 288 Kyle M Hall 2021-05-05 13:25:37 UTC
Created attachment 120512 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'
Comment 289 Kyle M Hall 2021-05-05 13:25:43 UTC
Created attachment 120513 [details] [review]
Bug 24857: Fix sorting of new syspref
Comment 290 Kyle M Hall 2021-05-05 13:25:49 UTC
Created attachment 120514 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"
Comment 291 Kyle M Hall 2021-05-05 13:25:54 UTC
Created attachment 120515 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings
Comment 292 Kyle M Hall 2021-05-05 13:26:00 UTC
Created attachment 120516 [details] [review]
Bug 24857: (QA follow-up) Unit tests
Comment 293 Kyle M Hall 2021-05-05 13:26:06 UTC
Created attachment 120517 [details] [review]
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete
Comment 294 Kyle M Hall 2021-05-05 13:26:13 UTC
Created attachment 120518 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 295 Kyle M Hall 2021-07-13 16:49:47 UTC
Created attachment 122808 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 296 Kyle M Hall 2021-07-13 16:50:14 UTC
Created attachment 122809 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 297 Kyle M Hall 2021-07-13 16:50:19 UTC
Created attachment 122810 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 298 Kyle M Hall 2021-07-13 16:50:25 UTC
Created attachment 122811 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 299 Kyle M Hall 2021-07-13 16:50:31 UTC
Created attachment 122812 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 300 Kyle M Hall 2021-07-13 16:50:37 UTC
Created attachment 122813 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 301 Kyle M Hall 2021-07-13 16:50:43 UTC
Created attachment 122814 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 302 Kyle M Hall 2021-07-13 16:50:48 UTC
Created attachment 122815 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 303 Kyle M Hall 2021-07-13 16:50:54 UTC
Created attachment 122816 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 304 Kyle M Hall 2021-07-13 16:51:02 UTC
Created attachment 122817 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 305 Kyle M Hall 2021-07-13 16:51:11 UTC
Created attachment 122818 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 306 Kyle M Hall 2021-07-13 16:51:17 UTC
Created attachment 122819 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 307 Kyle M Hall 2021-07-13 16:51:23 UTC
Created attachment 122820 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Comment 308 Kyle M Hall 2021-07-13 16:51:29 UTC
Created attachment 122821 [details] [review]
Bug 24857: Fix license statements
Comment 309 Kyle M Hall 2021-07-13 16:51:34 UTC
Created attachment 122822 [details] [review]
Bug 24857: Fix POD
Comment 310 Kyle M Hall 2021-07-13 16:51:40 UTC
Created attachment 122823 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt
Comment 311 Kyle M Hall 2021-07-13 16:51:46 UTC
Created attachment 122824 [details] [review]
Bug 24857: Fix simple-quote string
Comment 312 Kyle M Hall 2021-07-13 16:51:53 UTC
Created attachment 122825 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'
Comment 313 Kyle M Hall 2021-07-13 16:51:59 UTC
Created attachment 122826 [details] [review]
Bug 24857: Fix sorting of new syspref
Comment 314 Kyle M Hall 2021-07-13 16:52:06 UTC
Created attachment 122827 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"
Comment 315 Kyle M Hall 2021-07-13 16:52:11 UTC
Created attachment 122828 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings
Comment 316 Kyle M Hall 2021-07-13 16:52:16 UTC
Created attachment 122829 [details] [review]
Bug 24857: (QA follow-up) Unit tests
Comment 317 Kyle M Hall 2021-07-13 16:52:22 UTC
Created attachment 122830 [details] [review]
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete
Comment 318 Kyle M Hall 2021-07-13 16:52:28 UTC
Created attachment 122831 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]
Comment 319 Tomás Cohen Arazi 2021-08-17 20:03:56 UTC
Created attachment 123882 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 320 Tomás Cohen Arazi 2021-08-17 20:04:07 UTC
Created attachment 123883 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 321 Tomás Cohen Arazi 2021-08-17 20:04:20 UTC
Created attachment 123884 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 322 Tomás Cohen Arazi 2021-08-17 20:04:30 UTC
Created attachment 123885 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 323 Tomás Cohen Arazi 2021-08-17 20:04:41 UTC
Created attachment 123886 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 324 Tomás Cohen Arazi 2021-08-17 20:04:53 UTC
Created attachment 123887 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 325 Tomás Cohen Arazi 2021-08-17 20:05:04 UTC
Created attachment 123888 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 326 Tomás Cohen Arazi 2021-08-17 20:05:15 UTC
Created attachment 123889 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 327 Tomás Cohen Arazi 2021-08-17 20:05:26 UTC
Created attachment 123890 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 328 Tomás Cohen Arazi 2021-08-17 20:05:35 UTC
Created attachment 123891 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 329 Tomás Cohen Arazi 2021-08-17 20:05:46 UTC
Created attachment 123892 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 330 Tomás Cohen Arazi 2021-08-17 20:05:59 UTC
Created attachment 123893 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 331 Tomás Cohen Arazi 2021-08-17 20:06:10 UTC
Created attachment 123894 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 332 Tomás Cohen Arazi 2021-08-17 20:06:22 UTC
Created attachment 123895 [details] [review]
Bug 24857: Fix license statements

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 333 Tomás Cohen Arazi 2021-08-17 20:06:32 UTC
Created attachment 123896 [details] [review]
Bug 24857: Fix POD

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 334 Tomás Cohen Arazi 2021-08-17 20:06:42 UTC
Created attachment 123897 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 335 Tomás Cohen Arazi 2021-08-17 20:06:52 UTC
Created attachment 123898 [details] [review]
Bug 24857: Fix simple-quote string

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 336 Tomás Cohen Arazi 2021-08-17 20:07:01 UTC
Created attachment 123899 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 337 Tomás Cohen Arazi 2021-08-17 20:07:12 UTC
Created attachment 123900 [details] [review]
Bug 24857: Fix sorting of new syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 338 Tomás Cohen Arazi 2021-08-17 20:07:24 UTC
Created attachment 123901 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 339 Tomás Cohen Arazi 2021-08-17 20:07:33 UTC
Created attachment 123902 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 340 Tomás Cohen Arazi 2021-08-17 20:07:45 UTC
Created attachment 123903 [details] [review]
Bug 24857: (QA follow-up) Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 341 Tomás Cohen Arazi 2021-08-17 20:07:55 UTC
Created attachment 123904 [details] [review]
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 342 Tomás Cohen Arazi 2021-08-17 20:08:07 UTC
Created attachment 123905 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 343 Tomás Cohen Arazi 2021-08-17 20:08:18 UTC
Created attachment 123906 [details] [review]
Bug 24857: (QA follow-up) Fix QA script issues

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 344 Tomás Cohen Arazi 2021-08-17 20:08:27 UTC
Created attachment 123907 [details] [review]
Bug 24857: (follow-up) Use $c->unhandled_exception

This patch makes the controller up to date with the currently used style
and codebase.

It also sinlences a useless warning, and makes it return 404 (instead of
409) when trying to add items to a volume on a non-existing biblio.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Some warnings
2. Apply this patch
3. Repeat 1
=> SUCCESS: No errors, no warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 345 Tomás Cohen Arazi 2021-08-17 20:08:40 UTC
Created attachment 123908 [details] [review]
Bug 24857: Use $c->objects->find

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 346 Tomás Cohen Arazi 2021-08-17 20:08:52 UTC
Created attachment 123909 [details] [review]
Bug 24857: Fix permissions in spec

This patch corrects the spec so it requires the right permissions.
Comment 347 Tomás Cohen Arazi 2021-08-17 20:09:07 UTC
Created attachment 123910 [details] [review]
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio

I noticed some tests included /biblios/{biblio_id}/volumes... in the
URL. And they passed :-D This means the biblio_id is never tested.

This patch fixes those two tests so they have valid biblio_id in the
path, and adds a proper regression test for the expected behavior (409).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Notice the tests pass, even with bad data on the request
2. Apply this patch, notice a test is added for the bad biblio_id case
   and the other two tests are fixed so they have the intended
   biblio_id.
3. Repeat 1
=> SUCCESS: Tests pass! This means things are correctly tested in the
   controller and the unit tests cover teh 'bad case' returning 409.
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 348 Tomás Cohen Arazi 2021-08-17 20:09:18 UTC
Created attachment 123912 [details] [review]
Bug 24857: (QA follow-up) Further spec fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 349 Tomás Cohen Arazi 2021-08-23 15:08:06 UTC
Created attachment 124021 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 350 Tomás Cohen Arazi 2021-08-23 15:08:28 UTC
Created attachment 124022 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 351 Tomás Cohen Arazi 2021-08-23 15:08:45 UTC
Created attachment 124023 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 352 Tomás Cohen Arazi 2021-08-23 15:08:59 UTC
Created attachment 124024 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 353 Tomás Cohen Arazi 2021-08-23 15:09:14 UTC
Created attachment 124025 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 354 Tomás Cohen Arazi 2021-08-23 15:09:39 UTC
Created attachment 124026 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 355 Tomás Cohen Arazi 2021-08-23 15:10:19 UTC
Created attachment 124027 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 356 Tomás Cohen Arazi 2021-08-23 15:10:41 UTC
Created attachment 124028 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 357 Tomás Cohen Arazi 2021-08-23 15:11:00 UTC
Created attachment 124029 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 358 Tomás Cohen Arazi 2021-08-23 15:11:15 UTC
Created attachment 124030 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 359 Tomás Cohen Arazi 2021-08-23 15:11:27 UTC
Created attachment 124031 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 360 Tomás Cohen Arazi 2021-08-23 15:11:41 UTC
Created attachment 124032 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 361 Tomás Cohen Arazi 2021-08-23 15:12:14 UTC
Created attachment 124033 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 362 Tomás Cohen Arazi 2021-08-23 15:12:27 UTC
Created attachment 124034 [details] [review]
Bug 24857: Fix license statements

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 363 Tomás Cohen Arazi 2021-08-23 15:12:52 UTC
Created attachment 124035 [details] [review]
Bug 24857: Fix POD

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 364 Tomás Cohen Arazi 2021-08-23 15:13:22 UTC
Created attachment 124036 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 365 Tomás Cohen Arazi 2021-08-23 15:13:48 UTC
Created attachment 124037 [details] [review]
Bug 24857: Fix simple-quote string

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 366 Tomás Cohen Arazi 2021-08-23 15:14:19 UTC
Created attachment 124038 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 367 Tomás Cohen Arazi 2021-08-23 15:14:39 UTC
Created attachment 124039 [details] [review]
Bug 24857: Fix sorting of new syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 368 Tomás Cohen Arazi 2021-08-23 15:14:57 UTC
Created attachment 124040 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 369 Tomás Cohen Arazi 2021-08-23 15:15:20 UTC
Created attachment 124041 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 370 Tomás Cohen Arazi 2021-08-23 15:15:47 UTC
Created attachment 124042 [details] [review]
Bug 24857: (QA follow-up) Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 371 Tomás Cohen Arazi 2021-08-23 15:16:04 UTC
Created attachment 124043 [details] [review]
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 372 Tomás Cohen Arazi 2021-08-23 15:16:24 UTC
Created attachment 124044 [details] [review]
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 373 Tomás Cohen Arazi 2021-08-23 15:16:50 UTC
Created attachment 124045 [details] [review]
Bug 24857: (QA follow-up) Fix QA script issues

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 374 Tomás Cohen Arazi 2021-08-23 15:17:08 UTC
Created attachment 124046 [details] [review]
Bug 24857: (follow-up) Use $c->unhandled_exception

This patch makes the controller up to date with the currently used style
and codebase.

It also sinlences a useless warning, and makes it return 404 (instead of
409) when trying to add items to a volume on a non-existing biblio.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Some warnings
2. Apply this patch
3. Repeat 1
=> SUCCESS: No errors, no warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 375 Tomás Cohen Arazi 2021-08-23 15:17:28 UTC
Created attachment 124047 [details] [review]
Bug 24857: Use $c->objects->find

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 376 Tomás Cohen Arazi 2021-08-23 15:17:56 UTC
Created attachment 124048 [details] [review]
Bug 24857: Fix permissions in spec

This patch corrects the spec so it requires the right permissions.
Comment 377 Tomás Cohen Arazi 2021-08-23 15:18:23 UTC
Created attachment 124049 [details] [review]
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio

I noticed some tests included /biblios/{biblio_id}/volumes... in the
URL. And they passed :-D This means the biblio_id is never tested.

This patch fixes those two tests so they have valid biblio_id in the
path, and adds a proper regression test for the expected behavior (409).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Notice the tests pass, even with bad data on the request
2. Apply this patch, notice a test is added for the bad biblio_id case
   and the other two tests are fixed so they have the intended
   biblio_id.
3. Repeat 1
=> SUCCESS: Tests pass! This means things are correctly tested in the
   controller and the unit tests cover teh 'bad case' returning 409.
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 378 Tomás Cohen Arazi 2021-08-23 15:18:43 UTC
Created attachment 124050 [details] [review]
Bug 24857: (QA follow-up) Further spec fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 379 Tomás Cohen Arazi 2021-08-23 15:19:06 UTC
Created attachment 124051 [details] [review]
Bug 24857: Rename Volumes => Item groups (DB)

This patch renames Volumes => Item groups in the DB structure, and also
on permissions and sysprefs.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 380 Tomás Cohen Arazi 2021-08-23 15:19:34 UTC
Created attachment 124052 [details] [review]
Bug 24857: Adapt code to the volumes => item_groups change

This patch updates the code so all references to 'volumes' are
translated into 'item groups'.

Relevant changes:
- API routes and specs
- Permission name is changed
- Syspref name changed

Note: I removed a behavior that felt unnatural (at least in the place it
was put): deleting the item group if the linked item is deleted. It
feels like a controller thing, and also something that could be offered
to the staff on the UI on item deletion. To avoid blocking the feature,
I suggest this removal, and discuss it in its own context.

To test:
1. Run:
   $ reset_all
2. Apply this patchset
3. Run:
   $ updatedatabase
=> SUCCESS: Update works
4. Repeat 1 (with the patches applied)
=> SUCCESS: Install works with this DB structure
5. Run all the tests:
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> SUCCESS: Tests pass!
6. Follow the original plan (with the Volume=>ItemGRoup change in mind)
=> SUCCESS: All good!
7. Sign off :-D
Comment 381 Tomás Cohen Arazi 2021-08-23 15:20:01 UTC
Created attachment 124053 [details] [review]
Bug 24857: item_group_items.item_id must be unique
Comment 382 David Cook 2021-08-26 23:35:16 UTC
I'm really glad to see Volume change to Item Group, because we've had a number of times when we've wanted to have Item Group holds where library staff could group together items. 

I haven't looked through the code in a long time. Is it just for holds or does it handle aspects of circulation too like checkouts? That's just a question and by no means a comment on the patches. Just curious.
Comment 383 Tomás Cohen Arazi 2021-08-26 23:45:55 UTC
(In reply to David Cook from comment #382)
> I'm really glad to see Volume change to Item Group, because we've had a
> number of times when we've wanted to have Item Group holds where library
> staff could group together items. 
> 
> I haven't looked through the code in a long time. Is it just for holds or
> does it handle aspects of circulation too like checkouts? That's just a
> question and by no means a comment on the patches. Just curious.

This code implements the groups. There's a separate bug that implements hold fulfillment by group items. That one will need some changes after the refactoring we made.

It would be great if you could go QA this one so we can build the rest on top of this.
Comment 384 David Cook 2021-08-27 00:15:41 UTC
(In reply to Tomás Cohen Arazi from comment #383)
> This code implements the groups. There's a separate bug that implements hold
> fulfillment by group items. That one will need some changes after the
> refactoring we made.
> 
> It would be great if you could go QA this one so we can build the rest on
> top of this.

With 33 patches, I think this might make it on the TODO list that I just feel guilty about and never action :(.
Comment 385 Tomás Cohen Arazi 2021-08-27 00:40:49 UTC
(In reply to David Cook from comment #384)
> (In reply to Tomás Cohen Arazi from comment #383)
> > This code implements the groups. There's a separate bug that implements hold
> > fulfillment by group items. That one will need some changes after the
> > refactoring we made.
> > 
> > It would be great if you could go QA this one so we can build the rest on
> > top of this.
> 
> With 33 patches, I think this might make it on the TODO list that I just
> feel guilty about and never action :(.

If you apply them, and do a git diff, things are pretty clear and simple.

I hesitated to squash everything because it wasn't my dev.
Comment 386 David Cook 2021-08-30 01:49:12 UTC
(In reply to Tomás Cohen Arazi from comment #385)
> (In reply to David Cook from comment #384)
> > (In reply to Tomás Cohen Arazi from comment #383)
> > > This code implements the groups. There's a separate bug that implements hold
> > > fulfillment by group items. That one will need some changes after the
> > > refactoring we made.
> > > 
> > > It would be great if you could go QA this one so we can build the rest on
> > > top of this.
> > 
> > With 33 patches, I think this might make it on the TODO list that I just
> > feel guilty about and never action :(.
> 
> If you apply them, and do a git diff, things are pretty clear and simple.

That takes a fair number of steps (starting up koha-testing-docker is very slow these days due to db setup), and it isn't easy to comment via Bugzilla when the changes are spread out across a large number of overlapping patches. 

> I hesitated to squash everything because it wasn't my dev.

Yeah that makes sense. I wasn't suggesting that someone should. I'm just super time poor for Koha these days. 

--

Mostly it's just me making excuses not to do things :(
Comment 387 Tomás Cohen Arazi 2021-09-01 13:14:36 UTC
Created attachment 124331 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 388 Tomás Cohen Arazi 2021-09-01 13:14:46 UTC
Created attachment 124332 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 389 Tomás Cohen Arazi 2021-09-01 13:14:58 UTC
Created attachment 124333 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 390 Tomás Cohen Arazi 2021-09-01 13:15:17 UTC
Created attachment 124334 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 391 Tomás Cohen Arazi 2021-09-01 13:15:27 UTC
Created attachment 124335 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 392 Tomás Cohen Arazi 2021-09-01 13:15:37 UTC
Created attachment 124336 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 393 Tomás Cohen Arazi 2021-09-01 13:15:48 UTC
Created attachment 124337 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 394 Tomás Cohen Arazi 2021-09-01 13:15:59 UTC
Created attachment 124338 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 395 Tomás Cohen Arazi 2021-09-01 13:16:10 UTC
Created attachment 124339 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 396 Tomás Cohen Arazi 2021-09-01 13:16:23 UTC
Created attachment 124340 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 397 Tomás Cohen Arazi 2021-09-01 13:16:34 UTC
Created attachment 124341 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 398 Tomás Cohen Arazi 2021-09-01 13:16:44 UTC
Created attachment 124342 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 399 Tomás Cohen Arazi 2021-09-01 13:16:55 UTC
Created attachment 124343 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 400 Tomás Cohen Arazi 2021-09-01 13:17:04 UTC
Created attachment 124344 [details] [review]
Bug 24857: Fix license statements

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 401 Tomás Cohen Arazi 2021-09-01 13:17:16 UTC
Created attachment 124345 [details] [review]
Bug 24857: Fix POD

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 402 Tomás Cohen Arazi 2021-09-01 13:17:27 UTC
Created attachment 124346 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 403 Tomás Cohen Arazi 2021-09-01 13:17:38 UTC
Created attachment 124347 [details] [review]
Bug 24857: Fix simple-quote string

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 404 Tomás Cohen Arazi 2021-09-01 13:17:52 UTC
Created attachment 124348 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 405 Tomás Cohen Arazi 2021-09-01 13:18:03 UTC
Created attachment 124349 [details] [review]
Bug 24857: Fix sorting of new syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 406 Tomás Cohen Arazi 2021-09-01 13:18:15 UTC
Created attachment 124351 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 407 Tomás Cohen Arazi 2021-09-01 13:18:26 UTC
Created attachment 124352 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 408 Tomás Cohen Arazi 2021-09-01 13:18:37 UTC
Created attachment 124353 [details] [review]
Bug 24857: (QA follow-up) Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 409 Tomás Cohen Arazi 2021-09-01 13:18:49 UTC
Created attachment 124354 [details] [review]
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 410 Tomás Cohen Arazi 2021-09-01 13:19:00 UTC
Created attachment 124355 [details] [review]
Bug 24857: (QA follow-up) Fix QA script issues

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 411 Tomás Cohen Arazi 2021-09-01 13:19:11 UTC
Created attachment 124356 [details] [review]
Bug 24857: (follow-up) Use $c->unhandled_exception

This patch makes the controller up to date with the currently used style
and codebase.

It also sinlences a useless warning, and makes it return 404 (instead of
409) when trying to add items to a volume on a non-existing biblio.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Some warnings
2. Apply this patch
3. Repeat 1
=> SUCCESS: No errors, no warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 412 Tomás Cohen Arazi 2021-09-01 13:19:22 UTC
Created attachment 124357 [details] [review]
Bug 24857: Use $c->objects->find

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 413 Tomás Cohen Arazi 2021-09-01 13:19:33 UTC
Created attachment 124358 [details] [review]
Bug 24857: Fix permissions in spec

This patch corrects the spec so it requires the right permissions.
Comment 414 Tomás Cohen Arazi 2021-09-01 13:19:48 UTC
Created attachment 124359 [details] [review]
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio

I noticed some tests included /biblios/{biblio_id}/volumes... in the
URL. And they passed :-D This means the biblio_id is never tested.

This patch fixes those two tests so they have valid biblio_id in the
path, and adds a proper regression test for the expected behavior (409).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Notice the tests pass, even with bad data on the request
2. Apply this patch, notice a test is added for the bad biblio_id case
   and the other two tests are fixed so they have the intended
   biblio_id.
3. Repeat 1
=> SUCCESS: Tests pass! This means things are correctly tested in the
   controller and the unit tests cover teh 'bad case' returning 409.
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 415 Tomás Cohen Arazi 2021-09-01 13:19:59 UTC
Created attachment 124360 [details] [review]
Bug 24857: (QA follow-up) Further spec fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 416 Tomás Cohen Arazi 2021-09-01 13:20:13 UTC
Created attachment 124361 [details] [review]
Bug 24857: Rename Volumes => Item groups (DB)

This patch renames Volumes => Item groups in the DB structure, and also
on permissions and sysprefs.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 417 Tomás Cohen Arazi 2021-09-01 13:20:38 UTC
Created attachment 124362 [details] [review]
Bug 24857: Adapt code to the volumes => item_groups change

This patch updates the code so all references to 'volumes' are
translated into 'item groups'.

Relevant changes:
- API routes and specs
- Permission name is changed
- Syspref name changed

Note: I removed a behavior that felt unnatural (at least in the place it
was put): deleting the item group if the linked item is deleted. It
feels like a controller thing, and also something that could be offered
to the staff on the UI on item deletion. To avoid blocking the feature,
I suggest this removal, and discuss it in its own context.

To test:
1. Run:
   $ reset_all
2. Apply this patchset
3. Run:
   $ updatedatabase
=> SUCCESS: Update works
4. Repeat 1 (with the patches applied)
=> SUCCESS: Install works with this DB structure
5. Run all the tests:
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> SUCCESS: Tests pass!
6. Follow the original plan (with the Volume=>ItemGRoup change in mind)
=> SUCCESS: All good!
7. Sign off :-D
Comment 418 Tomás Cohen Arazi 2021-09-01 13:20:57 UTC
Created attachment 124363 [details] [review]
Bug 24857: item_group_items.item_id must be unique
Comment 419 Martin Renvoize 2021-09-02 09:12:08 UTC
Created attachment 124421 [details] [review]
Bug 24857: (QA follow-up) Fix for missing Scalar context

Template Toolkit will generally assume list context and so we get the
wrong result when chaning relationships. We must force scalar context
using the Scalar plugin.
Comment 420 Martin Renvoize 2021-09-02 09:42:48 UTC
I presume it's deliberate to not expose any of this on the OPAC at all at this time?  That comes with the holds work etc?
Comment 421 Martin Renvoize 2021-09-02 09:57:28 UTC
I probably would have used the rowGroup plugin for DataTables to visually group the grouped items.. but that can be done in a followup bug maybe?
Comment 422 Tomás Cohen Arazi 2021-09-03 13:12:06 UTC
Removing dependency on bug 28883 as it is only relevant for the tests (not) using ->as_list. And is not fair for this bug to be blocked by it.
Comment 423 Tomás Cohen Arazi 2021-09-03 13:17:06 UTC
Created attachment 124463 [details] [review]
Bug 24857: Do not depend on bug 28883

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 424 Martin Renvoize 2021-09-07 14:08:38 UTC
Created attachment 124583 [details] [review]
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the ability to place holds
at a volume level, rather than on a specific item or any available item on a record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 425 Martin Renvoize 2021-09-07 14:08:45 UTC
Created attachment 124584 [details] [review]
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 426 Martin Renvoize 2021-09-07 14:08:52 UTC
Created attachment 124585 [details] [review]
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 427 Martin Renvoize 2021-09-07 14:09:00 UTC
Created attachment 124586 [details] [review]
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 428 Martin Renvoize 2021-09-07 14:09:07 UTC
Created attachment 124587 [details] [review]
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 429 Martin Renvoize 2021-09-07 14:09:16 UTC
Created attachment 124588 [details] [review]
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 430 Martin Renvoize 2021-09-07 14:09:23 UTC
Created attachment 124589 [details] [review]
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 431 Martin Renvoize 2021-09-07 14:09:32 UTC
Created attachment 124590 [details] [review]
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 432 Martin Renvoize 2021-09-07 14:09:40 UTC
Created attachment 124591 [details] [review]
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 433 Martin Renvoize 2021-09-07 14:09:49 UTC
Created attachment 124592 [details] [review]
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 434 Martin Renvoize 2021-09-07 14:09:56 UTC
Created attachment 124593 [details] [review]
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 435 Martin Renvoize 2021-09-07 14:10:04 UTC
Created attachment 124594 [details] [review]
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 436 Martin Renvoize 2021-09-07 14:10:13 UTC
Created attachment 124595 [details] [review]
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 437 Martin Renvoize 2021-09-07 14:10:20 UTC
Created attachment 124596 [details] [review]
Bug 24857: Fix license statements

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 438 Martin Renvoize 2021-09-07 14:10:28 UTC
Created attachment 124597 [details] [review]
Bug 24857: Fix POD

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 439 Martin Renvoize 2021-09-07 14:10:35 UTC
Created attachment 124598 [details] [review]
Bug 24857: Add missing filter and move js to footer on additem.tt

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 440 Martin Renvoize 2021-09-07 14:10:42 UTC
Created attachment 124599 [details] [review]
Bug 24857: Fix simple-quote string

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 441 Martin Renvoize 2021-09-07 14:10:50 UTC
Created attachment 124600 [details] [review]
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 442 Martin Renvoize 2021-09-07 14:10:58 UTC
Created attachment 124601 [details] [review]
Bug 24857: Fix sorting of new syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 443 Martin Renvoize 2021-09-07 14:11:08 UTC
Created attachment 124602 [details] [review]
Bug 24857: Change button text from "Create new" to "New volume"

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 444 Martin Renvoize 2021-09-07 14:11:17 UTC
Created attachment 124603 [details] [review]
Bug 24857: (QA follow-up) Add volume to table settings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 445 Martin Renvoize 2021-09-07 14:11:24 UTC
Created attachment 124604 [details] [review]
Bug 24857: (QA follow-up) Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 446 Martin Renvoize 2021-09-07 14:11:32 UTC
Created attachment 124605 [details] [review]
Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 447 Martin Renvoize 2021-09-07 14:11:40 UTC
Created attachment 124606 [details] [review]
Bug 24857: (QA follow-up) Fix QA script issues

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 448 Martin Renvoize 2021-09-07 14:11:47 UTC
Created attachment 124607 [details] [review]
Bug 24857: (follow-up) Use $c->unhandled_exception

This patch makes the controller up to date with the currently used style
and codebase.

It also sinlences a useless warning, and makes it return 404 (instead of
409) when trying to add items to a volume on a non-existing biblio.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Some warnings
2. Apply this patch
3. Repeat 1
=> SUCCESS: No errors, no warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 449 Martin Renvoize 2021-09-07 14:11:55 UTC
Created attachment 124608 [details] [review]
Bug 24857: Use $c->objects->find

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 450 Martin Renvoize 2021-09-07 14:12:02 UTC
Created attachment 124609 [details] [review]
Bug 24857: Fix permissions in spec

This patch corrects the spec so it requires the right permissions.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 451 Martin Renvoize 2021-09-07 14:12:09 UTC
Created attachment 124610 [details] [review]
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio

I noticed some tests included /biblios/{biblio_id}/volumes... in the
URL. And they passed :-D This means the biblio_id is never tested.

This patch fixes those two tests so they have valid biblio_id in the
path, and adds a proper regression test for the expected behavior (409).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Notice the tests pass, even with bad data on the request
2. Apply this patch, notice a test is added for the bad biblio_id case
   and the other two tests are fixed so they have the intended
   biblio_id.
3. Repeat 1
=> SUCCESS: Tests pass! This means things are correctly tested in the
   controller and the unit tests cover teh 'bad case' returning 409.
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 452 Martin Renvoize 2021-09-07 14:12:16 UTC
Created attachment 124611 [details] [review]
Bug 24857: (QA follow-up) Further spec fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 453 Martin Renvoize 2021-09-07 14:12:24 UTC
Created attachment 124612 [details] [review]
Bug 24857: Rename Volumes => Item groups (DB)

This patch renames Volumes => Item groups in the DB structure, and also
on permissions and sysprefs.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 454 Martin Renvoize 2021-09-07 14:12:31 UTC
Created attachment 124613 [details] [review]
Bug 24857: Adapt code to the volumes => item_groups change

This patch updates the code so all references to 'volumes' are
translated into 'item groups'.

Relevant changes:
- API routes and specs
- Permission name is changed
- Syspref name changed

Note: I removed a behavior that felt unnatural (at least in the place it
was put): deleting the item group if the linked item is deleted. It
feels like a controller thing, and also something that could be offered
to the staff on the UI on item deletion. To avoid blocking the feature,
I suggest this removal, and discuss it in its own context.

To test:
1. Run:
   $ reset_all
2. Apply this patchset
3. Run:
   $ updatedatabase
=> SUCCESS: Update works
4. Repeat 1 (with the patches applied)
=> SUCCESS: Install works with this DB structure
5. Run all the tests:
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> SUCCESS: Tests pass!
6. Follow the original plan (with the Volume=>ItemGRoup change in mind)
=> SUCCESS: All good!
7. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 455 Martin Renvoize 2021-09-07 14:12:40 UTC
Created attachment 124614 [details] [review]
Bug 24857: item_group_items.item_id must be unique

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 456 Martin Renvoize 2021-09-07 14:12:48 UTC
Created attachment 124615 [details] [review]
Bug 24857: Do not depend on bug 28883

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 457 Martin Renvoize 2021-09-07 14:18:21 UTC
That was quite a QA effort.. all works as expected, though I'm sure some future polishing of the UI is likely to take place down the line.

Tests pass, QA script is happy and functionality works

Passing QA
Comment 458 Ere Maijala 2021-09-16 12:10:41 UTC
Just to raise awareness: It seems to me that this overlaps the holdings record functionality in bug 20447 quite significantly while providing some that the holdings support doesn't yet. While I've not really familiarized myself with what grouped items provide (is there an RFC or other documentation somewhere?), I don't think it makes much sense to have two different methods for grouping items in a bib record. Since this one has already passed QA I assume this one will get merged soon enough, and that means that the future of bug 20447 (to which many people have invested quite a bit, me included) needs to be reconsidered. I wish I had known about this development much sooner. If anyone has further thoughts, I'd welcome discussion.
Comment 459 Jonathan Druart 2021-10-06 09:06:13 UTC
A discussion needs to take place on the status of the different bug reports offering the same or alternative to this patch set.

Bug 24023 - Add ability to create bundles of items
Bug 20447 - Add support for MARC holdings records
Bug 28854 - [ALTERNATIVE] Add ability to create bundles of items

It's not clear to me and I won't have time to spend on this huge task before the release. 
Bug 20447 has been part of the roadmap for the 2 last dev cycles and it would be weird to make this one passed before the "MARC holdings records" if they conflict with each other.
Comment 460 Nick Clemens 2021-12-14 14:32:50 UTC
(In reply to Jonathan Druart from comment #459)
> A discussion needs to take place on the status of the different bug reports
> offering the same or alternative to this patch set.
> 
> Bug 24023 - Add ability to create bundles of items
> Bug 20447 - Add support for MARC holdings records
> Bug 28854 - [ALTERNATIVE] Add ability to create bundles of items
> 
> It's not clear to me and I won't have time to spend on this huge task before
> the release. 
> Bug 20447 has been part of the roadmap for the 2 last dev cycles and it
> would be weird to make this one passed before the "MARC holdings records" if
> they conflict with each other.

While these patch sets all have similar functions, I don't believe they are contradictory:
This bug creates groups for holds functionality, i.e. holds one any of a 'volume' set - it is a logical grouping only
Bug 24023/28854 are 'bundles' for circulation purposes
Bug 20447 is tied to MARC import/export

While there may be some overlap, I think these are discrete enough to operate independently - a library would likely only want to implement either 'groups' or 'holdings' and I believe they can stand alone
Comment 461 Jonathan Druart 2021-12-14 14:49:46 UTC
No discussion but wait for another RM. Ok, if you want, that's a technique...
Comment 462 Fridolin Somers 2022-01-15 05:43:26 UTC
What a complex situation.

This also linked to Bug 15516 - Allow to place a hold on first available item from a group of titles
And maybe a bit to Bug 15565 - Place multiple item-level holds at once for the same record

Holds system is already really complex, we must be careful what we add in it.
Comment 463 Nick Clemens 2022-03-08 12:41:27 UTC
Created attachment 131449 [details] [review]
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission
Comment 464 Nick Clemens 2022-03-08 12:41:37 UTC
Created attachment 131450 [details] [review]
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 465 Nick Clemens 2022-03-08 12:41:46 UTC
Created attachment 131451 [details] [review]
Bug 24857: DO NOT PUSH: Schema changes
Comment 466 Nick Clemens 2022-03-08 12:41:56 UTC
Created attachment 131452 [details] [review]
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t
Comment 467 Nick Clemens 2022-03-08 12:42:07 UTC
Created attachment 131453 [details] [review]
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t
Comment 468 Nick Clemens 2022-03-08 12:42:15 UTC
Created attachment 131454 [details] [review]
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items
Comment 469 Nick Clemens 2022-03-08 12:42:23 UTC
Created attachment 131455 [details] [review]
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved
Comment 470 Nick Clemens 2022-03-08 12:42:32 UTC
Created attachment 131456 [details] [review]
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 471 Nick Clemens 2022-03-08 12:43:12 UTC
Patches rebased and squashed
Comment 472 Nick Clemens 2022-04-28 18:27:00 UTC
Created attachment 134288 [details] [review]
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission
Comment 473 Nick Clemens 2022-04-28 18:27:22 UTC
Created attachment 134289 [details] [review]
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 474 Nick Clemens 2022-04-28 18:27:33 UTC
Created attachment 134290 [details] [review]
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t
Comment 475 Nick Clemens 2022-04-28 18:27:42 UTC
Created attachment 134291 [details] [review]
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t
Comment 476 Nick Clemens 2022-04-28 18:27:51 UTC
Created attachment 134292 [details] [review]
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items
Comment 477 Nick Clemens 2022-04-28 18:28:01 UTC
Created attachment 134293 [details] [review]
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved
Comment 478 Nick Clemens 2022-04-28 18:28:11 UTC
Created attachment 134294 [details] [review]
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 479 Nick Clemens 2022-04-28 18:28:20 UTC
Created attachment 134295 [details] [review]
Bug 24857: DO NOT PUSH: Schema changes
Comment 480 Nick Clemens 2022-04-28 18:28:30 UTC
Created attachment 134296 [details] [review]
Bug 24857: Add object classes to Schema
Comment 481 Fridolin Somers 2022-04-28 19:22:13 UTC
I don't understand enough this feature and its links with other features.
So I've chosen to pass it to next Release Manager.
Great work ByWaters.
Comment 482 Kyle M Hall 2022-06-02 16:20:35 UTC
Created attachment 135590 [details] [review]
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission
Comment 483 Kyle M Hall 2022-06-02 16:21:03 UTC
Created attachment 135591 [details] [review]
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission
Comment 484 Kyle M Hall 2022-06-02 16:21:21 UTC
Created attachment 135592 [details] [review]
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 485 Kyle M Hall 2022-06-02 16:21:30 UTC
Created attachment 135593 [details] [review]
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t
Comment 486 Kyle M Hall 2022-06-02 16:21:39 UTC
Created attachment 135594 [details] [review]
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t
Comment 487 Kyle M Hall 2022-06-02 16:21:48 UTC
Created attachment 135595 [details] [review]
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items
Comment 488 Kyle M Hall 2022-06-02 16:21:58 UTC
Created attachment 135596 [details] [review]
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved
Comment 489 Kyle M Hall 2022-06-02 16:22:07 UTC
Created attachment 135597 [details] [review]
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 490 Kyle M Hall 2022-06-02 16:22:18 UTC
Created attachment 135598 [details] [review]
Bug 24857: Add new Schema files
Comment 491 Kyle M Hall 2022-06-02 16:22:30 UTC
Created attachment 135599 [details] [review]
Bug 24857: Add object classes to Schema
Comment 492 Kyle M Hall 2022-06-02 16:22:45 UTC
Created attachment 135600 [details] [review]
Bug 24857: DO NOT PUSH: Schema changes
Comment 493 Kyle M Hall 2022-06-02 16:27:58 UTC
Created attachment 135601 [details] [review]
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission

https://bugs.koha-community.org/show_bug.cgi?id=24860
Comment 494 Kyle M Hall 2022-06-02 16:28:17 UTC
Created attachment 135602 [details] [review]
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 495 Kyle M Hall 2022-06-02 16:28:28 UTC
Created attachment 135603 [details] [review]
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t
Comment 496 Kyle M Hall 2022-06-02 16:28:38 UTC
Created attachment 135604 [details] [review]
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t
Comment 497 Kyle M Hall 2022-06-02 16:28:49 UTC
Created attachment 135605 [details] [review]
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items
Comment 498 Kyle M Hall 2022-06-02 16:28:57 UTC
Created attachment 135606 [details] [review]
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved
Comment 499 Kyle M Hall 2022-06-02 16:29:05 UTC
Created attachment 135607 [details] [review]
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 500 Kyle M Hall 2022-06-02 16:29:14 UTC
Created attachment 135608 [details] [review]
Bug 24857: Add new Schema files
Comment 501 Kyle M Hall 2022-06-02 16:29:22 UTC
Created attachment 135609 [details] [review]
Bug 24857: Add object classes to Schema
Comment 502 Kyle M Hall 2022-06-02 16:29:30 UTC
Created attachment 135610 [details] [review]
Bug 24857: DO NOT PUSH: Schema changes
Comment 503 Kyle M Hall 2022-06-02 18:21:42 UTC
Created attachment 135614 [details] [review]
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission

https://bugs.koha-community.org/show_bug.cgi?id=24860
Comment 504 Kyle M Hall 2022-06-02 18:22:03 UTC
Created attachment 135615 [details] [review]
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 505 Kyle M Hall 2022-06-02 18:22:13 UTC
Created attachment 135616 [details] [review]
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t
Comment 506 Kyle M Hall 2022-06-02 18:22:22 UTC
Created attachment 135617 [details] [review]
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t
Comment 507 Kyle M Hall 2022-06-02 18:22:31 UTC
Created attachment 135618 [details] [review]
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items
Comment 508 Kyle M Hall 2022-06-02 18:22:39 UTC
Created attachment 135619 [details] [review]
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved
Comment 509 Kyle M Hall 2022-06-02 18:22:47 UTC
Created attachment 135620 [details] [review]
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 510 Kyle M Hall 2022-06-02 18:22:56 UTC
Created attachment 135621 [details] [review]
Bug 24857: Add new Schema files
Comment 511 Kyle M Hall 2022-06-02 18:23:04 UTC
Created attachment 135622 [details] [review]
Bug 24857: Add object classes to Schema
Comment 512 Kyle M Hall 2022-06-02 18:23:12 UTC
Created attachment 135623 [details] [review]
Bug 24857: DO NOT PUSH: Schema changes
Comment 513 Kyle M Hall 2022-06-02 18:34:01 UTC
Created attachment 135624 [details] [review]
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items
Comment 514 Kyle M Hall 2022-06-02 18:34:21 UTC
Created attachment 135625 [details] [review]
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved
Comment 515 Kyle M Hall 2022-06-02 18:34:31 UTC
Created attachment 135626 [details] [review]
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 516 Kyle M Hall 2022-06-02 18:34:40 UTC
Created attachment 135627 [details] [review]
Bug 24857: Add new Schema files
Comment 517 Kyle M Hall 2022-06-02 18:34:49 UTC
Created attachment 135628 [details] [review]
Bug 24857: Add object classes to Schema
Comment 518 Kyle M Hall 2022-06-02 18:34:58 UTC
Created attachment 135629 [details] [review]
Bug 24857: DO NOT PUSH: Schema changes
Comment 519 Kyle M Hall 2022-07-07 11:04:27 UTC
Created attachment 137259 [details] [review]
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission

https://bugs.koha-community.org/show_bug.cgi?id=24860
Comment 520 Kyle M Hall 2022-07-07 11:04:47 UTC
Created attachment 137260 [details] [review]
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 521 Kyle M Hall 2022-07-07 11:04:56 UTC
Created attachment 137261 [details] [review]
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t
Comment 522 Kyle M Hall 2022-07-07 11:05:04 UTC
Created attachment 137262 [details] [review]
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t
Comment 523 Kyle M Hall 2022-07-07 11:05:13 UTC
Created attachment 137263 [details] [review]
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items
Comment 524 Kyle M Hall 2022-07-07 11:05:23 UTC
Created attachment 137264 [details] [review]
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved
Comment 525 Kyle M Hall 2022-07-07 11:05:32 UTC
Created attachment 137265 [details] [review]
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 526 Kyle M Hall 2022-07-07 11:05:41 UTC
Created attachment 137266 [details] [review]
Bug 24857: Add new Schema files
Comment 527 Kyle M Hall 2022-07-07 11:05:49 UTC
Created attachment 137267 [details] [review]
Bug 24857: Add object classes to Schema
Comment 528 Kyle M Hall 2022-07-07 11:05:57 UTC
Created attachment 137268 [details] [review]
Bug 24857: DO NOT PUSH: Schema changes
Comment 529 Tomás Cohen Arazi 2022-07-07 14:04:26 UTC
Created attachment 137311 [details] [review]
Bug 24857: Fix rebase problems

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 530 Kyle M Hall 2022-07-07 14:48:46 UTC
Created attachment 137314 [details] [review]
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission

https://bugs.koha-community.org/show_bug.cgi?id=24860
Comment 531 Kyle M Hall 2022-07-07 14:49:06 UTC
Created attachment 137315 [details] [review]
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 532 Kyle M Hall 2022-07-07 14:49:14 UTC
Created attachment 137316 [details] [review]
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t
Comment 533 Kyle M Hall 2022-07-07 14:49:22 UTC
Created attachment 137317 [details] [review]
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t
Comment 534 Kyle M Hall 2022-07-07 14:49:30 UTC
Created attachment 137318 [details] [review]
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items
Comment 535 Kyle M Hall 2022-07-07 14:49:38 UTC
Created attachment 137319 [details] [review]
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved
Comment 536 Kyle M Hall 2022-07-07 14:49:46 UTC
Created attachment 137320 [details] [review]
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t
Comment 537 Kyle M Hall 2022-07-07 14:49:55 UTC
Created attachment 137321 [details] [review]
Bug 24857: Add new Schema files
Comment 538 Kyle M Hall 2022-07-07 14:50:04 UTC
Created attachment 137322 [details] [review]
Bug 24857: Add object classes to Schema
Comment 539 Kyle M Hall 2022-07-07 14:50:14 UTC
Created attachment 137323 [details] [review]
Bug 24857: DO NOT PUSH: Schema changes
Comment 540 Tomás Cohen Arazi 2022-07-08 19:32:44 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 541 Tomás Cohen Arazi 2022-07-08 22:10:23 UTC
Created attachment 137441 [details] [review]
Bug 24857: (QA follow-up) Make update idempotent

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 542 Tomás Cohen Arazi 2022-07-08 22:11:58 UTC
Created attachment 137442 [details] [review]
Bug 24857: Fix missing additionalProperties in spec

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 543 Tomás Cohen Arazi 2022-07-08 23:29:50 UTC
Created attachment 137443 [details] [review]
Bug 24857: Remove incorrect object_class method

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 544 Jonathan Druart 2022-07-12 07:39:36 UTC
Created attachment 137608 [details] [review]
Bug 24857: Remove object_class from singular classes

Fixes
Can't use string ("Koha::Biblio::ItemGroup") as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/Object.pm line 830.
Can't use string ("Koha::Biblio::ItemGroup::Item") as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/Object.pm line 830.
Comment 545 Tomás Cohen Arazi 2022-08-09 16:57:36 UTC
Created attachment 138933 [details] [review]
Bug 24857: (QA follow-up) Add spec description

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 546 Lucas Gass 2022-08-23 15:33:24 UTC
No backport for 22.05.x
Comment 547 David Cook 2024-02-12 23:12:47 UTC
I'm starting to look at this and it looks like a similar idea to bug 15516 except that it's the library creating the group rather than the patron.

I wonder if bug 15516 could be re-implemented as a item_group. Maybe we could add a column to differentiate between staff-added and user-added item groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see...
Comment 548 Katrin Fischer 2024-02-12 23:15:59 UTC
(In reply to David Cook from comment #547)
> I'm starting to look at this and it looks like a similar idea to bug 15516
> except that it's the library creating the group rather than the patron.
> 
> I wonder if bug 15516 could be re-implemented as a item_group. Maybe we
> could add a column to differentiate between staff-added and user-added item
> groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see...

There is another major different: item groups group items from the same record. The point of 15526 I think is creating groups with items from different records (I don't care if I get the movie, the paperback, the hardcover...)
Comment 549 David Cook 2024-02-13 00:38:15 UTC
(In reply to Katrin Fischer from comment #548)
> (In reply to David Cook from comment #547)
> > I'm starting to look at this and it looks like a similar idea to bug 15516
> > except that it's the library creating the group rather than the patron.
> > 
> > I wonder if bug 15516 could be re-implemented as a item_group. Maybe we
> > could add a column to differentiate between staff-added and user-added item
> > groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see...
> 
> There is another major different: item groups group items from the same
> record. The point of 15526 I think is creating groups with items from
> different records (I don't care if I get the movie, the paperback, the
> hardcover...)

Hmm that could be. It's been a while since I looked at a live implementation or the code. I'll be looking at it very shortly so I guess I'll see!
Comment 550 David Cook 2024-02-13 02:48:54 UTC
(In reply to Katrin Fischer from comment #548)
> There is another major different: item groups group items from the same
> record. The point of 15526 I think is creating groups with items from
> different records (I don't care if I get the movie, the paperback, the
> hardcover...)

I've just finished rebasing and doing some testing...

With bug 15516 alone, it creates hold groups using record-level or item-level holds from different records. 

However, when bug 15516 and bug 15565 are combined, then you can do hold groups for items within the same bib record as well. 

For now, on Bugzilla, I'm trying to keep the two bug reports separate. Locally, I join them together.