Summary: | Circulation.t fails if "RenewalPeriodBase" is set as "the current date" | ||
---|---|---|---|
Product: | Koha | Reporter: | Emmi Takkinen <emmi.takkinen> |
Component: | Test Suite | Assignee: | Emmi Takkinen <emmi.takkinen> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Bug 31493: Prevent Circulation.t failing on "AddRenewal left both fines" |
Description
Emmi Takkinen
2022-08-31 08:33:16 UTC
Created attachment 139995 [details] [review] Bug 31493: Prevent Circulation.t failing on "AddRenewal left both fines" If one has syspref "RenewalPeriodBase" set as "the current date" Circulation.t tests fail on "AddRenewal left both fines". This causes one of the test fines to be dropped/charged. Mocking syspref "RenewalPeriodBase" as "the old due date of the checkout" solves the issue. To test: 1. Have syspref "RenewalPeriodBase" set as "the current date". 2. Run prove t/db_dependent/Circulation.t. => Tests fail. 3. Apply patch. 4. Run tests again. => Tests pass. Sponsored-by: Koha-Suomi Oy Tests are passing for me without the patch, can you have another look please? |