Like in bug 26405 Circulation.t fails on the following error: t/db_dependent/Circulation.t .. 15/63 # Failed test 'AddRenewal left both fines' # at t/db_dependent/Circulation.t line 770. # got: '1' # expected: '2' # Looks like you planned 105 tests but ran 30. # Looks like you failed 1 test of 30 run. t/db_dependent/Circulation.t .. 17/63 # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 1538. Can't call method "status" on an undefined value at t/db_dependent/Circulation.t line 772. Apparently this is happens when syspref "RenewalPeriodBase" is set as "the current date".
Created attachment 139995 [details] [review] Bug 31493: Prevent Circulation.t failing on "AddRenewal left both fines" If one has syspref "RenewalPeriodBase" set as "the current date" Circulation.t tests fail on "AddRenewal left both fines". This causes one of the test fines to be dropped/charged. Mocking syspref "RenewalPeriodBase" as "the old due date of the checkout" solves the issue. To test: 1. Have syspref "RenewalPeriodBase" set as "the current date". 2. Run prove t/db_dependent/Circulation.t. => Tests fail. 3. Apply patch. 4. Run tests again. => Tests pass. Sponsored-by: Koha-Suomi Oy
Tests are passing for me without the patch, can you have another look please?
Might have been fixed by bug 31676. *** This bug has been marked as a duplicate of bug 31676 ***