Summary: | Diff view on manage staged imports page is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | MARC Bibliographic data support | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | lucas, m.de.rooy, martin.renvoize |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 31526: Follow-up for bug 29697
Bug 31526: Follow-up for bug 29697 Bug 31526: Follow-up for bug 29697 |
Description
Katrin Fischer
2022-09-07 09:16:08 UTC
To test: * Export a record with ISBN from your catalog (Save as MARC) * Stage it using the ISBN matching rule (make sure it matched) * Manage staged import and click on the Diff link Created attachment 140561 [details] [review] Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. Created attachment 140565 [details] [review] Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 140696 [details] [review] Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> This kind of fixes should not stay too long in NSO or SO. I would even have recommended to move it to PQA directly, Martin. The RM will still see it. Anyway thanks for the fix. Pushed to master for 22.11. Nice work everyone, thanks! |