After importing a record that matched with an existing record, the Diff link is visible in the table of imported records. Clicking on it gives an error: Not a CODE reference at /kohadevbox/koha/tools/showdiffmarc.pl line 65 in (eval) at /kohadevbox/koha/tools/showdiffmarc.pl line 65 62: 63: if ( $type eq 'biblio' ) { 64: my $biblio = Koha::Biblios->find( $recordid ); 65: $record = $biblio->metadata->record->({ embed_items => 1 }); 66: $recordTitle = $biblio->title; 67: } 68: elsif ( $type eq 'auth' ) {
To test: * Export a record with ISBN from your catalog (Save as MARC) * Stage it using the ISBN matching rule (make sure it matched) * Manage staged import and click on the Diff link
Created attachment 140561 [details] [review] Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again.
Created attachment 140565 [details] [review] Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 140696 [details] [review] Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This kind of fixes should not stay too long in NSO or SO. I would even have recommended to move it to PQA directly, Martin. The RM will still see it. Anyway thanks for the fix.
Pushed to master for 22.11. Nice work everyone, thanks!