Summary: | HTML tags in TT comments in patron-search.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | arthur.suzuki, caroline.cyr-la-rose, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.07
|
|
Circulation function: | |||
Bug Depends on: | 30063 | ||
Bug Blocks: | |||
Attachments: |
Bug 31530: Remove HTML tags in TT comments in patron-search.inc
Bug 31530: Remove HTML tags in TT comments in patron-search.inc Bug 31530: Remove HTML tags in TT comments in patron-search.inc |
Description
Fridolin Somers
2022-09-07 20:43:36 UTC
Created attachment 140327 [details] [review] Bug 31530: Remove HTML tags in TT comments in patron-search.inc Created attachment 140328 [details] [review] Bug 31530: Remove HTML tags in TT comments in patron-search.inc Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> To test: 1) Without patch, search for patron-search.inc in misc/translator/po/xx-XX-staff-prog.po --> There should be strings with pound signs such as "%%] %s [%%# - branch: " 2) Apply patch 3) Update translation files `translate update xx-XX` 4) Search again for patron-search.inc in misc/translator/po/xx-XX-staff-prog.po --> The problematic strings are not there anymore 5) In the staff interface, go to Patrons, the search box and search function should be unchanged Thanks Fridolin! I added a test plan, just in case... Thanks a lot ;) Created attachment 140399 [details] [review] Bug 31530: Remove HTML tags in TT comments in patron-search.inc Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> To test: 1) Without patch, search for patron-search.inc in misc/translator/po/xx-XX-staff-prog.po --> There should be strings with pound signs such as "%%] %s [%%# - branch: " 2) Apply patch 3) Update translation files `translate update xx-XX` 4) Search again for patron-search.inc in misc/translator/po/xx-XX-staff-prog.po --> The problematic strings are not there anymore 5) In the staff interface, go to Patrons, the search box and search function should be unchanged Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.07 release depends on 30063, can't backport on 21.11.x |