In patron-search.inc there is a TT comment block using <xxx>, this can be confused with real HTML tags. It shows in translation strings. I propose to use simple text.
Created attachment 140327 [details] [review] Bug 31530: Remove HTML tags in TT comments in patron-search.inc
Created attachment 140328 [details] [review] Bug 31530: Remove HTML tags in TT comments in patron-search.inc Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> To test: 1) Without patch, search for patron-search.inc in misc/translator/po/xx-XX-staff-prog.po --> There should be strings with pound signs such as "%%] %s [%%# - branch: " 2) Apply patch 3) Update translation files `translate update xx-XX` 4) Search again for patron-search.inc in misc/translator/po/xx-XX-staff-prog.po --> The problematic strings are not there anymore 5) In the staff interface, go to Patrons, the search box and search function should be unchanged
Thanks Fridolin! I added a test plan, just in case...
Thanks a lot ;)
Created attachment 140399 [details] [review] Bug 31530: Remove HTML tags in TT comments in patron-search.inc Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> To test: 1) Without patch, search for patron-search.inc in misc/translator/po/xx-XX-staff-prog.po --> There should be strings with pound signs such as "%%] %s [%%# - branch: " 2) Apply patch 3) Update translation files `translate update xx-XX` 4) Search again for patron-search.inc in misc/translator/po/xx-XX-staff-prog.po --> The problematic strings are not there anymore 5) In the staff interface, go to Patrons, the search box and search function should be unchanged Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.07 release
depends on 30063, can't backport on 21.11.x