| Summary: | Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Component: | Searching - Elasticsearch | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 28830 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml
Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml |
||
|
Description
Caroline Cyr La Rose
2022-09-08 15:51:57 UTC
Created attachment 140351 [details] [review] Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml This patch removes one of the two mappings for the 003 field to the control-number-identifier index (for MARC21). To test: 1) Apply patch 2) reindex with mappings reset 3) try to search for cni:code (for example cni:OSt) --> it should return the desired results 4) try to search for control-number-identifier:code (for example control-number-identifier:OSt) --> it should return the desired results 5) Optionally, try the test plan in Bug 11175 to make sure it still works (In reply to Caroline Cyr La Rose from comment #0) > If it's not necessary that it be there twice, I propose we remove it. I mean, remove one of the two! Created attachment 140355 [details] [review] Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml This patch removes one of the two mappings for the 003 field to the control-number-identifier index (for MARC21). To test: 1) Apply patch 2) reindex with mappings reset 3) try to search for cni:code (for example cni:OSt) --> it should return the desired results 4) try to search for control-number-identifier:code (for example control-number-identifier:OSt) --> it should return the desired results 5) Optionally, try the test plan in Bug 11175 to make sure it still works Signed-off-by: David Nind <david@davidnind.com> Testing notes (using koha-testing-docker): - Followed the test plan, but didn't do optional step 5. Created attachment 140398 [details] [review] Bug 31537: Elasticsearch - index mapping for 003 control-number-identifier is twice in mappings.yaml This patch removes one of the two mappings for the 003 field to the control-number-identifier index (for MARC21). To test: 1) Apply patch 2) reindex with mappings reset 3) try to search for cni:code (for example cni:OSt) --> it should return the desired results 4) try to search for control-number-identifier:code (for example control-number-identifier:OSt) --> it should return the desired results 5) Optionally, try the test plan in Bug 11175 to make sure it still works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Stared at this quite a while, wondering if one would be the definition for authorities - but it isn't, just a double up. (In reply to Katrin Fischer from comment #6) > Stared at this quite a while, wondering if one would be the definition for > authorities - but it isn't, just a double up. Yeah, me too! Pushed to master for 22.11. Nice work everyone, thanks! |