We ought to have a cni index to allow searching on the content of the 003 marc field for accurate linking using UseControlNumber type searches.
Created attachment 123616 [details] [review] Bug 28830: Add cni index for 003 This patch adds the cni/Control-number-identifier index to enable searches to use the 003 field. Test plan 1/ Apply patch 2/ Re-index using updated configurations 3/ Confirm cni:number searches yield the expected results 4/ Signoff Split-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This patch was split out of bug 11175 to allow it to be a dependanchy of other bugs without risking hold ups whilst 11175 makes it way through QA. Signoffs carried across from that bug.
Kind of wondering, why it took us THAT long to add this!
I checked the LOC documentation, but it appears there is no standard attribute for 003, so using 9014 is fine (https://www.loc.gov/z3950/agency/bib1.html) Martin, could you please add the indexing changes for Elasticsearch in a follow-up?
Created attachment 123697 [details] [review] Bug 28830: Add cni index for 003 This patch adds the cni/Control-number-identifier index to enable searches to use the 003 field. Test plan 1/ Apply patch 2/ Re-index using updated configurations 3/ Confirm cni:number searches yield the expected results 4/ Signoff Split-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch, seems I missed the ES bit from the other bug.. added into the patch :)
Created attachment 123920 [details] [review] Bug 28830: Add cni index for 003 This patch adds the cni/Control-number-identifier index to enable searches to use the 003 field. Test plan 1/ Apply patch 2/ Re-index using updated configurations 3/ Confirm cni:number searches yield the expected results 4/ Signoff Split-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!