Bug 31538

Summary:	Crash on item tab of a record with UNIMARC
Product:	Koha	Reporter:	Victor Grousset/tuxayo <victor>
Component:	Staff interface	Assignee:	Bugs List <koha-bugs>
Status:	CLOSED INVALID	QA Contact:	Testopia <testopia>
Severity:	blocker
Priority:	P5 - low	CC:	gmcharlt, jonathan.druart, joonas.kylmala
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35896
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Victor Grousset/tuxayo 2022-09-08 16:38:59 UTC

== test plan ==
1. start a UNIMARC Koha with sample data
2. search for any record
3. go to item tab
4. error Can't call method "notforloan" on an undefined value at /kohadevbox/koha/catalogue/moredetail.pl line 189

Comment 1 Joonas Kylmälä 2022-09-08 17:23:30 UTC Comment hidden (obsolete)

I cannot get any biblio to show even, or search for them with kohadevbox and after having ran "reset_all_unimarc".

Comment 2 Joonas Kylmälä 2022-09-08 19:08:49 UTC

We are not checking whether the item in question has an itemtype. Need to add a check for that. Patch coming right up.

Comment 3 Joonas Kylmälä 2022-09-08 19:33:25 UTC

Actually, do we require itemtypes? If not, then at least the regression is caused by 

Bug 24185: Make holds page faster: Preparatory refactoring

>+ Koha::ItemTypes->find( $i->effective_itemtype() )->notforloan

and bug 27272 related dependencies.

Comment 4 Joonas Kylmälä 2022-09-08 19:48:29 UTC

So after grepping for Koha::ItemTypes->find I can see almost all places in Koha expect there to be an itemtype to be defined. Koha just doesn't want to work without itemtypes, and for some reason the unimarc default data seems to come without itemtypes linked to the items. Putting back to NEW status. Need to discuss first how to proceed.

Comment 5 Joonas Kylmälä 2022-09-08 19:49:39 UTC

Unfortunately we don't seem to have foreign key constraint from items table to itemtypes table, so these errors are bound to happen.

Comment 6 Victor Grousset/tuxayo 2022-09-16 00:23:39 UTC

Thanks for the analysis :)

> unimarc default data

Is that just about sample data that is inserted directly via SQL? Or is that something that valid UI usage can produce?

Comment 7 Jonathan Druart 2022-11-11 12:13:08 UTC

This looks like a data problem from misc4dev. You should report the problem there (which I won't fix myself however).

Comment 8 Victor Grousset/tuxayo 2024-04-12 11:48:03 UTC

For anyone coming here, the problem has been reported in this ticket

gitlab DOT com/koha-community/koha-misc4dev/-/issues/76