When there is an item without itemtype the OPAC detail page explodes:
Can't call method "itemtype" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl line 713
I know we agreed not to fix this everywhere, but I think there is definitely a need to fix it in this very spot, because it's on a main page in the OPAC.
One thing that can cause this: We just very recently made itemtype mandatory on the acq item form. On order items often had no itemtypes in the past and it was not a problem. Libraries would assign the itemtype on delivery/receive, avoiding any issues in circulation. There might be quite a lot of those 'in the wild'.
Closely related to Bug 21842 that has been closed with wont fix.
I'd be happy to reopen it ;)
Not that close... we agreed on not always checking - but this is the end user exploding pages.
(In reply to Katrin Fischer from comment #2)
> Not that close... we agreed on not always checking - but this is the end
> user exploding pages.
Indeed, OPAC should be bulletproof ^^
This is caused by data inconsistencies, there is a script to catch them. We should not fix that IMO.
(In reply to Fridolin Somers from comment #3)
> (In reply to Katrin Fischer from comment #2)
> > Not that close... we agreed on not always checking - but this is the end
> > user exploding pages.
> Indeed, OPAC should be bulletproof ^^
No, data should be correct. We provide a script that must be run when data is migrated. Then it's no longer possible to break it using the UI (unless you mess with the config).
Koha does only have a recent history of enforcing the itemtype as a mandatory field. We have tried to get libraries to fix things, but it's not an easy process. Especially as the acq form didn't have it mandatory until ... last release?
The data inconsistencies script is fine for migrations, but libraries using Koha for a long while don't know about it.
This is what I think, being a bit more lenient... but I guess you got a point too.
*** Bug 33351 has been marked as a duplicate of this bug. ***
Looks like Pierre Chalon is reproducing this out of the box on PTFS Europe and BibLibre's sandboxes.