| Summary: | SIP2 option format_due_date not honored for AH field in item information response | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | SIP2 | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, lucas, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.08, 21.11.15
|
|
| Circulation function: | |||
| Bug Depends on: | 28730 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 31552: SIP2 option format_due_date not honored for AH field in item information response
Bug 31552: SIP2 option format_due_date not honored for AH field in item information response Bug 31552: SIP2 option format_due_date not honored for AH field in item information response |
||
|
Description
Kyle M Hall (khall)
2022-09-12 17:52:16 UTC
Created attachment 140486 [details] [review] Bug 31552: SIP2 option format_due_date not honored for AH field in item information response Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Created attachment 140487 [details] [review] Bug 31552: SIP2 option format_due_date not honored for AH field in item information response Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david@davidnind.com> Thanks for the quick SO David! It looks like instead of adding a test for the fixed behviour this patch actually removes the test. Kyle, can you please provide a test for the formatted due date? Sorry, something is odd with my setup today - test was added (added lines in red, terminal, really?) Created attachment 141496 [details] [review] Bug 31552: SIP2 option format_due_date not honored for AH field in item information response Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.08 applied to 21.11 for 21.11.15 Not backported to 21.05.x |