Bug 31552 - SIP2 option format_due_date not honored for AH field in item information response
Summary: SIP2 option format_due_date not honored for AH field in item information resp...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
Depends on: 28730
Blocks:
  Show dependency tree / graph
 
Reported: 2022-09-12 17:52 UTC by Kyle M Hall (khall)
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15
Circulation function:

Attachments
Bug 31552: SIP2 option format_due_date not honored for AH field in item information response (4.04 KB, patch)
2022-09-12 17:53 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 31552: SIP2 option format_due_date not honored for AH field in item information response (4.09 KB, patch)
2022-09-12 17:57 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31552: SIP2 option format_due_date not honored for AH field in item information response (4.14 KB, patch)
2022-10-07 11:55 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2022-09-12 17:52:16 UTC 
Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response.
Comment 1 Kyle M Hall (khall) 2022-09-12 17:53:30 UTC 
Created attachment 140486 [details] [review]
Bug 31552: SIP2 option format_due_date not honored for AH field in item information response

Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t
Comment 2 David Nind 2022-09-12 17:57:30 UTC 
Created attachment 140487 [details] [review]
Bug 31552: SIP2 option format_due_date not honored for AH field in item information response

Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Kyle M Hall (khall) 2022-09-12 18:13:33 UTC 
Thanks for the quick SO David!
Comment 4 Katrin Fischer 2022-10-07 11:34:58 UTC 
It looks like instead of adding a test for the fixed behviour this patch actually removes the test. Kyle, can you please provide a test for the formatted due date?
Comment 5 Katrin Fischer 2022-10-07 11:36:43 UTC 
Sorry, something is odd with my setup today - test was added (added lines in red, terminal, really?)
Comment 6 Katrin Fischer 2022-10-07 11:55:05 UTC 
Created attachment 141496 [details] [review]
Bug 31552: SIP2 option format_due_date not honored for AH field in item information response

Bug 28730 added the ability to format due dates based on Koha's date format, but missed formatting the due date field in the item information response.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 7 Tomás Cohen Arazi (tcohen) 2022-10-12 18:00:08 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass (lukeg) 2022-12-05 18:54:10 UTC 
Backported to 22.05.x for upcoming 22.05.08
Comment 9 Arthur Suzuki 2022-12-14 15:23:48 UTC 
applied to 21.11 for 21.11.15
Comment 10 Wainui Witika-Park 2023-03-15 00:53:08 UTC 
Not backported to 21.05.x