|
Description
Nick Clemens (kidclamp)
2022-09-14 11:26:53 UTC
Created attachment 140621 [details] [review] Bug 31562: Treat flags as other borrower fields Rather than generate a custom hash for these fields, we should treat them as other borrower data fields To test: 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields 2 - Edit syspref BorrowerunwantedField 3 - Set gonenoaddress and lost as unwanted 4 - Edit patron, the fields remain 5 - Apply patch 6 - Edit a patron, fields are hidden 7 - Unhide one of the fields 8 - Edit a patron and confirm it shows and saves correctly 9 - Unhide the other field 10 - Confirm it can be edited and saved Created attachment 140622 [details] [review] Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences These are not shown, so cannot be unwanted or mandatory Created attachment 140623 [details] [review] Bug 31562: Respect mandatory fields pref To test: 1 - Set gonenoaddress and lost in BorrowerMandatoryField 2 - Edit a patron, confirm fields are required Created attachment 140624 [details] [review] Bug 31562: Treat flags as other borrower fields Rather than generate a custom hash for these fields, we should treat them as other borrower data fields To test: 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields 2 - Edit syspref BorrowerunwantedField 3 - Set gonenoaddress and lost as unwanted 4 - Edit patron, the fields remain 5 - Apply patch 6 - Edit a patron, fields are hidden 7 - Unhide one of the fields 8 - Edit a patron and confirm it shows and saves correctly 9 - Unhide the other field 10 - Confirm it can be edited and saved Created attachment 140625 [details] [review] Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences These are not shown, so cannot be unwanted or mandatory Created attachment 140626 [details] [review] Bug 31562: Respect mandatory fields pref To test: 1 - Set gonenoaddress and lost in BorrowerMandatoryField 2 - Edit a patron, confirm fields are required Created attachment 140638 [details] [review] Bug 31562: Treat flags as other borrower fields Rather than generate a custom hash for these fields, we should treat them as other borrower data fields To test: 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields 2 - Edit syspref BorrowerunwantedField 3 - Set gonenoaddress and lost as unwanted 4 - Edit patron, the fields remain 5 - Apply patch 6 - Edit a patron, fields are hidden 7 - Unhide one of the fields 8 - Edit a patron and confirm it shows and saves correctly 9 - Unhide the other field 10 - Confirm it can be edited and saved Signed-off-by: David Nind <david@davidnind.com> Created attachment 140639 [details] [review] Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences These are not shown, so cannot be unwanted or mandatory Signed-off-by: David Nind <david@davidnind.com> Created attachment 140640 [details] [review] Bug 31562: Respect mandatory fields pref To test: 1 - Set gonenoaddress and lost in BorrowerMandatoryField 2 - Edit a patron, confirm fields are required Signed-off-by: David Nind <david@davidnind.com> Created attachment 140655 [details] [review] Bug 31562: Treat flags as other borrower fields Rather than generate a custom hash for these fields, we should treat them as other borrower data fields To test: 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields 2 - Edit syspref BorrowerunwantedField 3 - Set gonenoaddress and lost as unwanted 4 - Edit patron, the fields remain 5 - Apply patch 6 - Edit a patron, fields are hidden 7 - Unhide one of the fields 8 - Edit a patron and confirm it shows and saves correctly 9 - Unhide the other field 10 - Confirm it can be edited and saved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 140656 [details] [review] Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences These are not shown, so cannot be unwanted or mandatory Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 140657 [details] [review] Bug 31562: Respect mandatory fields pref To test: 1 - Set gonenoaddress and lost in BorrowerMandatoryField 2 - Edit a patron, confirm fields are required Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This all appears to check out to me.. code is a littler clearer too. No QA script failures. Passing QA Pushed to master for 22.11. Nice work everyone, thanks! Patchset won't apply cleanly for 22.05.x. If needed please rebase Created attachment 142858 [details] [review] Bug 31562: [22.05.x] Treat flags as other borrower fields Rather than generate a custom hash for these fields, we should treat them as other borrower data fields To test: 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields 2 - Edit syspref BorrowerunwantedField 3 - Set gonenoaddress and lost as unwanted 4 - Edit patron, the fields remain 5 - Apply patch 6 - Edit a patron, fields are hidden 7 - Unhide one of the fields 8 - Edit a patron and confirm it shows and saves correctly 9 - Unhide the other field 10 - Confirm it can be edited and saved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences These are not shown, so cannot be unwanted or mandatory Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 31562: Respect mandatory fields pref To test: 1 - Set gonenoaddress and lost in BorrowerMandatoryField 2 - Edit a patron, confirm fields are required Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Backported to 22.05.x for the upcoming 22.05.07 release applied to 21.11 for 21.11.14 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. |