Summary: | Remove Text::CSV::Unicode | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | lucas, mtj, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 31590: Remove Text::CSV::Unicode
Bug 31590: Remove Text::CSV::Unicode |
Description
Marcel de Rooy
2022-09-21 12:42:58 UTC
Created attachment 140817 [details] [review] Bug 31590: Remove Text::CSV::Unicode This modules is really not needed. The wide character test does not make much sense. Just use encoding as you should. Test plan: Run xt/author/Text_CSV_Various.t. Check about page, perl modules. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Architectural housekeeping, trivial testing. Self SO Tomas: You might even consider moving this test back to t ? Created attachment 140830 [details] [review] Bug 31590: Remove Text::CSV::Unicode This modules is really not needed. The wide character test does not make much sense. Just use encoding as you should. Test plan: Run xt/author/Text_CSV_Various.t. Check about page, perl modules. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! |