Bug 31590 - Remove Text::CSV::Unicode
Summary: Remove Text::CSV::Unicode
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-21 12:42 UTC by Marcel de Rooy
Modified: 2022-09-21 22:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31590: Remove Text::CSV::Unicode (5.07 KB, patch)
2022-09-21 12:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31590: Remove Text::CSV::Unicode (5.08 KB, patch)
2022-09-21 19:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-09-21 12:42:58 UTC
The use of module Text::CSV::Unicode in xt/author/Text_CSV_Various.t does not make much sense. 
We can just remove it.
It is not packaged for Debian either.

This is just a matter of correctly using encoding in perl.
Comment 1 Marcel de Rooy 2022-09-21 12:59:39 UTC
Created attachment 140817 [details] [review]
Bug 31590: Remove Text::CSV::Unicode

This modules is really not needed.
The wide character test does not make much sense. Just use
encoding as you should.

Test plan:
Run xt/author/Text_CSV_Various.t.
Check about page, perl modules.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2022-09-21 13:00:15 UTC
Architectural housekeeping, trivial testing. Self SO
Comment 3 Marcel de Rooy 2022-09-21 13:24:56 UTC
Tomas: You might even consider moving this test back to t ?
Comment 4 Tomás Cohen Arazi 2022-09-21 19:11:02 UTC
Created attachment 140830 [details] [review]
Bug 31590: Remove Text::CSV::Unicode

This modules is really not needed.
The wide character test does not make much sense. Just use
encoding as you should.

Test plan:
Run xt/author/Text_CSV_Various.t.
Check about page, perl modules.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2022-09-21 22:05:11 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!