Summary: | Improve style of OPAC suggestions search form | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | arthur.suzuki, george, lucas, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.07, 21.11.14
|
|
Circulation function: | |||
Attachments: |
Screenshot showing the current style
Bug 31605: Improve style of OPAC suggestions search form Bug 31605: Improve style of OPAC suggestions search form Bug 31605: Improve style of OPAC suggestions search form |
Created attachment 140854 [details] [review] Bug 31605: Improve style of OPAC suggestions search form This patch makes minor modifications to the markup for the OPAC suggestions search form so that the different labels and form fields display a little more nicely. The patch also adds standard Bootstrap alert classes to several messages which might be displayed on the screen, e.g. "You have no pending purchase suggestions." To test, apply the patch and make sure the "suggestion" system preference is enabled. - With the OPACViewOthersSuggestions preference disabled, log in to the OPAC and view your suggestions. - If you have no suggestions you should see a Bootstrap-styled message box, "You have no pending purchase suggestions." - If necessary, submit a suggestion. With at least one suggestion present you should see a search form above the table of suggestions. The label, form field, and submit button should line up nicely. - Test that the search form works correctly to find suggestions in your system. - If you search for a suggestion which doesn't exist you should see a message-style alert, "There are no pending purchase suggestions matching your search." - Enable the OPACViewOthersSuggestions system preference. - Return to the OPAC suggestions page. The form field should now include a nicely-styled "Suggested by" filter. Created attachment 140855 [details] [review] Bug 31605: Improve style of OPAC suggestions search form This patch makes minor modifications to the markup for the OPAC suggestions search form so that the different labels and form fields display a little more nicely. The patch also adds standard Bootstrap alert classes to several messages which might be displayed on the screen, e.g. "You have no pending purchase suggestions." To test, apply the patch and make sure the "suggestion" system preference is enabled. - With the OPACViewOthersSuggestions preference disabled, log in to the OPAC and view your suggestions. - If you have no suggestions you should see a Bootstrap-styled message box, "You have no pending purchase suggestions." - If necessary, submit a suggestion. With at least one suggestion present you should see a search form above the table of suggestions. The label, form field, and submit button should line up nicely. - Test that the search form works correctly to find suggestions in your system. - If you search for a suggestion which doesn't exist you should see a message-style alert, "There are no pending purchase suggestions matching your search." - Enable the OPACViewOthersSuggestions system preference. - Return to the OPAC suggestions page. The form field should now include a nicely-styled "Suggested by" filter. Signed-off-by: George Williams <george@nekls.org> Good improvements, markup looks good, and the QA scripts are happy. Created attachment 140918 [details] [review] Bug 31605: Improve style of OPAC suggestions search form This patch makes minor modifications to the markup for the OPAC suggestions search form so that the different labels and form fields display a little more nicely. The patch also adds standard Bootstrap alert classes to several messages which might be displayed on the screen, e.g. "You have no pending purchase suggestions." To test, apply the patch and make sure the "suggestion" system preference is enabled. - With the OPACViewOthersSuggestions preference disabled, log in to the OPAC and view your suggestions. - If you have no suggestions you should see a Bootstrap-styled message box, "You have no pending purchase suggestions." - If necessary, submit a suggestion. With at least one suggestion present you should see a search form above the table of suggestions. The label, form field, and submit button should line up nicely. - Test that the search form works correctly to find suggestions in your system. - If you search for a suggestion which doesn't exist you should see a message-style alert, "There are no pending purchase suggestions matching your search." - Enable the OPACViewOthersSuggestions system preference. - Return to the OPAC suggestions page. The form field should now include a nicely-styled "Suggested by" filter. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.07 release applied to 21.11 for 21.11.14 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. |
Created attachment 140853 [details] Screenshot showing the current style The search form shown at the top of OPAC purchase suggestions looks a little off, especially when OPACViewOthersSuggestions is enabled. See attached image.