Bug 31615

Summary: Allow checkin of items bundles without verifying their contents
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: CirculationAssignee: Julian Maurice <julian.maurice>
Status: RESOLVED FIXED QA Contact: Kyle M Hall <kyle>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, gmcharlt, jacob.omara, kyle.m.hall, kyle, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/694
Text to go in the release notes:
This enhancement adds the possibility to skip the content verification step when checking in a bundle.
Version(s) released in:
23.05.00
Bug Depends on: 28854    
Bug Blocks: 32802, 33827    
Attachments: Bug 31615: Allow checkin of items bundles without verifying their contents
Bug 31615: Allow checkin of items bundles without verifying their contents
Bug 31615: Allow checkin of items bundles without verifying their contents

Description Julian Maurice 2022-09-23 08:11:55 UTC
Combined with bug 29099, it will allow to return bundles quickly and do the inventory later.
Comment 1 Julian Maurice 2022-09-23 08:19:45 UTC
Created attachment 140883 [details] [review]
Bug 31615: Allow checkin of items bundles without verifying their contents

This patch adds a button in the "bundle verification" modal to skip
this step and do the checkin anyway.

Test plan:
1. Create an items bundle (see bug 28854 comment 458)
2. Check out this bundle, then return it. The "bundle verification"
   modal should appear
3. Leave the textarea empty and click on "Confirm checkin without
   verifying bundle contents"
4. Confirm that the bundle was correctly returned, and no items were
   marked as lost
Comment 2 Martin Renvoize 2023-02-02 16:41:37 UTC
Created attachment 146019 [details] [review]
Bug 31615: Allow checkin of items bundles without verifying their contents

This patch adds a button in the "bundle verification" modal to skip
this step and do the checkin anyway.

Test plan:
1. Create an items bundle (see bug 28854 comment 458)
2. Check out this bundle, then return it. The "bundle verification"
   modal should appear
3. Leave the textarea empty and click on "Confirm checkin without
   verifying bundle contents"
4. Confirm that the bundle was correctly returned, and no items were
   marked as lost

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2023-02-02 16:43:58 UTC
Signing off.. works as described.

I think I'd like to see the display of this button tied to a pref though myself.. I know some site want to require verification at check-in, whilst others won’t and will happily use the inventory in their workflow instead.
Comment 4 Kyle M Hall 2023-03-10 12:50:07 UTC
Created attachment 148069 [details] [review]
Bug 31615: Allow checkin of items bundles without verifying their contents

This patch adds a button in the "bundle verification" modal to skip
this step and do the checkin anyway.

Test plan:
1. Create an items bundle (see bug 28854 comment 458)
2. Check out this bundle, then return it. The "bundle verification"
   modal should appear
3. Leave the textarea empty and click on "Confirm checkin without
   verifying bundle contents"
4. Confirm that the bundle was correctly returned, and no items were
   marked as lost

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2023-04-06 13:40:27 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-17 07:22:08 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 7 Martin Renvoize 2023-05-24 17:28:07 UTC
Oh, this never got tied to a preference.
Comment 8 Katrin Fischer 2023-06-11 16:32:39 UTC
(In reply to Martin Renvoize from comment #7)
> Oh, this never got tied to a preference.

Bug 33827 now.