| Summary: | Reindent tools home and tools sidebar | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | andrew, lucas, martin.renvoize, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 31402 | ||
| Attachments: |
Bug 31625: Reindent tools home and tools sidebar
Bug 31625: (follow-up) Markup comments Bug 31625: Reindent tools home and tools sidebar Bug 31625: (follow-up) Markup comments Bug 31625: Reindent tools home and tools sidebar Bug 31625: (follow-up) Markup comments |
||
|
Description
Owen Leonard
2022-09-26 14:53:34 UTC
Created attachment 140990 [details] [review] Bug 31625: Reindent tools home and tools sidebar This patch performs general template cleanup to the tools-home and tools-menu templates: Make indentation consistent, replace tabs with spaces, fix invalid HTML. To test, apply the patch and go to Tools. The page should look correct, with no visible changes from before the patch. Go to any tools page which shows the left-hand sidebar, e.g. Patron lists, Batch item deletion, Inventory, etc. The menu should look correct. Created attachment 140991 [details] [review] Bug 31625: (follow-up) Markup comments This patch adds comments to the templates to highlight the markup structure. This patch should have no effect on the pages' appearance or functionality. Created attachment 141002 [details] [review] Bug 31625: Reindent tools home and tools sidebar This patch performs general template cleanup to the tools-home and tools-menu templates: Make indentation consistent, replace tabs with spaces, fix invalid HTML. To test, apply the patch and go to Tools. The page should look correct, with no visible changes from before the patch. Go to any tools page which shows the left-hand sidebar, e.g. Patron lists, Batch item deletion, Inventory, etc. The menu should look correct. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 141003 [details] [review] Bug 31625: (follow-up) Markup comments This patch adds comments to the templates to highlight the markup structure. This patch should have no effect on the pages' appearance or functionality. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Hm, I wonder if this does not clash with 31162 and if we should push one or the other first? Created attachment 141185 [details] [review] Bug 31625: Reindent tools home and tools sidebar This patch performs general template cleanup to the tools-home and tools-menu templates: Make indentation consistent, replace tabs with spaces, fix invalid HTML. To test, apply the patch and go to Tools. The page should look correct, with no visible changes from before the patch. Go to any tools page which shows the left-hand sidebar, e.g. Patron lists, Batch item deletion, Inventory, etc. The menu should look correct. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 141186 [details] [review] Bug 31625: (follow-up) Markup comments This patch adds comments to the templates to highlight the markup structure. This patch should have no effect on the pages' appearance or functionality. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #5) > Hm, I wonder if this does not clash with bug 31162 and if we should push one or > the other first? It'll clash, but I'll have a quick look at rebasing the other ones upon this one.. hopefully it won't be too painful. Pushed to master for 22.11. Nice work everyone, thanks! Was about to say I rebased this morning so we're all good to push.. then I spotted Tomas already had.. hehe |