This submission serves as a starting point for making the cataloguing processes into a more coherent module.

I think we can certainly work on improving the look and feel of the page and eventually migrate many of the 'tools' here out of 'tools' and into 'cataloging' as a distinct part of the breadcrumb.

I also intend to re-instate the cat-menu.inc sidebar option and have it reflect the options available from this new home page.

Looks good! Maybe you could also make "New record" heading and add those "Advanced editor" (if activated), "New record" and "New from 39.50/SRU" buttons underneath it? :)

Btw, if you click More -> Cataloging you end up to the "old" empty page.

Awesome feedback, thanks.

I did wonder about the toolbar with 'advanced editor' and 'new from X' buttons.. initially I didn't have that on the page at all but I haven't yet worked out a nicer way to do it.. I'll have a go at dropping the toolbar and moving them as per your suggestion.

Just a minor iteration there.. fixes the top bar link and moves the advanced editor button into a 'New' section underneath.. 

I'm not sure how to try and handle the other toolbar buttons.. the Framework selection lends itself to a button.. I was considering a fieldset with buttons but that also feels a bit weird.

Contemplating.

Nice cataloging page !

Note that if  EnableAdvancedCatalogingEditor is set on "Don't enable", the title of the "New" section is displayed although this section is empty.

Perhaps the "New record" and "New from Z39.50..." buttons could be in this section rather than above, in their own menu.

Is this what you mean with :
> I'm not sure how to try and handle the other toolbar buttons.. the Framework
> selection lends itself to a button.. I was considering a fieldset with
> buttons but that also feels a bit weird.

(In reply to Emmanuel Bétemps from comment #9)
> Nice cataloging page !
> 
> Note that if  EnableAdvancedCatalogingEditor is set on "Don't enable", the
> title of the "New" section is displayed although this section is empty.
> 
> Perhaps the "New record" and "New from Z39.50..." buttons could be in this
> section rather than above, in their own menu.
> 
Yes, this could be better place for them! :)

Thanks guys, its great to have feedback. I've been away for a couple of weeks but should be able to get back onto this soon now.

We lose a tiny bit of functionality with that follow-up... one can no longer select the framework as part of the action.. but it's actually the same number of clicks in the end.

i.e

Before
1. Click the down arrow on the toolbar button
2. Click the framework
3. Start cataloguing

After
1. Click the button
2. Start cataloguing in the default framework
3. Click the settings button to select framework

There's one thing which doesn't apply : the Z39.50 button in Cataloging page
- in the old fashioned way (after a search and not with the new Cataloging interface), a popup is displayed and the import button is useful
- in this new page, clicking it doesn't open a pop-up AND, in a second time, the Import button has no effet


The patch does not disable the Z39.50 search nor its importation feature : it's only the button in the new Cataloging page which doens't go well

Oop, I managed to drop some JS I shouldn't have.. it's restored now, so the Z39.50 options should trigger a popup again and trigger all the associated functionality there.

It's ok for me : all buttons seem effective

But I can't sign these patces, although they deserve it ^^

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt: needs merge
WARNING: git-filter-branch has a glut of gotchas generating mangled history
	 rewrites.  Hit Ctrl-C before proceeding to abort, then use an
	 alternative filtering tool such as 'git filter-repo'
	 (https://github.com/newren/git-filter-repo/) instead.  See the
	 filter-branch manual page for more details; to squelch this warning,
	 set FILTER_BRANCH_SQUELCH_WARNING=1.
Proceeding with filter-branch...

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt: needs merge
Cannot rewrite branches: You have unstaged changes.
Additionally, your index contains uncommitted changes.

No stash entries found.

Created attachment 138799 [details]
Screenshot - 4 Column

So.. where do we go from here..

* Should I remove the corresponding lines from the tools home page or do we think they should appear in both places.
* Should we update the various pages now added to the 'cataloging' homepage such that their breadcrumbs now read `Home > Cataloging > Page` as apposed to `Home > Tools > Page` and similar
* I'm working on bug 31417 to reinstate the cat-menu sidebar... same question as above about links appearing in both menus or just the new/reinstated cat-menu.inc

(In reply to Martin Renvoize from comment #22)
> So.. where do we go from here..
> 
> * Should I remove the corresponding lines from the tools home page or do we
> think they should appear in both places.

I've always found it slightly confusing with having things split up for various modules - from an information architecture perspective, grouping related things together seems to be the way to go where this is possible and logical.

For example, all the cataloguing things should be together, rather than split across cataloging, tools, administration. The same could apply to the other main modules such as circulation and patrons. This would probably require wider input  from the Koha Community before all were changed though.

I think we should have them in just one place - Cataloguing.

> * Should we update the various pages now added to the 'cataloging' homepage
> such that their breadcrumbs now read `Home > Cataloging > Page` as apposed
> to `Home > Tools > Page` and similar

To me, it makes more sense for the breadcrumbs `Home > Cataloging > Page`, and have things in just one place.

> * I'm working on bug 31417 to reinstate the cat-menu sidebar... same
> question as above about links appearing in both menus or just the
> new/reinstated cat-menu.inc

As above, just in one place (Cataloguing).

Some other feedback:

- Z3950 search: it seems like there are some challenges to add this to the sidebar menu, but that is the only thing when testing that doesn't appear (I enabled the advanced editor and stock rotation and they appeared

- Four columns or three? I think I would prefer three columns (similar to Circulation), with 'Automations' appearing under the third column. At present I think it looks a bit too crowded with everything crunched up, with three columns there would be more space around and between the headings for all the different options.

- Automations section: I think this heading should be singular, that is 'Automation'. I tried to think of some alternative wording, but the only thing I could come up with was 'Automatic rules' or 'Automatic processes'. The intention here (I think) is for things that can be set up and that will run automatically.

I think this is a great improvement!

Btw I'm liking that screenshot!

As suggested by David, I've now removed the duplicate items from the tools-home page. It leaves use with two tools still under the 'Cataloging' heading in the tools-home.

I'm not sure where 'Rotating collections' should live, 'Circulation' under tools perhaps.. or part of the new 'Cataloging' home page?

I think we can probably move 'Upload local cover images' to the new 'Cataloging' home page though.. do you agree?

Created attachment 139598 [details]
Screenshot - 3 Column

> 
> I'm not sure where 'Rotating collections' should live, 'Circulation' under
> tools perhaps.. or part of the new 'Cataloging' home page?
> 
> I think we can probably move 'Upload local cover images' to the new
> 'Cataloging' home page though.. do you agree?

Both suggestions make sense to me!

OK.. as agreed I've moved the last few things from the tools home that relate to cataloging now.. please check that both the tools home and cataloging home pages make sense with the full set of patches as they now stand :)

Created attachment 139654 [details]
left menu of the Tools module

Hi,


I noticed things but I don't know if you didn't modify the structure and "only" moved shortcuts on purpose 

Some buttons (the ones under Import, Export, Batch editing, and the "Upload local cover image" button) which appear in the Cataloging page actually lead to the Tools section

They aren't displayed in the Home > Tools page but once clicked, the links lead to https:[...]/koha/tools/***.pl and we still see these options on the left menu (of the Tools module)

Idem with Label creator, Quick spine... and Barcode image generator, which lead to the Label menu


I realise I'm not very clear so I made this attachment : Home-Tools-etc.pdf



Also, "Fast cataloging" is in the Circulation menu. Is it ok ?


Emmanuel

*** Bug 31148 has been marked as a duplicate of this bug. ***

I like the concept of having a cataloguing start page to get our modules closer in terms of a standard UI.

I think the problem I see here is that we need to put in more work to fix the discrepancies caused by moving tools to cataloguing (where they rightly belong). At the moment if you click on those links the breadcrumbs, URL and sidebar switch to tools. Also: the permissions are in tools.

I feel like we should do more steps in moving these tools.
* Sidebar will be fixed by bug 31417.
* Breadcrumbs could be fixed after.
* URLs - I am not completely sure about moving the files thb. but something to think about.

I have created 2 follow-ups for you to check and a couple of linked bugs with suggestions.

And I have one more thing I'd like to see "fixed" before we push this as a first step in restructuring:

The extra click for catalogers.

At the moment, using the split button you an get right into the framework you want. We remove this option. And I think that will make people grumpy.

* Default takes a while to load compared with the smaller frameworks.
* It's an extra click to switch.
* Switching frameworks when using default values can be problmatic. A default once added to a field, doesn't update when switching frameworks (say s for serials in LDR was added). 

Being able to choose the framework right away is important I think.

Created attachment 140586 [details] [review]
Bug 31162: Restore ability to pick framework

This patch restores the ability to pick the framework via a dropdown on
the cataloguing home page.

The CSS needs some work.. this is a proof of concept

Seems I missed both the last two comments until now, my apologies.

Thanks for testing!

* The sidebars are handled in another bug I'm working through :)
* I agree we should probably move the controller files and thus fix the url's, but again I think that should be done as it's own step in another bug.
* Breadcrumbs, that's also one I think should be fixed, but perhaps as part of the sidebar bug.
* I've had a go at restoring the framework selection stuff, but need a little SCSS help to polish it.

Thanks for tackling this, Martin! It's a big but useful change.

love everything about this. Please yes. Any number of columns whatever you think is best.

OK.. I'm going to hold off on continuing through this until we have bug 30592 pushed as I feel that's now just around the corner and it'll save me considerable rebases.. hopefully we'll get this set of bugs finished up in quick succession once that one is pushed and have the full effect for 22.11 :)

(In reply to Martin Renvoize from comment #60)
> OK.. I'm going to hold off on continuing through this until we have bug
> 30592 pushed as I feel that's now just around the corner and it'll save me
> considerable rebases.. hopefully we'll get this set of bugs finished up in
> quick succession once that one is pushed and have the full effect for 22.11
> :)

Guessing you mean bug 30952, staff client redesign. Bug 30592 is something about borrowers.secret.

Rebased against bug 31402.. still needs some CSS work on that final patch.. but also still testable.

I'm late to this party, but I looked at the 3-column and 4-column screenshots, and, oh, wow, I want this SO MUCH!!!  To me all these things have always been cataloging, and I have to pause and think, "Wait...that's under Tools...or Administration...or..."

And to have a button to take me right to the Advanced Bib Editor?!?  *squeeeeeee!!!*

I understand waiting until the staff client redesign is done.  I'm going to be in and out of the office for a while during October, but I *will* be devoting what attention I can give to this when I am at work.  Thank you thank you thank you!!

Signed,
Real Cataloger h2.

P.S. Typo in "Bug 31162: Fix help link on catalouging start page" should be "cataloguing.":)

Hi Martin.

I've tested again and have some more feedback and comments.

Feedback - bring back the toolbar?
----------------------------------

Should we bring back the toolbar at the top (with Advanced editor, New record and New from Z3950/SRYU buttons) rather than try fitting under the "New" sub-heading?

Rationale:

-  While some styling is required, it looks a little "odd" to me as it is - I don't think we have a dropdown button mingled with options in other areas as part of a landing page.

- Familiarity for cataloguers - the key options used are in a familiar place.

Feedback - Rotating collections
-------------------------------

There doesn't appear to be a link to Rotating collections, unless this is controlled by another system preference.

Some other comments
-------------------

1. I like the idea of the separate bugs for the breadcrumbs and the sidebar changes - makes it easier to do a step at a time, rather than a large change all in one bug.

2. Should there be a separate bug to move the permissions from tools to editcatalogue?

3. Should there be a separate bug to move the system preferences from Tools (or other areas) to Cataloging?

4. From Heather's comment #72, should we also have a separate bug to look at the Administration settings? As a compromise (or first step) we could have an option/link to "Catalog administration" or "Catalog configuration", or something similar.

5. The tools currently have a description in their old location on the tools page. Do we need these, or do we have a way of adding a tooltip with the description? We don't on the staff interface home page, so maybe there is not an issue.

6. Some tools are also used for authorities (such as Batch record deletion, Batch record modification, Export data, Stage MARC records for import). Just trying to think about how we would approach these if we adopt this approach for other modules - do we split these tools (separate out the cataloging vs authority parts), make an arbitrary decision on where they should be, or have a way for the breadcrumbs/URLs to recognise what area we are in (Cataloging, Authorities, etc) and then reflect that? Probably thinking too far ahead at the moment....

Testing notes
-------------

1. Enable the StockRotation and EnableAdvancedCatalogingEditor (so that these appear).
2. Check that there are no cataloguing-related tools under the tools menu.
3. Check that all the option links work as expected:
   . New record
   . New from Z39.50/SRU
   . Advanced editor
   . All the other cataloguing tools
4. Check that all the items previously on the tools page are now on the new cataloging home page (new section shown in brackets):
  - Batch item deletion (Batch editing)
  - Batch item modification (Batch editing)
  - Batch record deletion (Batch editing)
  - Batch record modification (Batch editing)
  - Automatic item modifications by age (Automation)
  - Export data (Export)
  - Inventory (Reports)
  - Label creator (Tools)
  - Barcode image generator (Tools)
  - Quick spine label creator (Tools)
  - Rotating collections (---Not currently shown---)
  - Stock rotation (Automation)
  - MARC modification templates (Batch editing)
  - Stage MARC records for import (Import)
  - Staged MARC record management (Import)
  - Upload local cover image (Tools)
5. Check that the grouping of the various cataloging tools makes logical sense to you - suggestions welcome on categorising!

NOTES:
- Breadcrumbs and page URLs will be changed in bug 31556
- The sidebar menu will be changed in bug 31417

(In reply to David Nind from comment #73)

> Feedback - Rotating collections
> -------------------------------
> 
> There doesn't appear to be a link to Rotating collections, unless this is
> controlled by another system preference.

Ignore this, I see that it is under Patrons and circulation on the Tools page.

In case this helps:

This cataloger's mind thinks of things like this, with the caveat that I'm in the U.S.--please, others, correct me with global perspectives!

These are "cataloguing tools:"  Record importing, record creating, record editing.  (Bibs, items, auts, etc.)  I think of this as every day work.  I want some people to have the ability to create/modify items, other people to have that power plus the power to create/modify bibs, and yet other people to have all those powers plus the power to create/modify auts.

These are "catalogue administration:"  Record deletion, batch record editing/modification, batch record deletion, MARC framework creation/editing, templates, etc.--absolutely every power in the creation, editing, deletion of records.  I want some people to have all the powers of the "cataloguing tools" above plus all these powers.

The more granularity in granting each of these powers to a particular user, the better.  One thing I absolutely love about Koha, is that if you don't have permission for a function, you don't see it on your menu--this rocks!
--h2

I agree with David's comment 73 that we should bring back the toolbar at the top (with Advanced editor, New record and New from Z3950/SRYU buttons) rather than putting it under the "New" sub-heading.  I think retaining the toolbar will be better both functionally and aesthetically.

(In reply to David Nind from comment #73)
> Hi Martin.
> 
> I've tested again and have some more feedback and comments.
> 
> Feedback - bring back the toolbar?
> ----------------------------------
> 
> Should we bring back the toolbar at the top (with Advanced editor, New
> record and New from Z3950/SRYU buttons) rather than try fitting under the
> "New" sub-heading?
> 
> Rationale:
> 
> -  While some styling is required, it looks a little "odd" to me as it is -
> I don't think we have a dropdown button mingled with options in other areas
> as part of a landing page.
> 
> - Familiarity for cataloguers - the key options used are in a familiar place.

OK, I've done this and will post the updated patches imminently.

> Feedback - Rotating collections
> -------------------------------
> 
> There doesn't appear to be a link to Rotating collections, unless this is
> controlled by another system preference.

Yup, I left that in 'Tools' for now.. I'm considering moving it to 'Circulation' actually.. it feels like it's really a 'bulk transfer' feature and thus fits within circulation?
 
> Some other comments
> -------------------
> 
> 1. I like the idea of the separate bugs for the breadcrumbs and the sidebar
> changes - makes it easier to do a step at a time, rather than a large change
> all in one bug.

Awesome, once we've completely finalised this one I'll move on to getting those sorted in in line with this.
 
> 2. Should there be a separate bug to move the permissions from tools to
> editcatalogue?

Good call.. I didn't consider the permissions at all at this time, but it makes a lot of sense to move those eventually too.
 
> 3. Should there be a separate bug to move the system preferences from Tools
> (or other areas) to Cataloging?

Not entirely sure what we mean by this one.. do you mean the 'cataloging' tab that's in global system preferences under administration right now?
 
> 4. From Heather's comment #72, should we also have a separate bug to look at
> the Administration settings? As a compromise (or first step) we could have
> an option/link to "Catalog administration" or "Catalog configuration", or
> something similar.

Wow, there's lots of advanced config like frameworks and things that's all configured from 'Administration'.. I'd not considered those either.. perhaps another bug.  For now I've added an 'Administration' section with two links, one to the main admin home page and one to the cataloging tab of global preferences.
 
> 5. The tools currently have a description in their old location on the tools
> page. Do we need these, or do we have a way of adding a tooltip with the
> description? We don't on the staff interface home page, so maybe there is
> not an issue.

There's a bug for this one already: bug #31427
 
> 6. Some tools are also used for authorities (such as Batch record deletion,
> Batch record modification, Export data, Stage MARC records for import). Just
> trying to think about how we would approach these if we adopt this approach
> for other modules - do we split these tools (separate out the cataloging vs
> authority parts), make an arbitrary decision on where they should be, or
> have a way for the breadcrumbs/URLs to recognise what area we are in
> (Cataloging, Authorities, etc) and then reflect that? Probably thinking too
> far ahead at the moment....

Hmm, to me Cataloging and Authorities are very closely tied.. I sort of think about them as living in the same place really..

This will need a squash once people are happy with it.. there's a lot of 'do this, undo it, do that' going on at this point.

Hopefully this'll be the iteration that people agree to go with.

Created attachment 141891 [details]
Current Iteration

I'm happy with this iteration! (I am not a catloguer though....)

(In reply to Martin Renvoize from comment #77)

> > 3. Should there be a separate bug to move the system preferences from Tools
> > (or other areas) to Cataloging?
> 
> Not entirely sure what we mean by this one.. do you mean the 'cataloging'
> tab that's in global system preferences under administration right now?

I was thinking of the cataloguing tools that are under the Tools system preferences: Barcodes and Batch item .

Thanks for responding to all the feedback!

Created attachment 141975 [details] [review]
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This serves to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a starting point
for cataloging.

We migrate most cataloging related tools from the 'Tools' module whilst
opting to move 'Rotating collections' to the 'Circulation' section of
the 'Tools' homepage. We also add links to the cataloging tab of system
preferences and a the adminstration pages if the user has the correct
permissions to have access to these areas.

Signed-off-by: KIT <michaela.sieber@kit.edu>
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Squashed all patches into one.. we've iterated lots and I think come to a reasonable conclusion..

Thanks to everyone for all the testing :)

Created attachment 141976 [details] [review]
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This serves to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a starting point
for cataloging.

We migrate most cataloging related tools from the 'Tools' module whilst
opting to move 'Rotating collections' to the 'Circulation' section of
the 'Tools' homepage. We also add links to the cataloging tab of system
preferences and a the adminstration pages if the user has the correct
permissions to have access to these areas.

Signed-off-by: KIT <michaela.sieber@kit.edu>
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>

Created attachment 141977 [details] [review]
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This serves to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a starting point
for cataloging.

We migrate most cataloging related tools from the 'Tools' module whilst
opting to move 'Rotating collections' to the 'Circulation' section of
the 'Tools' homepage. We also add links to the cataloging tab of system
preferences and a the adminstration pages if the user has the correct
permissions to have access to these areas.

Signed-off-by: KIT <michaela.sieber@kit.edu>
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>

Created attachment 142028 [details] [review]
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This serves to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a starting point
for cataloging.

We migrate most cataloging related tools from the 'Tools' module whilst
opting to move 'Rotating collections' to the 'Circulation' section of
the 'Tools' homepage. We also add links to the cataloging tab of system
preferences and a the adminstration pages if the user has the correct
permissions to have access to these areas.

Signed-off-by: KIT <michaela.sieber@kit.edu>
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Created attachment 142029 [details] [review]
Bug 31162: (QA follow-up) Use new WRAPPPERs and fix help link

This migrates the start page to the new page structure using
WRAPPERs instead of includes. One visible problem before
was the missing help link.

Also makes sure the help link leads to the correct page :)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Pushed to master for 22.11.

Nice work everyone, thanks!

t/db_dependent/www/search_utf8.t .. 1/89 Link not found at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 140.

139     $agent->follow_link_ok( { url_regex => qr/tools-home/i }, 'open tools module' );
140     $agent->follow_link_ok( { text => 'Stage MARC records for import' },
141         'go to stage MARC' );

Where is this link?

t/db_dependent/www/batch.t is failing as well because of this.

(In reply to Jonathan Druart from comment #100)
> t/db_dependent/www/search_utf8.t .. 1/89 Link not found at
> /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 140.
> 
> 139     $agent->follow_link_ok( { url_regex => qr/tools-home/i }, 'open
> tools module' );
> 140     $agent->follow_link_ok( { text => 'Stage MARC records for import' },
> 141         'go to stage MARC' );
> 
> Where is this link?

It's on the new cataloging start page now - first link on the left? But maybe this was just meant as a rhetoric question?

Nope, I greped "Stage MARC records for import" and got no result. It's now "Stage records for import". Selenium tests should be easy to fix then. Ask if you need help.

What's the plan to change people's habits? Shouldn't we advert this a bit more in the release notes? Shouldn't we have a hint with a link on top of the tools-home for a couple of releases?

Sorry, I didn't expect this to effect existing tests.

I'm out today in kid duties, so can work on tests tomorrow.

I think people's muscle memory will change fairly quickly in reality.  But I'm happy to add a quick link from tools home too if we think that will help... I think I even already suggested that as a compromise on irc.

Created attachment 142663 [details] [review]
Bug 31162: (follow-up) Fix Mocks/Zebra.pm

This patch updates the t/lib/Mocks/Zebra.pm testing module for the
change of navigation.

Created attachment 142664 [details] [review]
Bug 31162: (follow-up) Fix www/batch.t

This patch updates the t/db_dependent/www/batch.t test for the
change of navigation.

Two follow-ups for the cat-home change bit of the problem.. but the tests still fail further down.. I think it's coming from the move to background jobs and the return of the form submission changing.. must run now but can return to this later this evening unless someone beats me.

Follow-ups pushed to master. Thanks!

Manual has been updated