Bug 31666

Summary: Add job progress bar to stage-marc-import.pl
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: dcook, jonathan.druart, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30982    
Bug Blocks: 31748, 34362, 34354, 34364, 34468    
Attachments: Bug 31666: Add job progress bar to stage-marc-import.pl
Bug 31666: Add job progress bar to stage-marc-import.pl
Bug 31666: Add job progress bar to stage-marc-import.pl
Bug 31666: Add job progress bar to stage-marc-import.pl
Bug 31666: Add job progress bar to stage-marc-import.pl
Bug 31666: (QA follow-up) Add filters
Bug 31666: (QA follow-up) Remove ES template literals
Bug 31666: Add job progress bar to stage-marc-import.pl
Bug 31666: (QA follow-up) Add filters
Bug 31666: (QA follow-up) Remove ES template literals

Description Kyle M Hall 2022-09-30 17:12:47 UTC
It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them.
Comment 1 Kyle M Hall 2022-09-30 17:15:16 UTC
Created attachment 141172 [details] [review]
Bug 31666: Add job progress bar to stage-marc-import.pl

It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them.

This patch implements a reusable bootstrap based progess bar.

Test Plan:
1) Apply this patch
2) Stage a marc batch ( preferrably a large one to show the progress updating )
3) Note the new progess bar, verify it functions correctly.
Comment 2 Kyle M Hall 2022-09-30 17:26:28 UTC
Created attachment 141173 [details] [review]
Bug 31666: Add job progress bar to stage-marc-import.pl

It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them.

This patch implements a reusable bootstrap based progess bar.

Test Plan:
1) Apply this patch
2) Stage a marc batch ( preferrably a large one to show the progress updating )
3) Note the new progess bar, verify it functions correctly.
Comment 3 Kyle M Hall 2022-09-30 17:37:31 UTC
Created attachment 141174 [details] [review]
Bug 31666: Add job progress bar to stage-marc-import.pl

It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them.

This patch implements a reusable bootstrap based progess bar.

Test Plan:
1) Apply this patch
2) Stage a marc batch ( preferrably a large one to show the progress updating )
3) Note the new progess bar, verify it functions correctly.
Comment 4 David Nind 2022-10-03 13:02:50 UTC
Created attachment 141261 [details] [review]
Bug 31666: Add job progress bar to stage-marc-import.pl

It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them.

This patch implements a reusable bootstrap based progess bar.

Test Plan:
1) Apply this patch
2) Stage a marc batch ( preferrably a large one to show the progress updating )
3) Note the new progess bar, verify it functions correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Martin Renvoize 2022-10-04 14:36:22 UTC
Created attachment 141308 [details] [review]
Bug 31666: Add job progress bar to stage-marc-import.pl

It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them.

This patch implements a reusable bootstrap based progess bar.

Test Plan:
1) Apply this patch
2) Stage a marc batch ( preferrably a large one to show the progress updating )
3) Note the new progess bar, verify it functions correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2022-10-04 14:36:27 UTC
Created attachment 141309 [details] [review]
Bug 31666: (QA follow-up) Add filters

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2022-10-04 14:36:31 UTC
Created attachment 141310 [details] [review]
Bug 31666: (QA follow-up) Remove ES template literals

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2022-10-04 14:38:15 UTC
I found this difficult to test as all my imports were so darn quick.. but it does appear to all work.

Two QA follow-ups to keep the QA scripts happy.. I'm going to PQA, but a second set of eyes on my final follow-up wouldn't go a miss...
Comment 9 Tomás Cohen Arazi 2022-10-05 19:35:22 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Chris Cormack 2022-10-05 19:44:12 UTC
Created attachment 141397 [details] [review]
Bug 31666: Add job progress bar to stage-marc-import.pl

It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them.

This patch implements a reusable bootstrap based progess bar.

Test Plan:
1) Apply this patch
2) Stage a marc batch ( preferrably a large one to show the progress updating )
3) Note the new progess bar, verify it functions correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 11 Chris Cormack 2022-10-05 19:44:34 UTC
Created attachment 141398 [details] [review]
Bug 31666: (QA follow-up) Add filters

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 12 Chris Cormack 2022-10-05 19:44:51 UTC
Created attachment 141399 [details] [review]
Bug 31666: (QA follow-up) Remove ES template literals

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 13 Jonathan Druart 2022-10-14 13:30:48 UTC
job_progress is the only file in 'includes' to have '_' instead of '-'