It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them.
Created attachment 141172 [details] [review] Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly.
Created attachment 141173 [details] [review] Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly.
Created attachment 141174 [details] [review] Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly.
Created attachment 141261 [details] [review] Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 141308 [details] [review] Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 141309 [details] [review] Bug 31666: (QA follow-up) Add filters Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 141310 [details] [review] Bug 31666: (QA follow-up) Remove ES template literals Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I found this difficult to test as all my imports were so darn quick.. but it does appear to all work. Two QA follow-ups to keep the QA scripts happy.. I'm going to PQA, but a second set of eyes on my final follow-up wouldn't go a miss...
Pushed to master for 22.11. Nice work everyone, thanks!
Created attachment 141397 [details] [review] Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 141398 [details] [review] Bug 31666: (QA follow-up) Add filters Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 141399 [details] [review] Bug 31666: (QA follow-up) Remove ES template literals Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
job_progress is the only file in 'includes' to have '_' instead of '-'