|
Description
Owen Leonard
2022-10-10 18:00:49 UTC
Created attachment 141583 [details] [review] Bug 31730: Link to authorized value interface when an authval is mentioned in preferences This patch adds links to the authorized value interface anywhere an authorized value category is mentioned in a system preference description. To test, apply the patch and go to Administration -> System preferences. - Check these preferences: Circulation -> ILLHiddenRequestStatuses Circulation -> BundleLostValue Circulation -> BundleNotLoanValue Circulation -> ClaimReturnedLostValue Accounting -> RequirePaymentType - Confirm that the link in the description of each preference takes you to the correct authorized value category. Created attachment 141588 [details] [review] Bug 31730: Link to authorized value interface when an authval is mentioned in preferences This patch adds links to the authorized value interface anywhere an authorized value category is mentioned in a system preference description. To test, apply the patch and go to Administration -> System preferences. - Check these preferences: Circulation -> ILLHiddenRequestStatuses Circulation -> BundleLostValue Circulation -> BundleNotLoanValue Circulation -> ClaimReturnedLostValue Accounting -> RequirePaymentType - Confirm that the link in the description of each preference takes you to the correct authorized value category. Signed-off-by: David Nind <david@davidnind.com> I like this, but I'd like to suggest a small change. For system preferences we don't link the text 'system preference', but only the preference itself. I suggest we handle this the same for the authorised value categories. Created attachment 141931 [details] [review] Bug 31730: Link to authorized value interface when an authval is mentioned in preferences This patch adds links to the authorized value interface anywhere an authorized value category is mentioned in a system preference description. To test, apply the patch and go to Administration -> System preferences. - Check these preferences: Circulation -> ILLHiddenRequestStatuses Circulation -> BundleLostValue Circulation -> BundleNotLoanValue Circulation -> ClaimReturnedLostValue Accounting -> RequirePaymentType - Confirm that the link in the description of each preference takes you to the correct authorized value category. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 141932 [details] [review] Bug 31730: (QA follow-up) Only link category name Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be backported to 22.05.x |