Bug 31730

Summary: Link to authorized value interface when an authval is mentioned in preferences
Product: Koha Reporter: Owen Leonard <oleonard>
Component: System AdministrationAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on:    
Bug Blocks: 31731    
Attachments: Bug 31730: Link to authorized value interface when an authval is mentioned in preferences
Bug 31730: Link to authorized value interface when an authval is mentioned in preferences
Bug 31730: Link to authorized value interface when an authval is mentioned in preferences
Bug 31730: (QA follow-up) Only link category name

Description Owen Leonard 2022-10-10 18:00:49 UTC
Some preferences ask that an authorized value be entered, e.g.:

"Use the LOST authorized value [_____] to represent 'claims returned'."

It would be useful to link the user directly to that authval category.
Comment 1 Owen Leonard 2022-10-10 19:05:36 UTC
Created attachment 141583 [details] [review]
Bug 31730: Link to authorized value interface when an authval is mentioned in preferences

This patch adds links to the authorized value interface anywhere an
authorized value category is mentioned in a system preference
description.

To test, apply the patch and go to Administration -> System preferences.

- Check these preferences:
  Circulation -> ILLHiddenRequestStatuses
  Circulation -> BundleLostValue
  Circulation -> BundleNotLoanValue
  Circulation -> ClaimReturnedLostValue
  Accounting -> RequirePaymentType
- Confirm that the link in the description of each preference takes you
  to the correct authorized value category.
Comment 2 David Nind 2022-10-10 20:38:15 UTC
Created attachment 141588 [details] [review]
Bug 31730: Link to authorized value interface when an authval is mentioned in preferences

This patch adds links to the authorized value interface anywhere an
authorized value category is mentioned in a system preference
description.

To test, apply the patch and go to Administration -> System preferences.

- Check these preferences:
  Circulation -> ILLHiddenRequestStatuses
  Circulation -> BundleLostValue
  Circulation -> BundleNotLoanValue
  Circulation -> ClaimReturnedLostValue
  Accounting -> RequirePaymentType
- Confirm that the link in the description of each preference takes you
  to the correct authorized value category.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-15 19:38:19 UTC
I like this, but I'd like to suggest a small change. For system preferences we don't link the text 'system preference', but only the preference itself. I suggest we handle this the same for the authorised value categories.
Comment 4 Katrin Fischer 2022-10-15 19:42:55 UTC
Created attachment 141931 [details] [review]
Bug 31730: Link to authorized value interface when an authval is mentioned in preferences

This patch adds links to the authorized value interface anywhere an
authorized value category is mentioned in a system preference
description.

To test, apply the patch and go to Administration -> System preferences.

- Check these preferences:
  Circulation -> ILLHiddenRequestStatuses
  Circulation -> BundleLostValue
  Circulation -> BundleNotLoanValue
  Circulation -> ClaimReturnedLostValue
  Accounting -> RequirePaymentType
- Confirm that the link in the description of each preference takes you
  to the correct authorized value category.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-10-15 19:42:59 UTC
Created attachment 141932 [details] [review]
Bug 31730: (QA follow-up) Only link category name

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-10-24 20:38:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-12-05 23:07:06 UTC
Enhancement will not be backported to 22.05.x