If we're asking the user to enter one or more authorized value codes to a system preference we should offer them a dropdown menu to select from.
Created attachment 153269 [details] [review] Bug 31731: Offer user a dropdown of authorized values instead of a text field in preferences This patch updates the system preferences interface so that preferences which ask for a single authorized value can offer a dropdown menu of choices instead of a text field. The patch also updates a few existing preferences to use the new feature: BundleLostValue, BundleNotLoanValue, and ClaimReturnedLostValue. To test, apply the patch and restart services. - Go to Administration -> System preferences and search for "authorized value." - The search results should include the entries for BundleLostValue, BundleNotLoanValue, and ClaimReturnedLostValue. - Confirm that the dropdowns show the correct authorized value category (LOST or NOT_LOAN) - Confirm that setting or unsetting each of the preferences works correctly.
Created attachment 153270 [details] [review] Bug 31731: Offer user a dropdown of authorized values instead of a text field in preferences This patch updates the system preferences interface so that preferences which ask for a single authorized value can offer a dropdown menu of choices instead of a text field. The patch also updates a few existing preferences to use the new feature: BundleLostValue, BundleNotLoanValue, and ClaimReturnedLostValue. To test, apply the patch and restart services. - Go to Administration -> System preferences and search for "authorized value." - The search results should include the entries for BundleLostValue, BundleNotLoanValue, and ClaimReturnedLostValue. - Confirm that the dropdowns show the correct authorized value category (LOST or NOT_LOAN) - Confirm that setting or unsetting each of the preferences works correctly. Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 153514 [details] [review] Bug 31731: Offer user a dropdown of authorized values instead of a text field in preferences This patch updates the system preferences interface so that preferences which ask for a single authorized value can offer a dropdown menu of choices instead of a text field. The patch also updates a few existing preferences to use the new feature: BundleLostValue, BundleNotLoanValue, and ClaimReturnedLostValue. To test, apply the patch and restart services. - Go to Administration -> System preferences and search for "authorized value." - The search results should include the entries for BundleLostValue, BundleNotLoanValue, and ClaimReturnedLostValue. - Confirm that the dropdowns show the correct authorized value category (LOST or NOT_LOAN) - Confirm that setting or unsetting each of the preferences works correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 153515 [details] [review] Bug 31731: (QA follow-up) Add pull down to DefaultLongOverdueLostValue and DefaultLongOverdueChargeValue preferences Adds LOST pull downs to 2 more preferences. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Love this, really nice enhancement!
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x