Bug 31731 - Offer user a dropdown of authorized values instead of a text field in preferences
Summary: Offer user a dropdown of authorized values instead of a text field in prefere...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31730
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-10 18:55 UTC by Owen Leonard
Modified: 2023-12-14 20:38 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/790
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 31731: Offer user a dropdown of authorized values instead of a text field in preferences (5.92 KB, patch)
2023-07-10 13:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31731: Offer user a dropdown of authorized values instead of a text field in preferences (5.97 KB, patch)
2023-07-10 14:11 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 31731: Offer user a dropdown of authorized values instead of a text field in preferences (6.02 KB, patch)
2023-07-16 11:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31731: (QA follow-up) Add pull down to DefaultLongOverdueLostValue and DefaultLongOverdueChargeValue preferences (1.89 KB, patch)
2023-07-16 11:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-10-10 18:55:23 UTC
If we're asking the user to enter one or more authorized value codes to a system preference we should offer them a dropdown menu to select from.
Comment 1 Owen Leonard 2023-07-10 13:58:46 UTC Comment hidden (obsolete)
Comment 2 Sam Lau 2023-07-10 14:11:20 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2023-07-16 11:30:16 UTC
Created attachment 153514 [details] [review]
Bug 31731: Offer user a dropdown of authorized values instead of a text field in preferences

This patch updates the system preferences interface so that preferences
which ask for a single authorized value can offer a dropdown menu of
choices instead of a text field.

The patch also updates a few existing preferences to use the new
feature: BundleLostValue, BundleNotLoanValue, and
ClaimReturnedLostValue.

To test, apply the patch and restart services.

- Go to Administration -> System preferences and search for "authorized
  value."
- The search results should include the entries for BundleLostValue,
  BundleNotLoanValue, and ClaimReturnedLostValue.
- Confirm that the dropdowns show the correct authorized value category
  (LOST or NOT_LOAN)
- Confirm that setting or unsetting each of the preferences works
  correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-07-16 11:30:18 UTC
Created attachment 153515 [details] [review]
Bug 31731: (QA follow-up) Add pull down to DefaultLongOverdueLostValue and DefaultLongOverdueChargeValue preferences

Adds LOST pull downs to 2 more preferences.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-07-16 11:30:29 UTC
Love this, really nice enhancement!
Comment 6 Tomás Cohen Arazi 2023-10-10 13:56:05 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-12 20:57:23 UTC
Enhancement not pushed to 23.05.x