Bug 31743

Summary: Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: NoticesAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: marie-luce.laflamme
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Attachments: Bug 31743: Change condition for messaging tab
Bug 31743: Change condition for messaging tab
Bug 31743: Change condition for messaging tab

Description Marcel de Rooy 2022-10-12 14:56:18 UTC
The combination of enabling TranslateNotices and disabling EnhancedMessagingPreferencesOPAC eliminates the possibility of changing language on OPAC user account.

Note that we had both enabled and now we want to disable Enhanced on OPAC, but we loose the language.
Comment 1 Marcel de Rooy 2022-10-13 06:31:25 UTC
Created attachment 141768 [details] [review]
Bug 31743: Change condition for messaging tab

Note for QA:
The code for SMSnumber is still made dependent on
EnhancedMessagingPreferencesOPAC in order to not
disturb current behavior.
This fixes Enhanced on, EnhancedOPAC off; the case of
Enhanced off is not considered here.

Test plan:
Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
Enable TranslateNotices.
Check if you can only change notice language on OPAC.
Enable EnhancedMessagingOPAC.
Check if you change messaging prefs too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marie-Luce Laflamme 2022-10-13 21:56:49 UTC
Suggestion for the test plan

1. Apply the patch
3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
4. Enable TranslateNotices.
5. Login on the OPAC and go in "your messaging"
6. Check if you can only change notice language
7. Enable EnhancedMessagingOPAC.
8. Check if you can change messaging prefs too.
Comment 3 ByWater Sandboxes 2022-10-13 21:57:17 UTC
Created attachment 141849 [details] [review]
Bug 31743: Change condition for messaging tab

Note for QA:
The code for SMSnumber is still made dependent on
EnhancedMessagingPreferencesOPAC in order to not
disturb current behavior.
This fixes Enhanced on, EnhancedOPAC off; the case of
Enhanced off is not considered here.

Test plan:
Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
Enable TranslateNotices.
Check if you can only change notice language on OPAC.
Enable EnhancedMessagingOPAC.
Check if you change messaging prefs too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: marie-luce <marie-luce.laflamme@inlibro.com>
Comment 4 Marcel de Rooy 2022-10-14 05:57:38 UTC
(In reply to Marie-Luce Laflamme from comment #2)
> Suggestion for the test plan
> 
> 1. Apply the patch
> 3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
> 4. Enable TranslateNotices.
> 5. Login on the OPAC and go in "your messaging"
> 6. Check if you can only change notice language
> 7. Enable EnhancedMessagingOPAC.
> 8. Check if you can change messaging prefs too.

Thx Marie-Luce for signing off !
Comment 5 Katrin Fischer 2022-11-02 18:06:22 UTC
Created attachment 143024 [details] [review]
Bug 31743: Change condition for messaging tab

Note for QA:
The code for SMSnumber is still made dependent on
EnhancedMessagingPreferencesOPAC in order to not
disturb current behavior.
This fixes Enhanced on, EnhancedOPAC off; the case of
Enhanced off is not considered here.

Test plan:
Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
Enable TranslateNotices.
Check if you can only change notice language on OPAC.
Enable EnhancedMessagingOPAC.
Check if you change messaging prefs too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: marie-luce <marie-luce.laflamme@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-11-04 23:21:16 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!