The combination of enabling TranslateNotices and disabling EnhancedMessagingPreferencesOPAC eliminates the possibility of changing language on OPAC user account. Note that we had both enabled and now we want to disable Enhanced on OPAC, but we loose the language.
Created attachment 141768 [details] [review] Bug 31743: Change condition for messaging tab Note for QA: The code for SMSnumber is still made dependent on EnhancedMessagingPreferencesOPAC in order to not disturb current behavior. This fixes Enhanced on, EnhancedOPAC off; the case of Enhanced off is not considered here. Test plan: Enable EnhancedMessaging, disable EnhancedMessagingOPAC. Enable TranslateNotices. Check if you can only change notice language on OPAC. Enable EnhancedMessagingOPAC. Check if you change messaging prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Suggestion for the test plan 1. Apply the patch 3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC. 4. Enable TranslateNotices. 5. Login on the OPAC and go in "your messaging" 6. Check if you can only change notice language 7. Enable EnhancedMessagingOPAC. 8. Check if you can change messaging prefs too.
Created attachment 141849 [details] [review] Bug 31743: Change condition for messaging tab Note for QA: The code for SMSnumber is still made dependent on EnhancedMessagingPreferencesOPAC in order to not disturb current behavior. This fixes Enhanced on, EnhancedOPAC off; the case of Enhanced off is not considered here. Test plan: Enable EnhancedMessaging, disable EnhancedMessagingOPAC. Enable TranslateNotices. Check if you can only change notice language on OPAC. Enable EnhancedMessagingOPAC. Check if you change messaging prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: marie-luce <marie-luce.laflamme@inlibro.com>
(In reply to Marie-Luce Laflamme from comment #2) > Suggestion for the test plan > > 1. Apply the patch > 3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC. > 4. Enable TranslateNotices. > 5. Login on the OPAC and go in "your messaging" > 6. Check if you can only change notice language > 7. Enable EnhancedMessagingOPAC. > 8. Check if you can change messaging prefs too. Thx Marie-Luce for signing off !
Created attachment 143024 [details] [review] Bug 31743: Change condition for messaging tab Note for QA: The code for SMSnumber is still made dependent on EnhancedMessagingPreferencesOPAC in order to not disturb current behavior. This fixes Enhanced on, EnhancedOPAC off; the case of Enhanced off is not considered here. Test plan: Enable EnhancedMessaging, disable EnhancedMessagingOPAC. Enable TranslateNotices. Check if you can only change notice language on OPAC. Enable EnhancedMessagingOPAC. Check if you change messaging prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: marie-luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!