Summary: | Round corners in boxes | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | 31762, 31815 | ||
Attachments: |
Screenshot
Bug 31747: Give area-news box new staff design look Bug 31747: Use page-section class, reduce CSS Bug 31747: Use page-section class, reduce CSS Bug 31747: Give area-news box new staff design look Bug 31747: Use page-section class, reduce CSS Bug 31747: Give area-news box new staff design look Bug 31747: Use page-section class, reduce CSS |
Description
Tomás Cohen Arazi (tcohen)
2022-10-12 19:31:43 UTC
Created attachment 141751 [details]
Screenshot
Created attachment 141755 [details] [review] Bug 31747: Give area-news box new staff design look To test: 1. Apply patch 2. Regenerate staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Look at the #area-news element of the mainpage. 4. There should be no rounded corners and the box-shadow should be the same as seen elsewhere ( i.e. patron details page ) I think we should look to start reducing our specific css.. This seems a good case for that.. I'd add a 'page-section' class to the divs with 'area-news' id (Note "divs".. we should probably fix that whilst we're here and update the 'daily_quote' section to have it's own unique id. Then we can reduce the 'area-news' specific css to just 'color' as that's all that's not dealt with by 'page-section' already. Thoughts? Created attachment 141789 [details] [review] Bug 31747: Use page-section class, reduce CSS Let me know what you think of my follow-up that tries to achieve the above... I'm really keen to reduce our CSS footprint.. instead of targetting lots of individual elements I want to start using shared classes more so we can really improve consistency accross the board. Created attachment 141790 [details] [review] Bug 31747: Use page-section class, reduce CSS (In reply to Martin Renvoize from comment #5) > Let me know what you think of my follow-up that tries to achieve the above... > > I'm really keen to reduce our CSS footprint.. instead of targetting lots of > individual elements I want to start using shared classes more so we can > really improve consistency accross the board. I like it, less is more. :) Created attachment 141832 [details] [review] Bug 31747: Give area-news box new staff design look To test: 1. Apply patch 2. Regenerate staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Look at the #area-news element of the mainpage. 4. There should be no rounded corners and the box-shadow should be the same as seen elsewhere ( i.e. patron details page ) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 141833 [details] [review] Bug 31747: Use page-section class, reduce CSS Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> There are still rounded corners on .tab-content, like we see on the advanced search with the item type search - I've 31815 filed bug for those. Created attachment 141921 [details] [review] Bug 31747: Give area-news box new staff design look To test: 1. Apply patch 2. Regenerate staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Look at the #area-news element of the mainpage. 4. There should be no rounded corners and the box-shadow should be the same as seen elsewhere ( i.e. patron details page ) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 141922 [details] [review] Bug 31747: Use page-section class, reduce CSS Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |