We now have a mix of 'Flat' and '3D' elements in the staff client. Our re-usable 'page-section' class adds a 'card' like feel to sections of the page which is '3d' style, drop shadows and all.. but out topnav, sidenav and toolbars are all 'flat'.. the mix feels slighlty odd.. should we perhaps drop the drop shadow on our page-sections ?
See https://github.com/jajm/koha-staff-interface-redesign/issues/48 for prior discussion
Created attachment 141794 [details] [review] Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat
This doesn't strictly require bug 31747.. but it does make it a lot nicer to test as a whole. Test plan 1. Apply patch 2. yarn build the css 3. Compare main page (with news and user blocks added) 4. Compare borrower details page 5. Compare biblio details page Discus.
Created attachment 141899 [details] [review] Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat Signed-off-by: David Nind <david@davidnind.com>
Created attachment 141900 [details] Screenshots - Flat vs 3D or Mixed I've attached some screenshots. I don't mind either option.
Created attachment 141923 [details] [review] Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
So the world is flat after all :)
Pushed to master for 22.11. Nice work everyone, thanks!