Bug 31762 - Flat vs 3D or mixed
Summary: Flat vs 3D or mixed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31747
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-13 11:31 UTC by Martin Renvoize
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31762: Flatten page-section (902 bytes, patch)
2022-10-13 11:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31762: Flatten page-section (951 bytes, patch)
2022-10-14 17:35 UTC, David Nind
Details | Diff | Splinter Review
Screenshots - Flat vs 3D or Mixed (671.25 KB, application/pdf)
2022-10-14 17:54 UTC, David Nind
Details
Bug 31762: Flatten page-section (1009 bytes, patch)
2022-10-15 08:46 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-13 11:31:46 UTC
We now have a mix of 'Flat' and '3D' elements in the staff client.

Our re-usable 'page-section' class adds a 'card' like feel to sections of the page which is '3d' style, drop shadows and all.. but out topnav, sidenav and toolbars are all 'flat'.. the mix feels slighlty odd.. should we perhaps drop the drop shadow on our page-sections ?
Comment 1 Martin Renvoize 2022-10-13 11:32:24 UTC
See https://github.com/jajm/koha-staff-interface-redesign/issues/48 for prior discussion
Comment 2 Martin Renvoize 2022-10-13 11:40:28 UTC
Created attachment 141794 [details] [review]
Bug 31762: Flatten page-section

This patch removes the box-shadow from our 'card' mixin and thus makes
page-section and other similar content area blocks look flat
Comment 3 Martin Renvoize 2022-10-13 11:42:09 UTC
This doesn't strictly require bug 31747.. but it does make it a lot nicer to test as a whole.

Test plan
1. Apply patch
2. yarn build the css
3. Compare main page (with news and user blocks added)
4. Compare borrower details page
5. Compare biblio details page

Discus.
Comment 4 David Nind 2022-10-14 17:35:28 UTC
Created attachment 141899 [details] [review]
Bug 31762: Flatten page-section

This patch removes the box-shadow from our 'card' mixin and thus makes
page-section and other similar content area blocks look flat

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2022-10-14 17:54:00 UTC
Created attachment 141900 [details]
Screenshots - Flat vs 3D or Mixed

I've attached some screenshots.

I don't mind either option.
Comment 6 Katrin Fischer 2022-10-15 08:46:32 UTC
Created attachment 141923 [details] [review]
Bug 31762: Flatten page-section

This patch removes the box-shadow from our 'card' mixin and thus makes
page-section and other similar content area blocks look flat

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-10-15 08:46:52 UTC
So the world is flat after all :)
Comment 8 Tomás Cohen Arazi 2022-10-17 11:08:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!