Summary: | Detail view broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, gmcharlt, julian.maurice, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | |||
Attachments: |
Screenshot
Bug 31749: Fix detail display when not display cover images Bug 31749: Fix detail display when not display cover images Bug 31749: Fix detail display when not display cover images |
Description
Tomás Cohen Arazi (tcohen)
2022-10-12 19:53:31 UTC
Created attachment 141752 [details]
Screenshot
It looks fine unless all cover image services are turned off. Then the display is broken. Created attachment 141754 [details] [review] Bug 31749: Fix detail display when not display cover images To test: 1. Apply patch 2. Have none of the image services turned on: AmazonCoverImages LocalCoverImages IntranetCoce SyndeticsCovers 3. Look at the detail page, things should look right. 4. Turn on some of these image services, things should still look right. Created attachment 141767 [details] [review] Bug 31749: Fix detail display when not display cover images To test: 1. Apply patch 2. Have none of the image services turned on: AmazonCoverImages LocalCoverImages IntranetCoce SyndeticsCovers 3. Look at the detail page, things should look right. 4. Turn on some of these image services, things should still look right. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 141791 [details] [review] Bug 31749: Fix detail display when not display cover images To test: 1. Apply patch 2. Have none of the image services turned on: AmazonCoverImages LocalCoverImages IntranetCoce SyndeticsCovers 3. Look at the detail page, things should look right. 4. Turn on some of these image services, things should still look right. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Fixes the bug as described.. Passing QA Pushed to master for 22.11. Nice work everyone, thanks! |