| Summary: | Need more padding in cataloguing | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 30952 | ||
| Bug Blocks: | |||
| Attachments: |
Screenshot
Bug 31750: Need more padding in cataloguing Bug 31750: (follow-up) Stylelint fixes Bug 31750: Need more padding in cataloguing Bug 31750: (follow-up) Stylelint fixes Bug 31750: Need more padding in cataloguing Bug 31750: (follow-up) Stylelint fixes |
||
|
Description
Tomás Cohen Arazi (tcohen)
2022-10-12 20:13:38 UTC
Created attachment 141753 [details]
Screenshot
IMHO this just needs to not have rounded corners ( border-radius ) on the tab-content element. The padding looks nice as is and looks good when you scroll down and the toolbar stays fixed to the top of the screen. Although, that is just my opinion. I tihnk a little bit of padding would not hurt, but need to keep the floating toolbar in mind. I'd also like to have the "Section 4" heading not stick to the section border. Created attachment 142083 [details] [review] Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" Created attachment 142084 [details] [review] Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. Created attachment 142095 [details] [review] Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" Signed-off-by: David Nind <david@davidnind.com> Created attachment 142096 [details] [review] Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. Signed-off-by: David Nind <david@davidnind.com> Created attachment 142316 [details] [review] Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 142317 [details] [review] Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Solid improvements here.. Passing QA It may be my eyes... but isn't the 'Cancel' link mis-aligned slightly.. apearing slightly above the content of the buttons in the toolbar? Nah.. it's my eyes.. inspecting it suggests it's all the same padding etc. Pushed to master for 22.11. Nice work everyone, thanks! |