Bug 31750 - Need more padding in cataloguing
Summary: Need more padding in cataloguing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-12 20:13 UTC by Tomás Cohen Arazi
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Screenshot (60.67 KB, image/png)
2022-10-12 20:14 UTC, Tomás Cohen Arazi
Details
Bug 31750: Need more padding in cataloguing (2.01 KB, patch)
2022-10-18 17:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31750: (follow-up) Stylelint fixes (10.42 KB, patch)
2022-10-18 17:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31750: Need more padding in cataloguing (2.06 KB, patch)
2022-10-18 20:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 31750: (follow-up) Stylelint fixes (10.46 KB, patch)
2022-10-18 20:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 31750: Need more padding in cataloguing (2.12 KB, patch)
2022-10-21 10:13 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31750: (follow-up) Stylelint fixes (10.53 KB, patch)
2022-10-21 10:13 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2022-10-12 20:13:38 UTC
The cataloguing form lacks some padding to match the top bar
Comment 1 Tomás Cohen Arazi 2022-10-12 20:14:22 UTC
Created attachment 141753 [details]
Screenshot
Comment 2 Lucas Gass 2022-10-12 22:27:34 UTC
IMHO this just needs to not have rounded corners ( border-radius ) on the tab-content element. 

The padding looks nice as is and looks good when you scroll down and the toolbar stays fixed to the top of the screen. 

Although, that is just my opinion.
Comment 3 Katrin Fischer 2022-10-16 12:42:09 UTC
I tihnk a little bit of padding would not hurt, but need to keep the floating toolbar in mind.

I'd also like to have the "Section 4" heading not stick to the section border.
Comment 4 Owen Leonard 2022-10-18 17:39:21 UTC
Created attachment 142083 [details] [review]
Bug 31750: Need more padding in cataloguing

This patch makes some minor tweaks to the CSS controlling the appearance
of the toolbar shown in the basic cataloging editor.

To test, apply the patch and go to Cataloging -> New record.

- Confirm that the page looks correct, with the toolbar the same width
  as the main content of the page.
- Confirm that the toolbar looks correct when you scroll and the toolbar
  "floats"
Comment 5 Owen Leonard 2022-10-18 17:39:28 UTC
Created attachment 142084 [details] [review]
Bug 31750: (follow-up) Stylelint fixes

This patch makes no changes which affect the style of the page.
All changes are corrections to formatting.
Comment 6 David Nind 2022-10-18 20:18:42 UTC
Created attachment 142095 [details] [review]
Bug 31750: Need more padding in cataloguing

This patch makes some minor tweaks to the CSS controlling the appearance
of the toolbar shown in the basic cataloging editor.

To test, apply the patch and go to Cataloging -> New record.

- Confirm that the page looks correct, with the toolbar the same width
  as the main content of the page.
- Confirm that the toolbar looks correct when you scroll and the toolbar
  "floats"

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2022-10-18 20:18:47 UTC
Created attachment 142096 [details] [review]
Bug 31750: (follow-up) Stylelint fixes

This patch makes no changes which affect the style of the page.
All changes are corrections to formatting.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Martin Renvoize 2022-10-21 10:13:50 UTC
Created attachment 142316 [details] [review]
Bug 31750: Need more padding in cataloguing

This patch makes some minor tweaks to the CSS controlling the appearance
of the toolbar shown in the basic cataloging editor.

To test, apply the patch and go to Cataloging -> New record.

- Confirm that the page looks correct, with the toolbar the same width
  as the main content of the page.
- Confirm that the toolbar looks correct when you scroll and the toolbar
  "floats"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2022-10-21 10:13:55 UTC
Created attachment 142317 [details] [review]
Bug 31750: (follow-up) Stylelint fixes

This patch makes no changes which affect the style of the page.
All changes are corrections to formatting.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2022-10-21 10:14:19 UTC
Solid improvements here.. Passing QA
Comment 11 Martin Renvoize 2022-10-21 10:15:59 UTC
It may be my eyes... but isn't the 'Cancel' link mis-aligned slightly.. apearing slightly above the content of the buttons in the toolbar?
Comment 12 Martin Renvoize 2022-10-21 10:17:32 UTC
Nah.. it's my eyes.. inspecting it suggests it's all the same padding etc.
Comment 13 Tomás Cohen Arazi 2022-10-21 12:58:45 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!