Summary: | Flat vs 3D or mixed | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, gmcharlt, lucas, oleonard |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 31747 | ||
Bug Blocks: | |||
Attachments: |
Bug 31762: Flatten page-section
Bug 31762: Flatten page-section Screenshots - Flat vs 3D or Mixed Bug 31762: Flatten page-section |
Description
Martin Renvoize (ashimema)
2022-10-13 11:31:46 UTC
See https://github.com/jajm/koha-staff-interface-redesign/issues/48 for prior discussion Created attachment 141794 [details] [review] Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat This doesn't strictly require bug 31747.. but it does make it a lot nicer to test as a whole. Test plan 1. Apply patch 2. yarn build the css 3. Compare main page (with news and user blocks added) 4. Compare borrower details page 5. Compare biblio details page Discus. Created attachment 141899 [details] [review] Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat Signed-off-by: David Nind <david@davidnind.com> Created attachment 141900 [details]
Screenshots - Flat vs 3D or Mixed
I've attached some screenshots.
I don't mind either option.
Created attachment 141923 [details] [review] Bug 31762: Flatten page-section This patch removes the box-shadow from our 'card' mixin and thus makes page-section and other similar content area blocks look flat Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> So the world is flat after all :) Pushed to master for 22.11. Nice work everyone, thanks! |