| Summary: | Add 'page-section' to patron clubs page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, koha-bugs, lucas, oleonard, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
22.11.00
|
Circulation function: | |
| Bug Depends on: | 30952 | ||
| Bug Blocks: | 31757 | ||
| Attachments: |
Bug 31764: Add 'page-section' to patron clubs page
Bug 31764: Add 'page-section' to patron clubs page Bug 31764: Add 'page-section' to patron clubs page |
||
|
Description
Martin Renvoize (ashimema)
2022-10-13 12:11:53 UTC
Created attachment 141836 [details] [review] Bug 31764: Add 'page-section' to patron clubs page This patch updates patron clubs template so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, add at least one club template and at least one club based on that template. - Confirm that the display of club templates and clubs looks correct. - Locate some patrons and add them to a club. - On the patron clubs page, locate a club with enrollments and click Actions -> Enrollments. Confirm that the page looks correct. Created attachment 141839 [details] [review] Bug 31764: Add 'page-section' to patron clubs page This patch updates patron clubs template so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, add at least one club template and at least one club based on that template. - Confirm that the display of club templates and clubs looks correct. - Locate some patrons and add them to a club. - On the patron clubs page, locate a club with enrollments and click Actions -> Enrollments. Confirm that the page looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 141920 [details] [review] Bug 31764: Add 'page-section' to patron clubs page This patch updates patron clubs template so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, add at least one club template and at least one club based on that template. - Confirm that the display of club templates and clubs looks correct. - Locate some patrons and add them to a club. - On the patron clubs page, locate a club with enrollments and click Actions -> Enrollments. Confirm that the page looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |