Bug 31764 - Add 'page-section' to patron clubs page
Summary: Add 'page-section' to patron clubs page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 30952
Blocks: 31757
  Show dependency tree / graph
 
Reported: 2022-10-13 12:11 UTC by Martin Renvoize (ashimema)
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31764: Add 'page-section' to patron clubs page (9.83 KB, patch)
2022-10-13 18:42 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 31764: Add 'page-section' to patron clubs page (9.88 KB, patch)
2022-10-13 19:34 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 31764: Add 'page-section' to patron clubs page (9.94 KB, patch)
2022-10-15 08:36 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-10-13 12:11:53 UTC 
We need the page-section divs adding to patron clubs page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Owen Leonard 2022-10-13 18:42:01 UTC 
Created attachment 141836 [details] [review]
Bug 31764: Add 'page-section' to patron clubs page

This patch updates patron clubs template so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron clubs.

- If necessary, add at least one club template and at least one club
  based on that template.
- Confirm that the display of club templates and clubs looks correct.
- Locate some patrons and add them to a club.
- On the patron clubs page, locate a club with enrollments and click
  Actions -> Enrollments. Confirm that the page looks correct.
Comment 2 Lucas Gass (lukeg) 2022-10-13 19:34:04 UTC 
Created attachment 141839 [details] [review]
Bug 31764: Add 'page-section' to patron clubs page

This patch updates patron clubs template so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron clubs.

- If necessary, add at least one club template and at least one club
  based on that template.
- Confirm that the display of club templates and clubs looks correct.
- Locate some patrons and add them to a club.
- On the patron clubs page, locate a club with enrollments and click
  Actions -> Enrollments. Confirm that the page looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2022-10-15 08:36:42 UTC 
Created attachment 141920 [details] [review]
Bug 31764: Add 'page-section' to patron clubs page

This patch updates patron clubs template so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron clubs.

- If necessary, add at least one club template and at least one club
  based on that template.
- Confirm that the display of club templates and clubs looks correct.
- Locate some patrons and add them to a club.
- On the patron clubs page, locate a club with enrollments and click
  Actions -> Enrollments. Confirm that the page looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-10-17 11:08:44 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!