Bug 31765

Summary: Add 'page-section' to import patrons page
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Staff interfaceAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, koha-bugs, lucas, oleonard, testopia
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 30952    
Bug Blocks: 31757    
Attachments: Bug 31765: Add page-section and bg-info classes to 'Notes'
Bug 31765: Add page-section and bg-info classes to 'Notes'
Bug 31765: Add page-section and bg-info classes to 'Notes'

Description Martin Renvoize (ashimema) 2022-10-13 12:14:34 UTC
I think the 'Notes' section on the import patrons page needs either page-section or a similar, but different background, class adding to distinguish the notes as 'info only'
Comment 1 Martin Renvoize (ashimema) 2022-10-22 08:23:01 UTC
Created attachment 142449 [details] [review]
Bug 31765: Add page-section and bg-info classes to 'Notes'

This patch adds the page-section and bg-info classes to the 'Notes'
section of the patron imports page.

As part of this patch, we update the base 'card' mixin to allow
background colors to be overwridden with the standard bg-* options
available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/)

Test plan
1) Build your CSS in the usual way
2) Confirm the Notes block looks OK on the patron imports tool
Comment 2 Katrin Fischer 2022-10-23 12:42:09 UTC
Created attachment 142461 [details] [review]
Bug 31765: Add page-section and bg-info classes to 'Notes'

This patch adds the page-section and bg-info classes to the 'Notes'
section of the patron imports page.

As part of this patch, we update the base 'card' mixin to allow
background colors to be overwridden with the standard bg-* options
available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/)

Test plan
1) Build your CSS in the usual way
2) Confirm the Notes block looks OK on the patron imports tool
Comment 3 Katrin Fischer 2022-10-23 12:44:08 UTC
Created attachment 142462 [details] [review]
Bug 31765: Add page-section and bg-info classes to 'Notes'

This patch adds the page-section and bg-info classes to the 'Notes'
section of the patron imports page.

As part of this patch, we update the base 'card' mixin to allow
background colors to be overwridden with the standard bg-* options
available in [bootstrap](https://getbootstrap.com/docs/4.0/utilities/colors/)

Test plan
1) Build your CSS in the usual way
2) Confirm the Notes block looks OK on the patron imports tool

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-10-23 12:44:34 UTC
Moving this directly on to Tomas.
Comment 5 Tomás Cohen Arazi (tcohen) 2022-10-24 13:58:16 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!