Summary: | Add 'page-section' to rotating collections page | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize <martin.renvoize> |
Component: | Staff interface | Assignee: | Lucas Gass <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, gmcharlt, koha-bugs, lucas, oleonard, testopia, tomascohen |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Bug Depends on: | 30952 | ||
Bug Blocks: | 31757, 31911 | ||
Attachments: |
Bug 31770: Add page-section class to rotating collections page
Bug 31770: Add page-section class to rotating collections page Bug 31770: Add page-section class to rotating collections page |
Description
Martin Renvoize
2022-10-13 12:30:04 UTC
Created attachment 142105 [details] [review] Bug 31770: Add page-section class to rotating collections page To test: 1. Apply patch 2. Go to the rotating collections page. Tools / Rotating collections 3. Add some new collections 4. Note that the page looks good with the new page section div. Note: I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied. Created attachment 142119 [details] [review] Bug 31770: Add page-section class to rotating collections page To test: 1. Apply patch 2. Go to the rotating collections page. Tools / Rotating collections 3. Add some new collections 4. Note that the page looks good with the new page section div. Note: I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied. Signed-off-by: David Nind <david@davidnind.com> Should the page-section div for list of items in the rotating collection be included in this one, or a separate bug (I couldn't see one)? Apologies for the noise with bug 30771 - I got confused and thought they were related. Created attachment 142397 [details] [review] Bug 31770: Add page-section class to rotating collections page To test: 1. Apply patch 2. Go to the rotating collections page. Tools / Rotating collections 3. Add some new collections 4. Note that the page looks good with the new page section div. Note: I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 22.11. Nice work everyone, thanks! |