Bug 31770 - Add 'page-section' to rotating collections page
Summary: Add 'page-section' to rotating collections page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 30952
Blocks: 31757 31911
  Show dependency tree / graph
 
Reported: 2022-10-13 12:30 UTC by Martin Renvoize (ashimema)
Modified: 2023-12-28 20:43 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31770: Add page-section class to rotating collections page (6.75 KB, patch)
2022-10-18 22:15 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 31770: Add page-section class to rotating collections page (6.80 KB, patch)
2022-10-18 23:02 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31770: Add page-section class to rotating collections page (6.86 KB, patch)
2022-10-21 13:55 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-10-13 12:30:04 UTC 
We need the page-section div adding to the rotating collections page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Lucas Gass (lukeg) 2022-10-18 22:15:09 UTC 
Created attachment 142105 [details] [review]
Bug 31770: Add page-section class to rotating collections page

To test:
1. Apply patch
2. Go to the rotating collections page. Tools / Rotating collections
3. Add some new collections
4. Note that the page looks good with the new page section div.

Note:
I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied.
Comment 2 David Nind 2022-10-18 23:02:47 UTC 
Created attachment 142119 [details] [review]
Bug 31770: Add page-section class to rotating collections page

To test:
1. Apply patch
2. Go to the rotating collections page. Tools / Rotating collections
3. Add some new collections
4. Note that the page looks good with the new page section div.

Note:
I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-10-18 23:16:16 UTC 
Should the page-section div for list of items in the rotating collection be included in this one, or a separate bug (I couldn't see one)?

Apologies for the noise with bug 30771 - I got confused and thought they were related.
Comment 4 Katrin Fischer 2022-10-21 13:55:27 UTC 
Created attachment 142397 [details] [review]
Bug 31770: Add page-section class to rotating collections page

To test:
1. Apply patch
2. Go to the rotating collections page. Tools / Rotating collections
3. Add some new collections
4. Note that the page looks good with the new page section div.

Note:
I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-10-21 14:47:09 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!