Bug 31781

Summary:	Transferred items table (branchtransfers.tt) needs page-section class
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Staff interface	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	enhancement
Priority:	P5 - low	CC:	david, gmcharlt, kyle.m.hall
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31805 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00
Circulation function:
Bug Depends on:	30952
Bug Blocks:
Attachments:	Bug 31781: Add page-section to branchtransfers page Bug 31781: Add page-section to branchtransfers page Screenshots - Before and after patch applied Bug 31781: Add page-section to branchtransfers page

Description Lucas Gass (lukeg) 2022-10-13 21:25:23 UTC

We need the page-section div added to the branchtransfers page to ensure proper contrast for even/odd rows on the tables.

Comment 1 Lucas Gass (lukeg) 2022-10-13 22:23:57 UTC

Created attachment 141851 [details] [review]
Bug 31781: Add page-section to branchtransfers page

This patch adds the page-section div to 2 tables on the branch transfer page.

To test:
1. Apply patch
2. Place an item level hold on a few items.
3. Now go to the branch transfer page and try transferring your items that have holds on them.
4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added.
5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added.

Note: There are some indentation changes.

Comment 2 David Nind 2022-10-14 19:38:44 UTC

Created attachment 141901 [details] [review]
Bug 31781: Add page-section to branchtransfers page

This patch adds the page-section div to 2 tables on the branch transfer page.

To test:
1. Apply patch
2. Place an item level hold on a few items.
3. Now go to the branch transfer page and try transferring your items that have holds on them.
4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added.
5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added.

Note: There are some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 David Nind 2022-10-14 20:10:58 UTC

Created attachment 141903 [details]
Screenshots - Before and after patch applied

I've signed off, as this bug adds the page-section div.

I did notice a couple of things - see screenshots:
- When transferring, the page says "Reserve found", from our terminology list this should be "Hold found".
- There are grey backgrounds and a left border around the buttons.
- The text should be left aligned.
- The table looks "different" than others, I'm assuming because it is not using DataTables.

Have logged bug 31805 - Tidy up transfer pages (branchtransfers.pl) - terminology and styling for these

Comment 4 Katrin Fischer 2022-10-15 07:41:57 UTC

Don't forget to set assignee please!

Comment 5 Katrin Fischer 2022-10-15 07:48:03 UTC

This page needs a lot more work, but this does what is written on the tin.

Comment 6 Katrin Fischer 2022-10-15 07:49:33 UTC

Created attachment 141913 [details] [review]
Bug 31781: Add page-section to branchtransfers page

This patch adds the page-section div to 2 tables on the branch transfer page.

To test:
1. Apply patch
2. Place an item level hold on a few items.
3. Now go to the branch transfer page and try transferring your items that have holds on them.
4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added.
5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added.

Note: There are some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 7 Lucas Gass (lukeg) 2022-10-17 16:39:38 UTC

(In reply to Katrin Fischer from comment #5)
> This page needs a lot more work, but this does what is written on the tin.

Curious what other work you are referring to...

Comment 8 David Nind 2022-10-17 18:30:00 UTC

(In reply to Lucas Gass from comment #7)
..
> Curious what other work you are referring to...

See bug 31805 and the screenshots.

Comment 9 Katrin Fischer 2022-10-17 19:17:31 UTC

(In reply to Lucas Gass from comment #7)
> (In reply to Katrin Fischer from comment #5)
> > This page needs a lot more work, but this does what is written on the tin.
> 
> Curious what other work you are referring to...

David filed it as bug 31805, but there was also an older bug 25682

Comment 10 Katrin Fischer 2022-10-17 19:18:42 UTC

(In reply to David Nind from comment #8)
> (In reply to Lucas Gass from comment #7)
> ..
> > Curious what other work you are referring to...
> 
> See bug 31805 and the screenshots.

Ooops, missed that comment!

Comment 11 Tomás Cohen Arazi (tcohen) 2022-10-17 20:48:37 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!