We need the page-section div added to the branchtransfers page to ensure proper contrast for even/odd rows on the tables.
Created attachment 141851 [details] [review] Bug 31781: Add page-section to branchtransfers page This patch adds the page-section div to 2 tables on the branch transfer page. To test: 1. Apply patch 2. Place an item level hold on a few items. 3. Now go to the branch transfer page and try transferring your items that have holds on them. 4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added. 5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added. Note: There are some indentation changes.
Created attachment 141901 [details] [review] Bug 31781: Add page-section to branchtransfers page This patch adds the page-section div to 2 tables on the branch transfer page. To test: 1. Apply patch 2. Place an item level hold on a few items. 3. Now go to the branch transfer page and try transferring your items that have holds on them. 4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added. 5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added. Note: There are some indentation changes. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 141903 [details] Screenshots - Before and after patch applied I've signed off, as this bug adds the page-section div. I did notice a couple of things - see screenshots: - When transferring, the page says "Reserve found", from our terminology list this should be "Hold found". - There are grey backgrounds and a left border around the buttons. - The text should be left aligned. - The table looks "different" than others, I'm assuming because it is not using DataTables. Have logged bug 31805 - Tidy up transfer pages (branchtransfers.pl) - terminology and styling for these
Don't forget to set assignee please!
This page needs a lot more work, but this does what is written on the tin.
Created attachment 141913 [details] [review] Bug 31781: Add page-section to branchtransfers page This patch adds the page-section div to 2 tables on the branch transfer page. To test: 1. Apply patch 2. Place an item level hold on a few items. 3. Now go to the branch transfer page and try transferring your items that have holds on them. 4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added. 5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added. Note: There are some indentation changes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #5) > This page needs a lot more work, but this does what is written on the tin. Curious what other work you are referring to...
(In reply to Lucas Gass from comment #7) .. > Curious what other work you are referring to... See bug 31805 and the screenshots.
(In reply to Lucas Gass from comment #7) > (In reply to Katrin Fischer from comment #5) > > This page needs a lot more work, but this does what is written on the tin. > > Curious what other work you are referring to... David filed it as bug 31805, but there was also an older bug 25682
(In reply to David Nind from comment #8) > (In reply to Lucas Gass from comment #7) > .. > > Curious what other work you are referring to... > > See bug 31805 and the screenshots. Ooops, missed that comment!
Pushed to master for 22.11. Nice work everyone, thanks!