Bug 31783

Summary: Table settings page needs page-section class
Product: Koha Reporter: Lucas Gass <lucas>
Component: ToolsAssignee: Bugs List <koha-bugs>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 30952    
Bug Blocks:    
Attachments: Bug 31783: Add page-section to columns_settings.tt page

Description Lucas Gass 2022-10-13 23:12:19 UTC
We need the page-section div added to the columns_settings.tt page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Lucas Gass 2022-10-13 23:17:25 UTC
Created attachment 141852 [details] [review]
Bug 31783: Add page-section to columns_settings.tt page

This patch adds the page-section class to the tables on the Table settings page.

To test:

1. Apply patch and go to Administration > Table settings
2. Make sure the tables look good with the new page-section class, which is added to an existing div in this case.
3. Make sure that changing some table setting still works and you can properly save new settings.

Note: This patch moves the fieldset which contains the Save button into the page-section div.
Comment 2 Owen Leonard 2022-10-14 11:35:29 UTC
I think I disagree on this one. The main difference between the current interface and the pre-redesign one is the table borders. The table row highlighting is even a little darker in the redesign.

In my opinion the interface is too busy with the added page-section class.