Bug 31805

Summary:	Tidy up transfer pages (branchtransfers.pl) - terminology and styling
Product:	Koha	Reporter:	David Nind <david>
Component:	Circulation	Assignee:	Bugs List <koha-bugs>
Status:	NEW ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt, kyle.m.hall, lucas
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Screenshots - library transfer screen and table

Description David Nind 2022-10-14 20:09:35 UTC

Created attachment 141902 [details]
Screenshots - library transfer screen and table

When testing bug 31781 I noticed a couple of items that I think need tidying up for the branch transfer page (/cgi-bin/koha/circ/branchtransfers.pl):
- When transferring, the page says "Reserve found", from our terminology list this should be "Hold found".
- There are grey backgrounds and a left border around the buttons.
- The text should be left aligned.
- The table looks "different" than others, I'm assuming because it is not using DataTables.

To replicate:
1. Apply bug 31781 if it hasn't been pushed to master.
2. Place an item level hold for a patron (select an item that is in another library).
3. Use the library transfer feature:
   - Circulation > Transfer > Transfer
   - Enter the barcode for the item and change the destination library
   - Select Submit
4. Note that:
   . The page says "Reserve found", from our terminology list this should be "Hold found".
   . The transfer and Ignore buttons have a grey background and there is a table border to the left.
   . The options are center aligned.
5. Choose an action, such as Transfer.
6. Note that the table displayed is "different" from normal tables that use DataTables styling/features.

Screenshots of before and after for bug 31781 attached.

Comment 1 Katrin Fischer 2022-10-15 07:48:58 UTC

There is also something weird about the display of the name - I think it should be using the standard template and it also has a line break, when there would be enough space.