Summary: | Add page section to item search results | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Searching | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | 31757 | ||
Attachments: |
Bug 31847: Add page-section class to item search results
Bug 31847: Add page-section class to item search results Bug 31847: Add page-section class to item search results |
Description
Lucas Gass (lukeg)
2022-10-17 17:31:20 UTC
Created attachment 142077 [details] [review] Bug 31847: Add page-section class to item search results To test: 1. Apply patch 2. Look at item search results ( itemsearch.tt ) 3. Make sure everthing looks right. Created attachment 142091 [details] [review] Bug 31847: Add page-section class to item search results To test: 1. Apply patch 2. Look at item search results ( itemsearch.tt ) 3. Make sure everthing looks right. Signed-off-by: David Nind <david@davidnind.com> The <<First < Previous and Next> Last>> buttons are "scrunched up". I'm not sure if that was the case before the staff interface refresh or not... (In reply to David Nind from comment #3) > The <<First < Previous and Next> Last>> buttons are "scrunched up". > > I'm not sure if that was the case before the staff interface refresh or > not... I think Owen is working on this on bug 31754 (In reply to Katrin Fischer from comment #4) > I think Owen is working on this on bug 31754 Excellent! Created attachment 142400 [details] [review] Bug 31847: Add page-section class to item search results To test: 1. Apply patch 2. Look at item search results ( itemsearch.tt ) 3. Make sure everthing looks right. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> We had some discussion on IRC about which elements on the top of the page should be outside or inside the page section, which ultimately led to filing bug 31915: We'd like a floating toolbar there please :) Pushed to master for 22.11. Nice work everyone, thanks! |