Bug 31847 - Add page section to item search results
Summary: Add page section to item search results
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Lucas Gass (lukeg)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency tree / graph
 
Reported: 2022-10-17 17:31 UTC by Lucas Gass (lukeg)
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31847: Add page-section class to item search results (1.32 KB, patch)
2022-10-18 14:16 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 31847: Add page-section class to item search results (1.37 KB, patch)
2022-10-18 19:54 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31847: Add page-section class to item search results (1.43 KB, patch)
2022-10-21 14:49 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2022-10-17 17:31:20 UTC 
The item search results page needs the page-section treatment.
Comment 1 Lucas Gass (lukeg) 2022-10-18 14:16:41 UTC 
Created attachment 142077 [details] [review]
Bug 31847: Add page-section class to item search results

To test:
1. Apply patch
2. Look at item search results ( itemsearch.tt )
3. Make sure everthing looks right.
Comment 2 David Nind 2022-10-18 19:54:27 UTC 
Created attachment 142091 [details] [review]
Bug 31847: Add page-section class to item search results

To test:
1. Apply patch
2. Look at item search results ( itemsearch.tt )
3. Make sure everthing looks right.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-10-18 19:57:39 UTC 
The <<First < Previous and Next> Last>> buttons are "scrunched up".

I'm not sure if that was the case before the staff interface refresh or not...
Comment 4 Katrin Fischer 2022-10-18 20:08:04 UTC 
(In reply to David Nind from comment #3)
> The <<First < Previous and Next> Last>> buttons are "scrunched up".
> 
> I'm not sure if that was the case before the staff interface refresh or
> not...

I think Owen is working on this on bug 31754
Comment 5 David Nind 2022-10-18 20:23:43 UTC 
(In reply to Katrin Fischer from comment #4)
> I think Owen is working on this on bug 31754

Excellent!
Comment 6 Katrin Fischer 2022-10-21 14:49:17 UTC 
Created attachment 142400 [details] [review]
Bug 31847: Add page-section class to item search results

To test:
1. Apply patch
2. Look at item search results ( itemsearch.tt )
3. Make sure everthing looks right.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 7 Katrin Fischer 2022-10-21 14:50:06 UTC 
We had some discussion on IRC about which elements on the top of the page should be outside or inside the page section, which ultimately led to filing bug 31915: We'd like a floating toolbar there please :)
Comment 8 Tomás Cohen Arazi (tcohen) 2022-10-24 14:55:50 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!