Bug 31848

Summary: Holds queue: Submit button for filters on the left is closer to nav than to its form
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: emily.lamancusa, gmcharlt, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks:    
Attachments: Bug 31848: Correct margin and padding on action fieldset in aside
Bug 31848: Correct margin and padding on action fieldset in aside
Bug 31848: Correct margin and padding on action fieldset in aside

Description Katrin Fischer 2022-10-17 19:52:30 UTC
On he holds queue page when you are looking at the holds, the submit button for the filters on the left is right about the navigation, but there is a big gap between the button and it's form.

Maybe the button should be even inside the white area?
Comment 1 Owen Leonard 2022-10-18 12:15:28 UTC
Created attachment 142053 [details] [review]
Bug 31848: Correct margin and padding on action fieldset in aside

This patch makes a minor modification to the padding and margin of
<fieldset class="action"> nested in a .brief fieldset. This markup is
seen most often in sidebar filter form. The change allows the submit
button to line up better with other form fields.

The patch also corrects and inconsistency by modifying the holds queue
template so that the .action fieldset is inside the .brief fieldset.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- If necessary, place one or more holds for pickup at your logged-in
  library and rebuild the holds queue
  (misc/cronjobs/holds/build_holds_queue.pl)
- Go to Circulation -> Holds queue.
- The form should look correct.
- Submit the form and check the form in the sidebar. It should look
  correct as well, with the submit button aligned left with the other
  form fields.
- Check pages with similar sidebar forms, e.g.:
  - Administration -> Budgets -> Funds -> Planning
  - Circulation -> Overdues
  - Circulation -> Holds to pull
  - Acquisitions -> Invoices -> Search results
Comment 2 David Nind 2022-10-18 20:09:09 UTC
Created attachment 142092 [details] [review]
Bug 31848: Correct margin and padding on action fieldset in aside

This patch makes a minor modification to the padding and margin of
<fieldset class="action"> nested in a .brief fieldset. This markup is
seen most often in sidebar filter form. The change allows the submit
button to line up better with other form fields.

The patch also corrects and inconsistency by modifying the holds queue
template so that the .action fieldset is inside the .brief fieldset.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- If necessary, place one or more holds for pickup at your logged-in
  library and rebuild the holds queue
  (misc/cronjobs/holds/build_holds_queue.pl)
- Go to Circulation -> Holds queue.
- The form should look correct.
- Submit the form and check the form in the sidebar. It should look
  correct as well, with the submit button aligned left with the other
  form fields.
- Check pages with similar sidebar forms, e.g.:
  - Administration -> Budgets -> Funds -> Planning
  - Circulation -> Overdues
  - Circulation -> Holds to pull
  - Acquisitions -> Invoices -> Search results

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2022-10-21 08:41:55 UTC
Created attachment 142306 [details] [review]
Bug 31848: Correct margin and padding on action fieldset in aside

This patch makes a minor modification to the padding and margin of
<fieldset class="action"> nested in a .brief fieldset. This markup is
seen most often in sidebar filter form. The change allows the submit
button to line up better with other form fields.

The patch also corrects and inconsistency by modifying the holds queue
template so that the .action fieldset is inside the .brief fieldset.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- If necessary, place one or more holds for pickup at your logged-in
  library and rebuild the holds queue
  (misc/cronjobs/holds/build_holds_queue.pl)
- Go to Circulation -> Holds queue.
- The form should look correct.
- Submit the form and check the form in the sidebar. It should look
  correct as well, with the submit button aligned left with the other
  form fields.
- Check pages with similar sidebar forms, e.g.:
  - Administration -> Budgets -> Funds -> Planning
  - Circulation -> Overdues
  - Circulation -> Holds to pull
  - Acquisitions -> Invoices -> Search results

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi 2022-10-21 13:27:22 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!