Bug 31850

Summary: Patron import: welcome email option style as list
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks:    
Attachments: Bug 31850: Patron import: welcome email option style as list
Bug 31850: Patron import: welcome email option style as list
Bug 31850: Patron import: welcome email option style as list

Description Katrin Fischer 2022-10-17 21:15:17 UTC
The welcome email option on the patron import page appears as list item with the dot in front of the checkbox. The list-style-type should be none here.
Comment 1 Owen Leonard 2022-10-18 17:56:13 UTC
Created attachment 142086 [details] [review]
Bug 31850: Patron import: welcome email option style as list

This patch corrects the markup around the "Send email to new patrons"
checkbox on the patron import page. The list should be an ordered list,
not an unordered list.

To test, apply the patch and go to Tools -> Import patrons.

In the "Welcome email" section, there should be no bullet point before
the "Send email to new patrons" line.
Comment 2 David Nind 2022-10-18 20:53:08 UTC
Created attachment 142100 [details] [review]
Bug 31850: Patron import: welcome email option style as list

This patch corrects the markup around the "Send email to new patrons"
checkbox on the patron import page. The list should be an ordered list,
not an unordered list.

To test, apply the patch and go to Tools -> Import patrons.

In the "Welcome email" section, there should be no bullet point before
the "Send email to new patrons" line.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2022-10-21 08:39:17 UTC
Created attachment 142305 [details] [review]
Bug 31850: Patron import: welcome email option style as list

This patch corrects the markup around the "Send email to new patrons"
checkbox on the patron import page. The list should be an ordered list,
not an unordered list.

To test, apply the patch and go to Tools -> Import patrons.

In the "Welcome email" section, there should be no bullet point before
the "Send email to new patrons" line.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi 2022-10-24 16:24:01 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!