Bug 31910

Summary: Article request form is misaligned/misformatted
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks:    
Attachments: Article form in staff interface
Bug 31910: Fix list and add page-section to request-article.tt
Bug 31910: Fix list and add page-section to request-article.tt
Bug 31910: Fix list and add page-section to request-article.tt

Description Katrin Fischer 2022-10-21 13:18:28 UTC
Created attachment 142363 [details]
Article form in staff interface

Make sure you activate ArticleRequests in system preferences and circulation rules. Search in staff interface, pick a record and request article. Search for the patron and look at the article form presented:

* list points appear
* fields and labels are mushed together
* item selection should probably be a page-section
Comment 1 Lucas Gass 2022-10-24 22:21:52 UTC
Created attachment 142578 [details] [review]
Bug 31910: Fix list and add page-section to request-article.tt

To test:
1. Apply patch
2. Look at article request form and ensure the fields and labels look good.
3. Ensure there are no more bullet points on the list.
4. Make sure the page-section div around the item selection looks good.
Comment 2 David Nind 2022-10-25 00:54:26 UTC
Created attachment 142590 [details] [review]
Bug 31910: Fix list and add page-section to request-article.tt

To test:
1. Apply patch
2. Look at article request form and ensure the fields and labels look good.
3. Ensure there are no more bullet points on the list.
4. Make sure the page-section div around the item selection looks good.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-26 22:03:11 UTC
Works perfectly, thanks!
Comment 4 Katrin Fischer 2022-10-26 22:05:28 UTC
Created attachment 142690 [details] [review]
Bug 31910: Fix list and add page-section to request-article.tt

To test:
1. Apply patch
2. Look at article request form and ensure the fields and labels look good.
3. Ensure there are no more bullet points on the list.
4. Make sure the page-section div around the item selection looks good.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-10-27 12:44:48 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!