Bug 31910 - Article request form is misaligned/misformatted
Summary: Article request form is misaligned/misformatted
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency tree / graph
 
Reported: 2022-10-21 13:18 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Article form in staff interface (24.49 KB, image/png)
2022-10-21 13:18 UTC, Katrin Fischer 		Details
Bug 31910: Fix list and add page-section to request-article.tt (9.73 KB, patch)
2022-10-24 22:21 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 31910: Fix list and add page-section to request-article.tt (9.78 KB, patch)
2022-10-25 00:54 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31910: Fix list and add page-section to request-article.tt (9.84 KB, patch)
2022-10-26 22:05 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-21 13:18:28 UTC 
Created attachment 142363 [details]
Article form in staff interface

Make sure you activate ArticleRequests in system preferences and circulation rules. Search in staff interface, pick a record and request article. Search for the patron and look at the article form presented:

* list points appear
* fields and labels are mushed together
* item selection should probably be a page-section
Comment 1 Lucas Gass (lukeg) 2022-10-24 22:21:52 UTC 
Created attachment 142578 [details] [review]
Bug 31910: Fix list and add page-section to request-article.tt

To test:
1. Apply patch
2. Look at article request form and ensure the fields and labels look good.
3. Ensure there are no more bullet points on the list.
4. Make sure the page-section div around the item selection looks good.
Comment 2 David Nind 2022-10-25 00:54:26 UTC 
Created attachment 142590 [details] [review]
Bug 31910: Fix list and add page-section to request-article.tt

To test:
1. Apply patch
2. Look at article request form and ensure the fields and labels look good.
3. Ensure there are no more bullet points on the list.
4. Make sure the page-section div around the item selection looks good.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-26 22:03:11 UTC 
Works perfectly, thanks!
Comment 4 Katrin Fischer 2022-10-26 22:05:28 UTC 
Created attachment 142690 [details] [review]
Bug 31910: Fix list and add page-section to request-article.tt

To test:
1. Apply patch
2. Look at article request form and ensure the fields and labels look good.
3. Ensure there are no more bullet points on the list.
4. Make sure the page-section div around the item selection looks good.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-10-27 12:44:48 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!